Simplify the tracker.New interface, just take a string

tracker/tracker.go

@@ -57,12 +57,17 @@ func RegisterClientScheme(scheme string, newFunc func(*url.URL) Client) {
 	schemes[scheme] = newFunc
 }
 
-func New(url *url.URL) (cl Client, err error) {
+// Returns ErrBadScheme if the tracker scheme isn't recognised.
-	newFunc, ok := schemes[url.Scheme]
+func New(rawurl string) (cl Client, err error) {
+	url_s, err := url.Parse(rawurl)
+	if err != nil {
+		return
+	}
+	newFunc, ok := schemes[url_s.Scheme]
 	if !ok {
 		err = ErrBadScheme
 		return
 	}
-	cl = newFunc(url)
+	cl = newFunc(url_s)
 	return
 }

tracker/udp/udp_tracker_test.go

@@ -8,7 +8,6 @@ import (
 	"encoding/hex"
 	"io"
 	"net"
-	"net/url"
 	"syscall"
 	"testing"
 )
@@ -84,13 +83,7 @@ func TestConvertInt16ToInt(t *testing.T) {
 }
 
 func TestUDPTracker(t *testing.T) {
-	tr, err := tracker.New(func() *url.URL {
+	tr, err := tracker.New("udp://tracker.openbittorrent.com:80/announce")
-		u, err := url.Parse("udp://tracker.openbittorrent.com:80/announce")
-		if err != nil {
-			t.Fatal(err)
-		}
-		return u
-	}())
 	if err != nil {
 		t.Fatal(err)
 	}