status-im/torrent
2
0
Fork 0
mirror of synced 2025-02-23 22:28:11 +00:00
Code Issues Packages Projects Releases Wiki Activity

Only steal an odd request if the stealer more recently received a chunk

Browse Source 
This helps break the stealing cycle during endgame, and lets us trickle the request to the peer conn with the best record. It might not be sufficient but works nice in testing so far.
This commit is contained in:
Matt Joiner 2021-12-07 14:19:44 +11:00
parent 7de7b986c9
commit 8c9a308c9a
1 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
requesting.go
View File

@ -231,7 +231,14 @@ func (p *Peer) applyRequestState(next desiredRequestState) bool {
continue
}
existing := t.requestingPeer(req)
if existing != nil && existing != p && existing.uncancelledRequests() > current.Requests.GetCardinality() {
if existing != nil && existing != p {
// Don't steal from the poor.
diff := int64(current.Requests.GetCardinality()) + 1 - (int64(existing.uncancelledRequests()) - 1)
// Steal a request that leaves us with one more request than the existing peer
// connection if the stealer more recently received a chunk.
if diff > 1 || (diff == 1 && p.lastUsefulChunkReceived.Before(existing.lastUsefulChunkReceived)) {
continue
}
t.cancelRequest(req)
}
more = p.mustRequest(req)