status-im
/
torrent
mirror of
2
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Merge maxRequests into localClientReqq

This commit is contained in:
Matt Joiner 2021-05-20 08:34:20 +10:00
parent 42bf6b58a6
commit 86524214f5
3 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
client.go
View File

@ -969,8 +969,9 @@ func (cl *Client) runHandshookConn(c *PeerConn, t *Torrent) error {
return nil
}
// If peer requests are buffered on read, this instructs the amount of memory that might be used to
// cache pending writes. Assuming 512KiB cached for sending, for 16KiB chunks.
// Maximum pending requests we allow peers to send us. If peer requests are buffered on read, this
// instructs the amount of memory that might be used to cache pending writes. Assuming 512KiB
// (1<<19) cached for sending, for 16KiB (1<<14) chunks.
const localClientReqq = 1 << 5
// See the order given in Transmission's tr_peerMsgsNew.

1
global.go
View File

@ -9,7 +9,6 @@ import (
const (
pieceHash = crypto.SHA1
maxRequests = 250 // Maximum pending requests we allow peers to send us.
defaultChunkSize = 0x4000 // 16KiB
)

5
peerconn.go
View File

@ -989,7 +989,8 @@ func (c *PeerConn) onReadRequest(r Request) error {
}
return nil
}
if len(c.peerRequests) >= maxRequests {
// TODO: What if they've already requested this?
if len(c.peerRequests) >= localClientReqq {
torrent.Add("requests received while queue full", 1)
if c.fastEnabled() {
c.reject(r)
@ -1010,7 +1011,7 @@ func (c *PeerConn) onReadRequest(r Request) error {
return errors.New("bad Request")
}
if c.peerRequests == nil {
c.peerRequests = make(map[Request]*peerRequestState, maxRequests)
c.peerRequests = make(map[Request]*peerRequestState, localClientReqq)
}
value := &peerRequestState{}
c.peerRequests[r] = value