From e8eadb88604a3507d207b98de4fc7acea6c05812 Mon Sep 17 00:00:00 2001 From: Adam Babik Date: Tue, 17 Apr 2018 09:47:04 +0200 Subject: [PATCH] Finish Refactor status-go geth packages (#180) --- README.md | 2 +- ideas/63-refactor-geth-packages.md | 8 ++++++-- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/README.md b/README.md index 983bcef..2d8952a 100644 --- a/README.md +++ b/README.md @@ -40,7 +40,6 @@ aborted. | [83-energy-efficient](ideas/83-energy-efficient.md) | :walking_man: In Progress | :white_check_mark: Yes | :white_check_mark: Yes | :white_check_mark: Yes | :white_check_mark: Yes | | [80-onboarding](ideas/80-onboarding.md) | :walking_man: In Progress | :white_check_mark: Yes | :white_check_mark: Yes | :white_check_mark: Yes | :white_check_mark: Yes | | [68-core-metrics](ideas/68-core-metrics.md) | :walking_man: In Progress | :white_check_mark: Yes | :white_check_mark: Yes | :white_check_mark: Yes | :white_check_mark: Yes | -| [63-refactor-geth-packages](ideas/63-refactor-geth-packages.md) | :walking_man: In Progress | :white_check_mark: Yes | :white_check_mark: Yes | :white_check_mark: Yes | :white_check_mark: Yes | | [58-mainnet](ideas/58-mainnet.md) | :walking_man: In Progress | :white_check_mark: Yes | :white_check_mark: Yes | :white_check_mark: Yes | :white_check_mark: Yes | | [34-react-native-qt](ideas/34-react-native-qt.md) | :walking_man: In Progress | :white_check_mark: Yes | :white_check_mark: Yes | :white_check_mark: Yes | :white_check_mark: Yes | | [140-sob-improve-onboarding](ideas/140-sob-improve-onboarding/) | :walking_man: In Progress | :white_check_mark: Yes | :white_check_mark: Yes | :white_check_mark: Yes | :white_check_mark: Yes | @@ -73,6 +72,7 @@ aborted. | [61-app-structure-refinement](ideas/61-app-structure-refinement.md) | :champagne: Completed | :white_check_mark: Yes | :white_check_mark: Yes | :white_check_mark: Yes | - | | [3-erc20-token-support](ideas/3-erc20-token-support.md) | :champagne: Completed | :white_check_mark: Yes | :white_check_mark: Yes | :white_check_mark: Yes | - | | [1-offline-inboxing](ideas/1-offline-inboxing.md) | :champagne: Completed | :white_check_mark: Yes | :white_check_mark: Yes | :white_check_mark: Yes | - | +| [63-refactor-geth-packages](ideas/63-refactor-geth-packages.md) | :champagne: Completed | :white_check_mark: Yes | :white_check_mark: Yes | :white_check_mark: Yes | - | ## Commitment Registry diff --git a/ideas/63-refactor-geth-packages.md b/ideas/63-refactor-geth-packages.md index 53874f4..87f9ad6 100644 --- a/ideas/63-refactor-geth-packages.md +++ b/ideas/63-refactor-geth-packages.md @@ -1,8 +1,8 @@ ## Preamble Idea: 63-refactor-geth-packages - Title: Refactor status-go node package - Status: In Progress + Title: Refactor status-go geth packages + Status: Done Created: 2017-12-20 ## Summary @@ -91,5 +91,9 @@ A PR in status-react is created with updated status-go version. 1. All iterations are done. There is no threat that they can't be finished. 1. New version of status-go is merged into `status-react` develop branch. +## Summary after finish + +The first and second success metrics have been achieved. We managed to reduce dependencies between packages and get rid of `common` package. No change did negatively impact tests reliability and all tests pass properly. With regard to the third metric, we haven't implemented automated race condition checks yet so it's hard to tell but there are no race condition issues reported so far. + ## Copyright Copyright and related rights waived via [CC0](https://creativecommons.org/publicdomain/zero/1.0/).