status-im
/
status-web
mirror of https://github.com/status-im/status-web.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

Wrap decoding in try...catch (#279)

This commit is contained in:
Felicio Mununga 2022-06-17 09:35:40 +02:00 committed by GitHub
parent a8f6b94ce2
commit 944170247e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 104 additions and 97 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

201
packages/status-js/src/client/community/handle-waku-message.ts
View File

@ -41,7 +41,9 @@ export function handleWakuMessage(
if (decodedProtocol) { if (decodedProtocol) {
messageToDecode = decodedProtocol.publicMessage messageToDecode = decodedProtocol.publicMessage
} }
} catch {} } catch {
// eslint-disable-next-line no-empty
}
const decodedMetadata = ApplicationMetadataMessage.decode(messageToDecode) const decodedMetadata = ApplicationMetadataMessage.decode(messageToDecode)
if (!decodedMetadata.payload) { if (!decodedMetadata.payload) {
@ -67,106 +69,111 @@ export function handleWakuMessage(
let success = false let success = false
// decode, map and handle (events) // decode, map and handle (events)
switch (decodedMetadata.type) { try {
case ApplicationMetadataMessage.Type.TYPE_COMMUNITY_DESCRIPTION: { switch (decodedMetadata.type) {
// decode case ApplicationMetadataMessage.Type.TYPE_COMMUNITY_DESCRIPTION: {
const decodedPayload = CommunityDescription.decode(messageToDecode) // decode
const decodedPayload = CommunityDescription.decode(messageToDecode)
// handle (state and callback) // handle (state and callback)
community.handleDescription(decodedPayload) community.handleDescription(decodedPayload)
success = true success = true
break break
}
case ApplicationMetadataMessage.Type.TYPE_CHAT_MESSAGE: {
// decode
const decodedPayload = ChatMessage.decode(messageToDecode)
// TODO?: ignore community.channelMessages which are messageType !== COMMUNITY_CHAT
const chatUuid = getChatUuid(decodedPayload.chatId)
// map
const chatMessage = mapChatMessage(decodedPayload, {
messageId,
chatUuid,
})
// handle
community.chats.get(chatUuid)?.handleNewMessage(chatMessage)
success = true
break
}
case ApplicationMetadataMessage.Type.TYPE_EDIT_MESSAGE: {
const decodedPayload = EditMessage.decode(messageToDecode)
const messageId = decodedPayload.messageId
const chatUuid = getChatUuid(decodedPayload.chatId)
community.chats
.get(chatUuid)
?.handleEditedMessage(messageId, decodedPayload.text)
success = true
break
}
case ApplicationMetadataMessage.Type.TYPE_DELETE_MESSAGE: {
const decodedPayload = DeleteMessage.decode(messageToDecode)
const messageId = decodedPayload.messageId
const chatUuid = getChatUuid(decodedPayload.chatId)
community.chats.get(chatUuid)?.handleDeletedMessage(messageId)
success = true
break
}
case ApplicationMetadataMessage.Type.TYPE_PIN_MESSAGE: {
const decodedPayload = PinMessage.decode(messageToDecode)
const messageId = decodedPayload.messageId
const chatUuid = getChatUuid(decodedPayload.chatId)
community.chats
.get(chatUuid)
?.handlePinnedMessage(messageId, decodedPayload.pinned)
success = true
break
}
case ApplicationMetadataMessage.Type.TYPE_EMOJI_REACTION: {
const decodedPayload = EmojiReaction.decode(messageToDecode)
const messageId = decodedPayload.messageId
const chatUuid = getChatUuid(decodedPayload.chatId)
const chat = community.chats.get(chatUuid)
chat?.handleEmojiReaction(
messageId,
decodedPayload,
`0x${bytesToHex(publicKey)}`
)
success = true
break
}
default:
success = true
break
} }
} catch {
case ApplicationMetadataMessage.Type.TYPE_CHAT_MESSAGE: { // protons-runtime throws when trying to decode invalid protocol buffers
// decode success = true
const decodedPayload = ChatMessage.decode(messageToDecode)
// TODO?: ignore community.channelMessages which are messageType !== COMMUNITY_CHAT
const chatUuid = getChatUuid(decodedPayload.chatId)
// map
const chatMessage = mapChatMessage(decodedPayload, {
messageId,
chatUuid,
})
// handle
community.chats.get(chatUuid)?.handleNewMessage(chatMessage)
success = true
break
}
case ApplicationMetadataMessage.Type.TYPE_EDIT_MESSAGE: {
const decodedPayload = EditMessage.decode(messageToDecode)
const messageId = decodedPayload.messageId
const chatUuid = getChatUuid(decodedPayload.chatId)
community.chats
.get(chatUuid)
?.handleEditedMessage(messageId, decodedPayload.text)
success = true
break
}
case ApplicationMetadataMessage.Type.TYPE_DELETE_MESSAGE: {
const decodedPayload = DeleteMessage.decode(messageToDecode)
const messageId = decodedPayload.messageId
const chatUuid = getChatUuid(decodedPayload.chatId)
community.chats.get(chatUuid)?.handleDeletedMessage(messageId)
success = true
break
}
case ApplicationMetadataMessage.Type.TYPE_PIN_MESSAGE: {
const decodedPayload = PinMessage.decode(messageToDecode)
const messageId = decodedPayload.messageId
const chatUuid = getChatUuid(decodedPayload.chatId)
community.chats
.get(chatUuid)
?.handlePinnedMessage(messageId, decodedPayload.pinned)
success = true
break
}
case ApplicationMetadataMessage.Type.TYPE_EMOJI_REACTION: {
const decodedPayload = EmojiReaction.decode(messageToDecode)
const messageId = decodedPayload.messageId
const chatUuid = getChatUuid(decodedPayload.chatId)
const chat = community.chats.get(chatUuid)
chat?.handleEmojiReaction(
messageId,
decodedPayload,
`0x${bytesToHex(publicKey)}`
)
success = true
break
}
default:
success = true
break
} }
if (success) { if (success) {