status-im
/
status-web
mirror of https://github.com/status-im/status-web.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

Wrap decoding in try...catch (#279)

This commit is contained in:
Felicio Mununga 2022-06-17 09:35:40 +02:00 committed by GitHub
parent a8f6b94ce2
commit 944170247e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 104 additions and 97 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
packages/status-js/src/client/community/handle-waku-message.ts
View File

@ -41,7 +41,9 @@ export function handleWakuMessage(
if (decodedProtocol) { if (decodedProtocol) {
messageToDecode = decodedProtocol.publicMessage messageToDecode = decodedProtocol.publicMessage
} }
} catch {} } catch {
// eslint-disable-next-line no-empty
}
const decodedMetadata = ApplicationMetadataMessage.decode(messageToDecode) const decodedMetadata = ApplicationMetadataMessage.decode(messageToDecode)
if (!decodedMetadata.payload) { if (!decodedMetadata.payload) {
@ -67,6 +69,7 @@ export function handleWakuMessage(
let success = false let success = false
// decode, map and handle (events) // decode, map and handle (events)
try {
switch (decodedMetadata.type) { switch (decodedMetadata.type) {
case ApplicationMetadataMessage.Type.TYPE_COMMUNITY_DESCRIPTION: { case ApplicationMetadataMessage.Type.TYPE_COMMUNITY_DESCRIPTION: {
// decode // decode
@ -168,6 +171,10 @@ export function handleWakuMessage(
break break
} }
} catch {
// protons-runtime throws when trying to decode invalid protocol buffers
success = true
}
if (success) { if (success) {
client.wakuMessages.add(messageId) client.wakuMessages.add(messageId)