c69863cda2
This commit does a few things: ==== Ordering of messages ==== Change the ordering of messages from a mixture of timestamp/clock-value to use only clock-value. Datemarks are now not used for sorting anymore, which means that the order of messages is always causally related (not the case before, as we were breaking this property by sorting by datemark), but datemark calculation is unreliable (a reply to a message might have a timestamp < then the message that is replied to). So for timestamp calculation we naively group them ignoring "out-of-order timestamp" messages, although there's much to improve. It fixes an issue whereby the user would change their time and the message will be displayed in the past, although it is still possible to craft a message with a lower clock value and order it in the past (there's no way we can prevent this to some extent, but there are ways to mitigate, but outside the scope of this PR). ==== Performance of receiving messages ==== The app would freeze on pulling messages from a mailserver (100 or so). This is due to the JS Thread being hogged by CPU calculation, coupled with the fact that we always tried to process messages all in one go. This strategy can't scale, and given x is big enough (200,300,1000) the UI will freeze. Instead, each message is now processed separately, and we leave a gap between processing each message for the UI to respond to user input (otherwise the app freezes again). Pulling messages will be longer overall, but the app will be usuable while this happen (albeit it might slow down). Other strategies are possible (calculate off-db and do a big swap, avoiding many re-renders etc), but this is the reccommended strategy by re-frame author (Solving the CPU Hog problem), so sounds like a safe base point. The underlying data structure for holding messages was also changed, we used an immutable Red and Black Tree, same as a sorted map for clojure, but we use a js library as is twice as performing then clojure sorted map. We also don't sort messages again each time we receive them O(nlogn), but we insert them in order O(logn). Other data structures considered but discarded: 1) Plain vector, but performance prepending/insertion in the middle (both O(n)) were not great, as not really suited for these operations. 2) Linked list, appealing as append/prepend is O(1), while insertion is O(n). This is probably acceptable as messages tend to come in order (from the db, so adding N messages is O(n)), or the network (most of them prepends, or close to the head), while mailserver would not follow this path. An implementation of a linked list was built, which performed roughtly the same as a clojure sorted-map (although faster append/prepend), but not worth the complexity of having our own implementation. 3) Clojure sorted-map, probably the most versatile, performance were acceptable, but nowhere near the javascript implementation we decided on 4) Priority map, much slower than a sorted map (twice as slow) 5) Mutable sorted map, js implementation, (bintrees), not explored this very much, but from just a quick benchmark, performance were much worse that clojure immutable sorted map Given that each message is now processed separately, saving the chat / messages is also debounced to avoid spamming status-go with network requests. This is a temporary measure for now until that's done directly in status-go, without having to ping-pong with status-react. Next steps performance wise is to move stuff to status-go, parsing of transit, validation, which is heavy, at which point we can re-consider performance and how to handle messages. Fixes also an issue with the last message in the chat, we were using the last message in the chat list, which might not necessarely be the last message the chat has seen, in case messages were not loaded and a more recent message is the database (say you fetch historical messages for 1-to-1 A, you don't have any messages in 1-to-1 chat B loaded, you receive an historical message for chat B, it sets it as last message). Also use clj beans instead of js->clj for type conversion Signed-off-by: Andrea Maria Piana <andrea.maria.piana@gmail.com> |
||
|---|---|---|
| .dependabot | ||
| .github | ||
| android | ||
| ci | ||
| components/src/status_im | ||
| deployment | ||
| desktop | ||
| dev/status_im | ||
| doc | ||
| env | ||
| fastlane | ||
| fiddle | ||
| ios | ||
| mobile/js_files | ||
| modules | ||
| nix | ||
| patches | ||
| prod/status_im | ||
| react-native/src | ||
| resources | ||
| scripts | ||
| src/status_im | ||
| status-modules | ||
| test | ||
| translations | ||
| .TOOLVERSIONS | ||
| .babelrc | ||
| .buckconfig | ||
| .dockerignore | ||
| .env | ||
| .env.e2e | ||
| .env.jenkins | ||
| .env.nightly | ||
| .env.release | ||
| .envrc | ||
| .eslintrc.js | ||
| .flowconfig | ||
| .gitattributes | ||
| .gitignore | ||
| .mailmap | ||
| .nycrc | ||
| .prettierrc.js | ||
| .watchmanconfig | ||
| ICONS.md | ||
| LICENSE.md | ||
| Makefile | ||
| README.md | ||
| REVIEW.md | ||
| TROUBLESHOOTING.md | ||
| VERSION | ||
| app.json | ||
| build.clj | ||
| clj-rn.conf.edn | ||
| default.nix | ||
| deps.edn | ||
| export-icons.gif | ||
| externs.js | ||
| figwheel-bridge.js | ||
| findSymlinkedModules.js.patch | ||
| prepare-modules.js | ||
| project.clj | ||
| react-native.config.js | ||
| rn-cli.config.js | ||
| shell.nix | ||
| status-go-version.json | ||
| supervisord.conf | ||
| ubuntu-server.js | ||
README.md
Status - a Mobile Ethereum Operating System
Join us in creating a browser, messenger, and gateway to a decentralized world. Status is a free (libre) open source mobile client targeting Android & iOS built entirely on Ethereum technologies. That's right, no middle men and go-ethereum running directly on your device.
Why?
We believe in a medium of pure free trade, economies with fair, permission-less access and a world without intermediaries. We want to create policies that can exist between friends or scale globally, we want to communicate securely and be uninhibited by legacy systems.
We want to take responsibility for our data, the way we conduct ourselves privately and promote this way of life to a mass audience.
We want deep insights into our own economies so we can make informed, data-driven decisions on how to make our lives better. The Ethereum blockchain, Smart Contracts, Swarm and Whisper provides us a path forward.
If this interests you, help us make Status a reality - anyone can contribute and we need everyone at any skill level to participate.
How to Contribute?
Go straight to the docs or join our chat and choose what interests you:
-
Developer Developers are the heart of software and to keep Status beating we need all the help we can get! If you're looking to code in ClojureScript or Golang then Status is the project for you! We use React Native and there is even some Java/Objective-C too!
Want to learn more about it? Start by reading our Developer Introduction which guides you through the technology stack and start browsing beginner issues. Then you can read how to Build Status, which talks about managing project dependencies, coding guidelines and testing procedures. -
Community Management
Metcalfe's law states that the value of a network is proportional to the square of the number of connected users of the system - without community Status is meaningless. We're looking to create a positive, fun environment to explore new ideas, experiment and grow the Status community. Building a community takes a lot of work but the people you'll meet and long lasting relationships you form will be well worth it, check out our Community Principles -
Specification / Documentation
John Dewey once said "Education is not preparation for life; education is life itself ". Developers & Designers need guidance and it all starts from documentation and specifications. Our software is only as good as its documentation, head over to our docs and see how you can improve what we have. -
Blog Writing
Content is King, keeping our blog up to date and informing the community of news helps keep everyone on the same page. Jump into our chat and discuss with the team how you can contribute! -
Testers
It's bug hunting season! Status is currently in Alpha and there is sure to be a bunch of learning, build status from scratch or if an android user check out our nightly builds. You can shake your phone to submit bug reports, or start browsing our Github Issues. Every bug you find brings Status closer to stable, usable software for everyone to enjoy! -
Security
Status is a visual interface to make permanent changes on the Blockchain, it handles crypto-tokens that have real value and allows 3rd party code execution. Security is paramount to its success. You are given permission to break Status as hard as you can, as long as you share your findings with the community! -
Evangelism
Help us spread the word! Tell a friend right now, in fact tell everyone - yell from a mountain if you have to, every person counts! If you've got a great story to tell or have some interesting way you've spread the word about Status let us know about it in our chat
Status API
View our API Docs and learn how to integrate your DApp into Status. You can read more about how to add your DApp to Status here.
Give me Binaries!
You can get our Beta builds for both Android and iOS on our website, through our nightly builds or by building it yourself.
Core Contributors
Special thanks to @adrian-tiberius. Without the dedication of these outstanding individuals, Status would not exist.
Contact us
Feel free to email us at support@status.im or better yet, join our chat.
License
Licensed under the Mozilla Public License v2.0
Testing Supported by
