mirror of
https://github.com/status-im/status-react.git
synced 2025-01-11 03:26:31 +00:00
aa2345d35c
Change the make "lint" target default behavior to NOT show clj-kondo warnings.
In the CI, I kept the same behavior, i.e. show all warnings and errors
simultaneously.
Motivation:
When devs run make lint, most of the time, they don't want to see a long list of
warnings. Their focus is on the errors. Additionally, the majority of devs in
the mobile team see clj-kondo warnings in their editors of choice already.
We (some of us) believe the editor feedback/warnings are sufficiently noisy.
Add the following somewhere in your config files if you want to see
warnings.
export CLJ_LINTER_PRINT_WARNINGS=true
87 lines
1.9 KiB
Groovy
87 lines
1.9 KiB
Groovy
#!/usr/bin/env groovy
|
|
library 'status-jenkins-lib@v1.7.15'
|
|
|
|
/* Options section can't access functions in objects. */
|
|
def isPRBuild = utils.isPRBuild()
|
|
|
|
pipeline {
|
|
agent { label 'linux && x86_64 && nix-2.14' }
|
|
|
|
options {
|
|
timestamps()
|
|
/* Prevent Jenkins jobs from running forever */
|
|
timeout(time: 15, unit: 'MINUTES')
|
|
/* Limit builds retained */
|
|
buildDiscarder(logRotator(
|
|
numToKeepStr: '10',
|
|
daysToKeepStr: '20',
|
|
artifactNumToKeepStr: '10',
|
|
))
|
|
/* Abort old PR builds. */
|
|
disableConcurrentBuilds(
|
|
abortPrevious: isPRBuild
|
|
)
|
|
}
|
|
|
|
parameters {
|
|
string(
|
|
name: 'BUILD_TYPE',
|
|
description: 'Specify build type. Values: pr / e2e / nightly / release',
|
|
defaultValue: 'pr',
|
|
)
|
|
}
|
|
|
|
environment {
|
|
LANG = "en_US.UTF-8"
|
|
LC_ALL = "en_US.UTF-8"
|
|
LANGUAGE = "en_US.UTF-8"
|
|
TARGET = 'tests'
|
|
BUILD_ENV = 'prod'
|
|
NIX_CONF_DIR = "${env.WORKSPACE}/nix"
|
|
LOG_FILE = utils.pkgFilename(ext: 'log', arch: 'tests')
|
|
}
|
|
|
|
stages {
|
|
stage('Checks') {
|
|
parallel {
|
|
stage('Lint') {
|
|
steps {
|
|
sh """#!/bin/bash
|
|
set -eo pipefail
|
|
make lint CLJ_LINTER_PRINT_WARNINGS=true 2>&1 | tee ${LOG_FILE}
|
|
"""
|
|
}
|
|
}
|
|
stage('Tests') {
|
|
steps {
|
|
sh """#!/bin/bash
|
|
set -eo pipefail
|
|
make test 2>&1 | tee -a ${LOG_FILE}
|
|
"""
|
|
}
|
|
}
|
|
}
|
|
}
|
|
stage('Component Tests') {
|
|
steps {
|
|
sh """#!/bin/bash
|
|
set -eo pipefail
|
|
make component-test 2>&1 | tee -a ${LOG_FILE}
|
|
"""
|
|
}
|
|
}
|
|
stage('Upload') {
|
|
steps {
|
|
script {
|
|
env.PKG_URL = s3.uploadArtifact(LOG_FILE)
|
|
}
|
|
}
|
|
}
|
|
}
|
|
post {
|
|
success { script { github.notifyPR(true) } }
|
|
failure { script { github.notifyPR(false) } }
|
|
always { sh 'make purge' }
|
|
}
|
|
}
|