a17efa7299
Changes effect :json/rpc-call to accept on-success and on-error parameters either as functions OR as re-frame event vectors. The changes are 100% backwards compatible. ## Why? Re-frame is very explicit in its documentation and its architecture, saying that event handlers should be pure. Calling re-frame.core/dispatch in event handlers makes them sort of stateful. > So, you can "get away with it". But it ain't pure. > > -- https://day8.github.io/re-frame/EffectfulHandlers/#90-solution In status-mobile, arguably one of our most important effects (not to be confused with event handlers) is :json-rpc/call, but at the moment, the on-success and on-error values are expected to be stateful functions (e.g. usually used for logging and dispatching subsequent events). This creates two important problems: 1. The value returned by event handlers is more opaque and cannot be easily inspected (for example using tap>, log/debug or just println). If we try to inspect or log them, on-success and on-error will be printed as #object[Function]. 2. Testing event handlers using :json-rpc/call becomes an exercise of frustration, because we can't simply compare the results of the event handler with a good expected value, which is one of the big selling points of testing pure functions. ### The testability of event handlers > For any re-frame app, there's three things to test: > > - Event Handlers - most of your testing focus will be here because this is > where most of the logic lives > - Subscription Handlers - often not a lot to test here. Only Layer 3 > subscriptions need testing. > - View functions - I don't tend to write tests for views. > > -- https://day8.github.io/re-frame/Testing/#what-to-test So re-frame is saying event handlers should be pure, and that event handlers should be tested. In order to achieve the divine simplicity of testing event handlers as pure functions, we need to make :json-rpc/call also accept on-success and on-error as event vectors. Good news is that there is a known pattern to solve this problem, e.g. used by the library https://github.com/Day8/re-frame-http-fx. The pattern is simple once we see it: behind the scenes, :json-rpc/call conj'es the results of the RPC call into the event vectors on-success and on-error, and :json-rpc/call dispatches the events itself. This eliminates the need for the stateful dispatch call in event handlers. |
||
|---|---|---|
| .clj-kondo | ||
| .dependabot | ||
| .github | ||
| android | ||
| ci | ||
| doc | ||
| fastlane | ||
| ios | ||
| modules/react-native-status | ||
| nix | ||
| resources | ||
| scripts | ||
| src | ||
| test | ||
| test-resources | ||
| translations | ||
| visual-test | ||
| .buckconfig | ||
| .carve_ignore | ||
| .detoxrc.js | ||
| .dockerignore | ||
| .env | ||
| .env.e2e | ||
| .env.jenkins | ||
| .env.nightly | ||
| .env.release | ||
| .envrc | ||
| .eslintrc.js | ||
| .flowconfig | ||
| .gitattributes | ||
| .gitignore | ||
| .mailmap | ||
| .nycrc | ||
| .prettierrc.js | ||
| .watchmanconfig | ||
| .zprintrc | ||
| LICENSE.md | ||
| Makefile | ||
| README.md | ||
| RELEASES.md | ||
| VERSION | ||
| app.json | ||
| babel.config.js | ||
| binding.gyp | ||
| default.nix | ||
| index.js | ||
| metro.config.js | ||
| package.json | ||
| react-native.config.js | ||
| shadow-cljs.edn | ||
| shell.nix | ||
| status-go-version.json | ||
| supervisord.conf | ||
| yarn.lock | ||
README.md
Status - a Mobile Ethereum Operating System
Join us in creating a browser, messenger, and gateway to a decentralized world. Status is a free (libre) open source mobile client targeting Android & iOS built entirely on Ethereum technologies. That's right, no middle men and go-ethereum running directly on your device.
Why?
We believe in a medium of pure free trade, economies with fair, permission-less access and a world without intermediaries. We want to create policies that can exist between friends or scale globally, we want to communicate securely and be uninhibited by legacy systems.
We want to take responsibility for our data, the way we conduct ourselves privately and promote this way of life to a mass audience.
We want deep insights into our own economies so we can make informed, data-driven decisions on how to make our lives better. The Ethereum blockchain, Smart Contracts, Swarm and Whisper provides us a path forward.
If this interests you, help us make Status a reality - anyone can contribute and we need everyone at any skill level to participate.
How to Contribute?
Go straight to the docs or join our chat and choose what interests you:
-
Developer Developers are the heart of software and to keep Status beating we need all the help we can get! If you're looking to code in ClojureScript or Golang then Status is the project for you! We use React Native and there is even some Java/Objective-C too! Want to learn more about it? Start by reading our Developer Introduction which guides you through the technology stack and start browsing beginner issues. Then you can read how to Build Status, which talks about managing project dependencies, coding guidelines and testing procedures. The doc/ directory also has valuable information for contributors.
-
Community Management Metcalfe's law states that the value of a network is proportional to the square of the number of connected users of the system - without community Status is meaningless. We're looking to create a positive, fun environment to explore new ideas, experiment and grow the Status community. Building a community takes a lot of work but the people you'll meet and long lasting relationships you form will be well worth it, check out our Mission and Community Principles
-
Specification / Documentation John Dewey once said "Education is not preparation for life; education is life itself ". Developers & Designers need guidance and it all starts from documentation and specifications. Our software is only as good as its documentation, head over to our docs and see how you can improve what we have.
-
Blog Writing Content is King, keeping our blog up to date and informing the community of news helps keep everyone on the same page. Jump into our chat and discuss with the team how you can contribute!
-
Testers It's bug hunting season! Status is currently under active development and there is sure to be a bunch of learning, build status from scratch or if an android user check out our nightly builds. You can shake your phone to submit bug reports, or start browsing our Github Issues. Every bug you find brings Status closer to stable, usable software for everyone to enjoy!
-
Security Status is a visual interface to make permanent changes on the Blockchain, it handles crypto-tokens that have real value and allows 3rd party code execution. Security is paramount to its success. You are given permission to break Status as hard as you can, as long as you share your findings with the community!
-
Evangelism Help us spread the word! Tell a friend right now, in fact tell everyone - yell from a mountain if you have to, every person counts! If you've got a great story to tell or have some interesting way you've spread the word about Status let us know about it in our chat
Status API
View our API Docs and learn how to integrate your DApp into Status. You can read more about how to add your DApp to Status here.
Give me Binaries!
You can get our Beta builds for both Android and iOS on our website, through our nightly builds or by building it yourself.
Core Contributors
Special thanks to @adrian-tiberius. Without the dedication of these outstanding individuals, Status would not exist.
Contact us
Feel free to email us at support@status.im or better yet, join our chat.
License
Licensed under the Mozilla Public License v2.0
Testing Supported by
