a free (libre) open source, mobile OS for Ethereum https://status.im
Go to file
Icaro Motta 9ed68ee7d1
Lint & fix some shadowed core Clojure(Script) vars (#16500)
It's well known that shadowing core Clojure vars can lead to unexpected bugs. In
fact, it's a common source of bugs in other languages too. In the status-mobile
repository there are, in total, 562 shadowed vars, ~500 are core vars. Excluding
the "old code" we still have 285 offenders.

In status-mobile I've already seen two bugs caused by shadowed vars, both with
the shadowed var "name". But probably other problems happened in the past, and
others will happen in the future if we don't do something about this. This PR is
also my response to my frustration trying to review PRs and checking for
shadowed vars, humans were not meant for that!

In this commit we are enabling ":shadowed-var" to lint certain (not all) core
vars as errors (not warnings). In future PRs we can gradually unshadow more
vars. For the record, name is shadowed 40 times in the new code and 130 in
total, and type is shadowed 93 times in the new code and 124 in total!

What about non-core vars, should we allow shadowing? There are ~70 non-core
shadowed vars. In my opinion, we should also lint and disallow shadowing
non-core vars, since it may cause the same kind of bugs of shadowing core vars.
But this decision can be left for another moment/issue, after we have fixed the
most prominent problem of shadowing core vars.

Which vars are unshadowed in this PR? I fixed 62 errors and unshadowed
cljs.core/iter, cljs.core/time, cljs.core/count, cljs.core/key,
clojure.core/key.

Resources:

- [clj-kondo linter: shadowed-var](https://github.com/clj-kondo/clj-kondo/blob/master/doc/linters.md#shadowed-var)
2023-07-06 10:28:07 +00:00
.clj-kondo Lint & fix some shadowed core Clojure(Script) vars (#16500) 2023-07-06 10:28:07 +00:00
.dependabot [Fixes: #11518] Fix dependabot directory 2020-12-07 12:14:16 +01:00
.github Lint and fix missing trailing newlines (#16445) 2023-07-04 19:40:13 +00:00
android android: fix Gradle deps, drop Flipper, upgrade Fresco 2023-06-23 12:02:18 +02:00
ci e2e: change numpocesses (#16494) 2023-07-05 14:59:36 +02:00
doc Lint and fix missing trailing newlines (#16445) 2023-07-04 19:40:13 +00:00
fastlane ios: drop fastlane-plugin-clean_testflight_testers 2023-05-24 11:52:01 +02:00
ios Lint and fix missing trailing newlines (#16445) 2023-07-04 19:40:13 +00:00
modules/react-native-status multiaccounts refactoring S3, refactor keychain and touchid, move and refactor create/recover/login profile (#16448) 2023-07-06 11:25:57 +02:00
nix nix: downgrade watchman to 4.9.0 2023-07-02 08:46:28 +02:00
resources Lint and fix missing trailing newlines (#16445) 2023-07-04 19:40:13 +00:00
scripts Lint and fix missing trailing newlines (#16445) 2023-07-04 19:40:13 +00:00
src Lint & fix some shadowed core Clojure(Script) vars (#16500) 2023-07-06 10:28:07 +00:00
test e2e: more groups (#16483) 2023-07-05 11:55:40 +02:00
test-resources Update prettier config for the project. (#16303) 2023-06-19 19:09:12 +05:30
translations Lint and fix missing trailing newlines (#16445) 2023-07-04 19:40:13 +00:00
.buckconfig upgrade react-native and packages - but broken 2016-04-24 15:07:08 +07:00
.carve_ignore move status native module (#15749) 2023-04-26 18:14:14 +02:00
.dockerignore Create Nix package for building status-go 2019-04-09 12:44:39 +02:00
.env UI for mobile to mobile local pairing - updated (#14514) 2022-12-16 18:40:56 +05:30
.env.e2e UI for mobile to mobile local pairing - updated (#14514) 2022-12-16 18:40:56 +05:30
.env.jenkins UI for mobile to mobile local pairing - updated (#14514) 2022-12-16 18:40:56 +05:30
.env.nightly Enable waku2 by default 2022-12-15 12:39:49 +00:00
.env.release Enable waku2 by default 2022-12-15 12:39:49 +00:00
.envrc Add login integration test 2022-06-08 13:43:32 +01:00
.eslintrc.js Update prettier config for the project. (#16303) 2023-06-19 19:09:12 +05:30
.flowconfig RN 63 and xcode12 2021-01-14 09:41:38 +01:00
.gitattributes Desktop branch merged into develop (#5266) 2018-07-23 18:21:31 +03:00
.gitignore chore: add lefthook.yml to gitignore file (#16288) 2023-06-15 07:50:40 -03:00
.mailmap fix my name 2019-02-28 14:50:42 +01:00
.nycrc add coverage test 2019-07-10 16:15:44 -04:00
.prettierignore Update prettier script. (#16324) 2023-06-20 19:50:27 +05:30
.prettierrc.js Update prettier config for the project. (#16303) 2023-06-19 19:09:12 +05:30
.watchmanconfig Ensure shell.nix uses same nixpkgs as the rest of the environment 2019-06-20 09:18:24 -04:00
.zprintrc Fix input padding & add blur and override-theme properties 2023-03-16 12:59:34 -06:00
LICENSE.md Create LICENSE.md 2016-09-21 10:00:44 +08:00
Makefile Lint and fix missing trailing newlines (#16445) 2023-07-04 19:40:13 +00:00
README.md Document new guidelines (#14309) 2022-11-14 07:15:49 -03:00
RELEASES.md notes: updated release notes 2022-08-29 13:54:45 +02:00
VERSION Bump release to 1.23.0 (#15999) 2023-05-25 04:48:57 -07:00
app.json Lint and fix missing trailing newlines (#16445) 2023-07-04 19:40:13 +00:00
babel.config.js Update prettier config for the project. (#16303) 2023-06-19 19:09:12 +05:30
binding.gyp Add status-go tests 2022-05-25 17:59:02 +01:00
default.nix nix: minor cleanup and documentation updates 2020-06-05 14:49:34 +02:00
index.js Update prettier config for the project. (#16303) 2023-06-19 19:09:12 +05:30
metro.config.js Update prettier config for the project. (#16303) 2023-06-19 19:09:12 +05:30
package.json js: remove unused visual tests and detox package #16372 2023-06-26 11:59:15 +02:00
react-native.config.js Update prettier config for the project. (#16303) 2023-06-19 19:09:12 +05:30
shadow-cljs.edn Improve hot reloading (#16349) 2023-06-22 16:55:09 +05:30
shell.nix nix: minor cleanup and documentation updates 2020-06-05 14:49:34 +02:00
status-go-version.json [Fixes: #16203] Fix delete for me replies images 2023-06-30 11:14:49 +01:00
supervisord.conf Add docker-compose for development build 2018-04-11 14:58:38 +01:00
yarn.lock js: remove unused visual tests and detox package #16372 2023-06-26 11:59:15 +02:00

README.md

Status - a Mobile Ethereum Operating System

Get it on Google Play Get it on F-Droid Get it on Github

Join us in creating a browser, messenger, and gateway to a decentralized world. Status is a free (libre) open source mobile client targeting Android & iOS built entirely on Ethereum technologies. That's right, no middle men and go-ethereum running directly on your device.

Getting started with Status

Why?

We believe in a medium of pure free trade, economies with fair, permission-less access and a world without intermediaries. We want to create policies that can exist between friends or scale globally, we want to communicate securely and be uninhibited by legacy systems.

We want to take responsibility for our data, the way we conduct ourselves privately and promote this way of life to a mass audience.

We want deep insights into our own economies so we can make informed, data-driven decisions on how to make our lives better. The Ethereum blockchain, Smart Contracts, Swarm and Whisper provides us a path forward.

If this interests you, help us make Status a reality - anyone can contribute and we need everyone at any skill level to participate.

How to Contribute?

Go straight to the docs or join our chat and choose what interests you:

  • Developer Developers are the heart of software and to keep Status beating we need all the help we can get! If you're looking to code in ClojureScript or Golang then Status is the project for you! We use React Native and there is even some Java/Objective-C too! Want to learn more about it? Start by reading our Developer Introduction which guides you through the technology stack and start browsing beginner issues. Then you can read how to Build Status, which talks about managing project dependencies, coding guidelines and testing procedures. The doc/ directory also has valuable information for contributors.

  • Community Management Metcalfe's law states that the value of a network is proportional to the square of the number of connected users of the system - without community Status is meaningless. We're looking to create a positive, fun environment to explore new ideas, experiment and grow the Status community. Building a community takes a lot of work but the people you'll meet and long lasting relationships you form will be well worth it, check out our Mission and Community Principles

  • Specification / Documentation John Dewey once said "Education is not preparation for life; education is life itself ". Developers & Designers need guidance and it all starts from documentation and specifications. Our software is only as good as its documentation, head over to our docs and see how you can improve what we have.

  • Blog Writing Content is King, keeping our blog up to date and informing the community of news helps keep everyone on the same page. Jump into our chat and discuss with the team how you can contribute!

  • Testers It's bug hunting season! Status is currently under active development and there is sure to be a bunch of learning, build status from scratch or if an android user check out our nightly builds. You can shake your phone to submit bug reports, or start browsing our Github Issues. Every bug you find brings Status closer to stable, usable software for everyone to enjoy!

  • Security Status is a visual interface to make permanent changes on the Blockchain, it handles crypto-tokens that have real value and allows 3rd party code execution. Security is paramount to its success. You are given permission to break Status as hard as you can, as long as you share your findings with the community!

  • Evangelism Help us spread the word! Tell a friend right now, in fact tell everyone - yell from a mountain if you have to, every person counts! If you've got a great story to tell or have some interesting way you've spread the word about Status let us know about it in our chat

Status API

View our API Docs and learn how to integrate your DApp into Status. You can read more about how to add your DApp to Status here.

Give me Binaries!

You can get our Beta builds for both Android and iOS on our website, through our nightly builds or by building it yourself.

Core Contributors

Core Team Members

Special thanks to @adrian-tiberius. Without the dedication of these outstanding individuals, Status would not exist.

Contact us

Feel free to email us at support@status.im or better yet, join our chat.

License

Licensed under the Mozilla Public License v2.0

Testing Supported by

BrowserStack Status