mirror of
https://github.com/status-im/status-react.git
synced 2025-01-09 18:46:19 +00:00
60ad7c8a29
Equality checks in tests using = give a bad experience by default on test failures containing nested data structures. We use the cljs.test directive match? from matcher-combinators library to help compare nested structures. The problem with match? is that its default matcher for maps (embeds) can be too permissive, and this causes surprises. Here we upgrade matcher-combinators to latest, where a new matcher called nested-equals is available. This matcher won't allow extra keys in maps. This matcher eliminates the need for manually adding nested equals matchers as we have to do currently. - Upgrades matcher-combinators from 3.8.8 to 3.9.1 (latest as of 2024-07-19) What changes? When asserting in tests, we now have the option to use match-strict? or match?. Both directives are available by integrating with cljs.test. The code implementing the new match-strict? directive was 100% copied from the library matcher-combinators because we need to wrap the expected value ourselves with matcher-combinators.matchers/nested-equals. It's ugly code, but it's how we can integrate with cljs.test/assert-expr.
89 lines
6.1 KiB
Clojure
89 lines
6.1 KiB
Clojure
{:config-paths ["status-im"]
|
|
:output {:exclude-files ["src/user.cljs" "src/dev/user.cljs"]}
|
|
:lint-as {legacy.status-im.utils.views/defview clojure.core/defn
|
|
legacy.status-im.utils.views/letsubs clojure.core/let
|
|
reagent.core/with-let clojure.core/let
|
|
legacy.status-im.utils.fx/defn clj-kondo.lint-as/def-catch-all
|
|
utils.re-frame/defn clj-kondo.lint-as/def-catch-all
|
|
quo.react/with-deps-check clojure.core/fn
|
|
quo.previews.preview/list-comp clojure.core/for
|
|
legacy.status-im.utils.styles/def clojure.core/def
|
|
legacy.status-im.utils.styles/defn clojure.core/defn
|
|
test-helpers.unit/deftest-sub clojure.core/defn
|
|
test-helpers.unit/deftest-event clojure.core/defn
|
|
|
|
taoensso.tufte/defnp clojure.core/defn}
|
|
:linters {:case-duplicate-test {:level :error}
|
|
:case-quoted-test {:level :error}
|
|
:case-symbol-test {:level :error}
|
|
:clj-kondo-config {:level :error}
|
|
:cond-else {:level :error}
|
|
:condition-always-true {:level :error}
|
|
:conflicting-alias {:level :error}
|
|
:consistent-alias {:level :error
|
|
:aliases {clojure.set set
|
|
clojure.string string
|
|
clojure.walk walk
|
|
malli.core malli
|
|
malli.dev.pretty malli.pretty
|
|
malli.dev.virhe malli.virhe
|
|
malli.error malli.error
|
|
malli.generator malli.generator
|
|
malli.transform malli.transform
|
|
malli.util malli.util
|
|
promesa.core promesa
|
|
schema.core schema
|
|
status-im.feature-flags ff
|
|
taoensso.timbre log}}
|
|
:deprecated-namespace {:level :warning}
|
|
:docstring-blank {:level :error}
|
|
:equals-true {:level :error}
|
|
:inline-def {:level :error}
|
|
:invalid-arity {:skip-args [legacy.status-im.utils.fx/defn
|
|
utils.re-frame/defn]}
|
|
:loop-without-recur {:level :error}
|
|
:minus-one {:level :error}
|
|
:misplaced-docstring {:level :error}
|
|
:missing-body-in-when {:level :error}
|
|
:missing-clause-in-try {:level :error}
|
|
:missing-else-branch {:level :error}
|
|
:multiple-async-in-deftest {:level :error}
|
|
:not-empty? {:level :error}
|
|
:plus-one {:level :error}
|
|
:redundant-do {:level :error}
|
|
:redundant-let {:level :error}
|
|
:refer-all {:level :error}
|
|
:shadowed-fn-param {:level :error}
|
|
:shadowed-var {:level :error
|
|
;; We temporarily use :include to define an
|
|
;; allowlist of core Clojure vars. In the
|
|
;; future, as we progressively fix shadowed
|
|
;; vars, we should be able to delete this
|
|
;; option and lint all vars.
|
|
:exclude [type name]}
|
|
:self-requiring-namespace {:level :error}
|
|
:single-operand-comparison {:level :error}
|
|
:syntax {:level :error}
|
|
:unbound-destructuring-default {:level :error}
|
|
:underscore-in-namespace {:level :error}
|
|
:uninitialized-var {:level :error}
|
|
:unknown-require-option {:level :error}
|
|
:unreachable-code {:level :error}
|
|
:unresolved-namespace {:level :error}
|
|
;; TODO remove number when this is fixed
|
|
;; https://github.com/borkdude/clj-kondo/issues/867
|
|
:unresolved-symbol {:exclude [PersistentPriorityMap.EMPTY
|
|
number
|
|
legacy.status-im.test-helpers/restore-app-db
|
|
(cljs.test/is [match-strict?])]}
|
|
:unresolved-var {:level :error}
|
|
:unsorted-required-namespaces {:level :error}
|
|
:unused-alias {:level :warning}
|
|
:unused-binding {:level :error}
|
|
:unused-import {:level :error}
|
|
:unused-namespace {:level :error}
|
|
:unused-private-var {:level :error}
|
|
:unused-referred-var {:level :error}
|
|
:use {:level :error}}
|
|
:config-in-ns {mocks.js-dependencies {:linters {:clojure-lsp/unused-public-var {:level :off}}}}}
|