1806cb792a
Adds support for swiping left/right on some types of notifications. Swiping left (from left to right) shows a blue button allowing the user to mark the notification as read/unread. Swiping right (from right to left) shows a red button, allowing the user to delete the notification for good. Related PR in status-go https://github.com/status-im/status-go/pull/3201. Fixes https://github.com/status-im/status-mobile/issues/14901 Fixes https://github.com/status-im/status-mobile/issues/14900 Technical notes =============== How's the performance? It feels near native performance in a production release in a mid-range smartphone. So I'd say it's pretty good, but let me know if you find any issue. - I refrained from trying to eliminate all code duplication in this PR. Some notifications will behave differently, especially the ones with call to action, so I ask you to please take that in consideration when reviewing. See https://github.com/status-im/status-mobile/issues/15118 - React Native Gesture Handler has a component named [Swipeable](https://docs.swmansion.com/react-native-gesture-handler/docs/api/components/swipeable/). I used it instead of writing a monstrosity 👹 of code in Reanimated to achieve the same results. - RN Gesture Handler touchables are the only ones that work with the Swipeable component, so I used them and added vars to `react-native.gesture`. - I had to manually interpolate the translation X of the buttons behind notifications because notifications are transparent. To make interpolation work with `Swipeable` it's mandatory to use RN `Animated.View` and not `Reanimated.View` (see next point). - `Swipeable` expects us to pass functions that will receive RN `AnimatedInterpolation` instances and the rendering lifecycle does not work as usual. Hooks didn't trigger as expected, functional Reagent components didn't behave as expected, etc. This means `Reanimated.View` and its interpolation function is out of question. I did try for almost two days, nothing works. Testing notes ============= These are some of the manual tests I ran. There are more scenarios to cover obviously. Assuming no unread notifications before each flow: Contact request notification ============================ From the perspective of an user A: 1. Receive a contact request from a non-mutual contact B. 2. Verify the unread count is displayed over the bell icon. 3. Verify the unread count is displayed on the `Messages > Contacts` tab, as well as on the AC `Contact requests` tab. 4. Open the AC and before accepting/declining the contact request, check that you CAN'T swipe left or right. 5. Accept or decline the contact request. 6. Check the unread indicator disappears in all necessary places. 7. Press on the notification and see if you're redirected to the chat. 8. Go back to the AC and swipe left to mark as `Unread`. Notice that opening the chat marks the notification as `Read`. Also very important, notice that the `Messages > Contacts` tab will NOT show the *pending contact requests* section at the top. This is on purpose, given the notification is unread, but the user has already accepted/declined the contact request, hence it's not pending. 9. Swipe left againg to mark as `Read`. Check all unread indicators are updated. 10. Swipe right to delete the notification (it won't be displayed ever again). Admin notification ================== 1. Generate an admin notification, e.g. a community owner receiving a request notification to join. 2. Verify the unread count is displayed over the bell icon, as well as the AC Admin tab. 3. Verify the community unread indicator is correctly displayed. 4. As an admin, open the AC and before accepting/declining the request, check that you CAN'T swipe left or right. 5. Accept or decline the membership request. 6. Check the unread indicator disappears accordingly. 7. Swipe left to mark as `Read`. 8. Swipe left to mark as `Unread`. 9. Swipe right to delete the notification (it won't be displayed ever again). Mentions & replies ================== Similar steps outlined for `Admin` notifications, but there's one important difference. Mention and reply notifications don't require a call to action from the user, so the user can swipe left/right **without** first having to do anything on the notification (such as pressing on it). See issue https://github.com/status-im/status-mobile/issues/15118 What about other types of notifications? ======================================== Swipe gestures for other notification types will be implemented in a separate PR. |
||
|---|---|---|
| .clj-kondo | ||
| .dependabot | ||
| .github | ||
| android | ||
| ci | ||
| doc | ||
| fastlane | ||
| ios | ||
| modules/react-native-status | ||
| nix | ||
| resources | ||
| scripts | ||
| src | ||
| test | ||
| test-resources | ||
| translations | ||
| visual-test | ||
| .buckconfig | ||
| .carve_ignore | ||
| .detoxrc.js | ||
| .dockerignore | ||
| .env | ||
| .env.e2e | ||
| .env.jenkins | ||
| .env.nightly | ||
| .env.release | ||
| .envrc | ||
| .eslintrc.js | ||
| .flowconfig | ||
| .gitattributes | ||
| .gitignore | ||
| .mailmap | ||
| .nycrc | ||
| .prettierrc.js | ||
| .watchmanconfig | ||
| .zprintrc | ||
| LICENSE.md | ||
| Makefile | ||
| README.md | ||
| RELEASES.md | ||
| VERSION | ||
| app.json | ||
| babel.config.js | ||
| binding.gyp | ||
| default.nix | ||
| index.js | ||
| metro.config.js | ||
| package.json | ||
| react-native.config.js | ||
| shadow-cljs.edn | ||
| shell.nix | ||
| status-go-version.json | ||
| supervisord.conf | ||
| yarn.lock | ||
README.md
Status - a Mobile Ethereum Operating System
Join us in creating a browser, messenger, and gateway to a decentralized world. Status is a free (libre) open source mobile client targeting Android & iOS built entirely on Ethereum technologies. That's right, no middle men and go-ethereum running directly on your device.
Why?
We believe in a medium of pure free trade, economies with fair, permission-less access and a world without intermediaries. We want to create policies that can exist between friends or scale globally, we want to communicate securely and be uninhibited by legacy systems.
We want to take responsibility for our data, the way we conduct ourselves privately and promote this way of life to a mass audience.
We want deep insights into our own economies so we can make informed, data-driven decisions on how to make our lives better. The Ethereum blockchain, Smart Contracts, Swarm and Whisper provides us a path forward.
If this interests you, help us make Status a reality - anyone can contribute and we need everyone at any skill level to participate.
How to Contribute?
Go straight to the docs or join our chat and choose what interests you:
-
Developer Developers are the heart of software and to keep Status beating we need all the help we can get! If you're looking to code in ClojureScript or Golang then Status is the project for you! We use React Native and there is even some Java/Objective-C too! Want to learn more about it? Start by reading our Developer Introduction which guides you through the technology stack and start browsing beginner issues. Then you can read how to Build Status, which talks about managing project dependencies, coding guidelines and testing procedures. The doc/ directory also has valuable information for contributors.
-
Community Management Metcalfe's law states that the value of a network is proportional to the square of the number of connected users of the system - without community Status is meaningless. We're looking to create a positive, fun environment to explore new ideas, experiment and grow the Status community. Building a community takes a lot of work but the people you'll meet and long lasting relationships you form will be well worth it, check out our Mission and Community Principles
-
Specification / Documentation John Dewey once said "Education is not preparation for life; education is life itself ". Developers & Designers need guidance and it all starts from documentation and specifications. Our software is only as good as its documentation, head over to our docs and see how you can improve what we have.
-
Blog Writing Content is King, keeping our blog up to date and informing the community of news helps keep everyone on the same page. Jump into our chat and discuss with the team how you can contribute!
-
Testers It's bug hunting season! Status is currently under active development and there is sure to be a bunch of learning, build status from scratch or if an android user check out our nightly builds. You can shake your phone to submit bug reports, or start browsing our Github Issues. Every bug you find brings Status closer to stable, usable software for everyone to enjoy!
-
Security Status is a visual interface to make permanent changes on the Blockchain, it handles crypto-tokens that have real value and allows 3rd party code execution. Security is paramount to its success. You are given permission to break Status as hard as you can, as long as you share your findings with the community!
-
Evangelism Help us spread the word! Tell a friend right now, in fact tell everyone - yell from a mountain if you have to, every person counts! If you've got a great story to tell or have some interesting way you've spread the word about Status let us know about it in our chat
Status API
View our API Docs and learn how to integrate your DApp into Status. You can read more about how to add your DApp to Status here.
Give me Binaries!
You can get our Beta builds for both Android and iOS on our website, through our nightly builds or by building it yourself.
Core Contributors
Special thanks to @adrian-tiberius. Without the dedication of these outstanding individuals, Status would not exist.
Contact us
Feel free to email us at support@status.im or better yet, join our chat.
License
Licensed under the Mozilla Public License v2.0
Testing Supported by
