From d2d8e435358f22a5915a8836dfd0a70ce9287390 Mon Sep 17 00:00:00 2001
From: Igor Mandrigin <i@mandrigin.ru>
Date: Tue, 4 Sep 2018 08:31:28 +0200
Subject: [PATCH] Ignore Desktop builds for release.
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Currently, we don't release desktop betas and it isn't given that the
release schedule will be synchronized. So, for simplicity of support,
let's not build desktop against release branches.

Signed-off-by: Jakub Sokołowski <jakub@status.im>
---
 ci/Jenkinsfile.combined | 43 +++++++++++++++++++++++++++++------------
 ci/common.groovy        | 13 ++++++++-----
 2 files changed, 39 insertions(+), 17 deletions(-)

diff --git a/ci/Jenkinsfile.combined b/ci/Jenkinsfile.combined
index bf9704eee5..eeac3453b6 100644
--- a/ci/Jenkinsfile.combined
+++ b/ci/Jenkinsfile.combined
@@ -24,10 +24,14 @@ pipeline {
     }
     stage('Build') {
       parallel {
-        stage('MacOS') { steps { script {
+        stage('MacOS') {
+        when { expression { cmn.getBuildType() != 'release' } }
+        steps { script {
           osx = cmn.buildBranch('status-react/combined/desktop-macos', cmn.getBuildType())
         } } }
-        stage('Linux') { steps { script {
+        stage('Linux') {
+        when { expression { cmn.getBuildType() != 'release' } }
+        steps { script {
           nix = cmn.buildBranch('status-react/combined/desktop-linux', cmn.getBuildType())
         } } }
         stage('iOS') { steps { script {
@@ -44,8 +48,11 @@ pipeline {
     stage('Archive') {
       steps { script {
         sh('rm -f pkg/*')
-        cmn.copyArts('status-react/combined/desktop-macos', osx.number)
-        cmn.copyArts('status-react/combined/desktop-linux', nix.number)
+
+        if (cmn.getBuildType() != 'release') {
+          cmn.copyArts('status-react/combined/desktop-macos', osx.number)
+          cmn.copyArts('status-react/combined/desktop-linux', nix.number)
+        }
         cmn.copyArts('status-react/combined/mobile-android', dro.number)
         cmn.copyArts('status-react/combined/mobile-android', e2e.number)
         archiveArtifacts('pkg/*')
@@ -55,14 +62,22 @@ pipeline {
       steps { script {
         e2eUrl = cmn.uploadArtifact(findFiles(glob: 'pkg/*e2e.apk')[0].path)
         apkUrl = cmn.uploadArtifact(findFiles(glob: "pkg/*${cmn.getBuildType()}.apk")[0].path)
-        dmgUrl = cmn.uploadArtifact(findFiles(glob: 'pkg/*.dmg')[0].path)
-        appUrl = cmn.uploadArtifact(findFiles(glob: 'pkg/*.AppImage')[0].path)
+
+        if (cmn.getBuildType() != 'release') {
+          dmgUrl = cmn.uploadArtifact(findFiles(glob: 'pkg/*.dmg')[0].path)
+          appUrl = cmn.uploadArtifact(findFiles(glob: 'pkg/*.AppImage')[0].path)
+        } else {
+          dmgUrl = null
+          appUrl = null
+        }
         /* special case for iOS Diawi links */
         ipaUrl = ios.getBuildVariables().get('DIAWI_URL')
       } }
     }
     stage('Notify') {
       steps { script {
+        def dmgLink = "<${dmgUrl}|MacOS>"
+        def appLink = "<${appUrl}|AppImage>"
         def message = (
           (env.CHANGE_ID != null ?
             "Build PR #${BRANCH_NAME}(${CHANGE_BRANCH}) success! " :
@@ -70,13 +85,17 @@ pipeline {
           )+
           "<${currentBuild.absoluteUrl}|${currentBuild.displayName}> "+
           "(${currentBuild.durationString})\n"+
-          "Packages: "+
-          "<${apkUrl}|Android>, "+
-          "(<${e2eUrl}|e2e>), "+
-          "<${ipaUrl}|iOS>, "+
-          "<${dmgUrl}|MacOS>, "+
-          "<${appUrl}|AppImage>"
+          "Packages: <${apkUrl}|Android>, (<${e2eUrl}|e2e>), <${ipaUrl}|iOS>"
         )
+
+        if (dmgUrl != null) {
+          message = message + ", <${dmgUrl}|MacOS>"
+        }
+
+        if (appUrl != null) {
+          message = message + ", <${appUrl}|AppImage>"
+        }
+
         slackSend(
           message: message,
           color: 'good'
diff --git a/ci/common.groovy b/ci/common.groovy
index ffffd5d273..656d1a6867 100644
--- a/ci/common.groovy
+++ b/ci/common.groovy
@@ -134,11 +134,14 @@ def githubNotify(apkUrl, e2eUrl, ipaUrl, dmgUrl, appUrl, changeId) {
       "Jenkins job: [${currentBuild.displayName}](${currentBuild.absoluteUrl})\\n"+
       "##### Mobile\\n" +
       "* [Android](${apkUrl}), ([e2e](${e2eUrl}))\\n" +
-      "* [iOS](${ipaUrl})\\n" +
-      "##### Desktop\\n" +
-      "* [MacOS](${dmgUrl})\\n" +
-      "* [AppImage](${appUrl})"
-    )
+      "* [iOS](${ipaUrl})\\n")
+
+    if (dmgUrl != null && appUrl != null) {
+      message = message +
+        "##### Desktop\\n" +
+        "* [MacOS](${dmgUrl})\\n" +
+        "* [AppImage](${appUrl})"
+    }
     def script = (
       "curl "+ 
       "-u status-im:${githubToken} " +