status-im
/
status-react
mirror of https://github.com/status-im/status-react.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

Mark utils.re-frame/defn as deprecated (#17788) 

Also suggest to use utils.re-frame/reg-event-fx instead of utils.re-frame/defn
This commit is contained in:
Dmitri Akatov 2023-11-06 22:09:40 +00:00 committed by GitHub
parent 4ac7f0bdda
commit b47c97a4fd
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
doc/new-guidelines.md
View File

@ -467,9 +467,9 @@ Prefer the pure version of `:json-rpc/call` (no callbacks).
### Registering event handlers ### Registering event handlers
Register events with `re-frame.core/reg-event-fx` and follow [re-frame's best Register events with `utils.re-frame/reg-event-fx` and follow [re-frame's best
practice](https://github.com/day8/re-frame/blob/39adca93673f334dc751ee2d99d340b51a9cc6db/docs/FAQs/BestPractice.md#use-the-fx-effect) practice](https://github.com/day8/re-frame/blob/39adca93673f334dc751ee2d99d340b51a9cc6db/docs/FAQs/BestPractice.md#use-the-fx-effect)
so use only `:db` and `:fx` effects. `rf/merge` is deprecated and should not be so use only `:db` and `:fx` effects. `utils.re-frame/merge` and `utils.re-frame/defn` are deprecated and should not be
used in the new code in `src/status_im2/`. Don't use used in the new code in `src/status_im2/`. Don't use
`re-frame.core/reg-event-db`. `re-frame.core/reg-event-db`.

4
src/utils/re_frame.clj
View File

@ -28,7 +28,9 @@
event keywords under which the function will be registered event keywords under which the function will be registered
- TODO: add suport for `prepost-map?` (don't forget to add it to arglist) - TODO: add suport for `prepost-map?` (don't forget to add it to arglist)
- TODO: add validation of macro parameters" - TODO: add validation of macro parameters"
{:arglists '([name doc-string? attr-map? [params*] body])} {:arglists '([name doc-string? attr-map? [params*] body])
:deprecated true
:superseded-by "utils.re-frame/reg-event-fx"}
[name & fdecl] [name & fdecl]
(let [m (if (string? (first fdecl)) (let [m (if (string? (first fdecl))
{:doc (first fdecl)} {:doc (first fdecl)}