status-im
/
status-react
mirror of https://github.com/status-im/status-react.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

typos in REVIEW.md 

Signed-off-by: yenda <eric@status.im>
This commit is contained in:
yenda 2019-09-20 14:14:09 +02:00
parent 97e9f0daa1
commit a1735e4577
No known key found for this signature in database
GPG Key ID: 0095623C0069DCE6
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
REVIEW.md
View File

@ -5,11 +5,11 @@ This document MUST be updated everytime a PR has been identified has the source
## Cause ## Cause
There was errors in the iOS native code: There were errors in the iOS native code:
- "loginWithKeycard" method was not implemented - "loginWithKeycard" method was not implemented
- "createAndLoginWithKeycard" method was actually used instead of "createAndLogin** which is used for regular account creation without keycard and doesn't have the same final argument - "createAndLoginWithKeycard" method was actually used instead of "createAndLogin** which is used for regular account creation without keycard and doesn't have the same final argument
QA process was focused on account creation and login with keycard, and this bug would only appear specifically on iOS when creating an account without keycard and only during the next login. It was therefore a more complex path to reach that what could have been expected from this PR, and it was caused in develop by a developer working on iOS simulator because that is a common path during development. QA process was focused on account creation and login with keycard, and this bug would only appear specifically on iOS when creating an account without keycard and only during the next login. It was therefore a more complex path to reach than what could have been expected from this PR, and it was caused in develop by a developer working on iOS simulator because that is a common path during development.
## Resolution process ## Resolution process
@ -19,7 +19,7 @@ QA process was focused on account creation and login with keycard, and this bug
## Prevention measures ## Prevention measures
- PRs that change native code should be checked for plateform parity: - PRs that change native code should be checked for platform parity:
- same methods are created/modified for each platform - same methods are created/modified for each platform
- test cases in the PR should take these methods in consideration - test cases in the PR should take these methods in consideration