add cleanup steps and reduce number of builds to keep

skip github notification if no CHANGE_ID is available

Signed-off-by: Jakub Sokołowski <jakub@status.im>

ci/Jenkinsfile.android

@@ -8,9 +8,9 @@ pipeline {
     timeout(time: 35, unit: 'MINUTES')
     /* Limit builds retained */
     buildDiscarder(logRotator(
-      numToKeepStr: '90',
+      numToKeepStr: '10',
-      daysToKeepStr: '30',
+      daysToKeepStr: '20',
-      artifactNumToKeepStr: '90',
+      artifactNumToKeepStr: '10',
     ))
   }
 
@@ -97,6 +97,11 @@ pipeline {
         script { cmn.gitHubNotifyPRSuccess() }
       }
     }
+    stage('Cleanup') {
+      steps {
+        script { cmn.clean() }
+      }
+    }
   }
   post {
     failure { script { load('ci/common.groovy').gitHubNotifyPRFail() } }

ci/Jenkinsfile.ios

@@ -16,9 +16,9 @@ pipeline {
     timeout(time: 35, unit: 'MINUTES')
     /* Limit builds retained */
     buildDiscarder(logRotator(
-      numToKeepStr: '90',
+      numToKeepStr: '10',
-      daysToKeepStr: '60',
+      daysToKeepStr: '20',
-      artifactNumToKeepStr: '60',
+      artifactNumToKeepStr: '10',
     ))
   }
 
@@ -90,6 +90,11 @@ pipeline {
         script { cmn.gitHubNotifyPRSuccess() }
       }
     }
+    stage('Cleanup') {
+      steps {
+        script { cmn.clean() }
+      }
+    }
   }
   post {
     failure { script { load('ci/common.groovy').gitHubNotifyPRFail() } }

ci/Jenkinsfile.linux

@@ -29,9 +29,9 @@ pipeline {
     timeout(time: 35, unit: 'MINUTES')
     /* Limit builds retained */
     buildDiscarder(logRotator(
-      numToKeepStr: '60',
+      numToKeepStr: '10',
-      daysToKeepStr: '30',
+      daysToKeepStr: '20',
-      artifactNumToKeepStr: '60',
+      artifactNumToKeepStr: '10',
     ))
   }
 
@@ -103,6 +103,11 @@ pipeline {
         script { cmn.gitHubNotifyPRSuccess() }
       }
     }
+    stage('Cleanup') {
+      steps {
+        script { cmn.clean() }
+      }
+    }
   }
   post {
     failure { script { load('ci/common.groovy').gitHubNotifyPRFail() } }

ci/Jenkinsfile.macos

@@ -16,9 +16,9 @@ pipeline {
     timeout(time: 25, unit: 'MINUTES')
     /* Limit builds retained */
     buildDiscarder(logRotator(
-      numToKeepStr: '60',
+      numToKeepStr: '10',
-      daysToKeepStr: '30',
+      daysToKeepStr: '20',
-      artifactNumToKeepStr: '60',
+      artifactNumToKeepStr: '10',
     ))
   }
 
@@ -84,6 +84,11 @@ pipeline {
         script { cmn.gitHubNotifyPRSuccess() }
       }
     }
+    stage('Cleanup') {
+      steps {
+        script { cmn.clean() }
+      }
+    }
   }
   post {
     failure { script { load('ci/common.groovy').gitHubNotifyPRFail() } }

ci/Jenkinsfile.windows

@@ -29,9 +29,9 @@ pipeline {
     timeout(time: 45, unit: 'MINUTES')
     /* Limit builds retained */
     buildDiscarder(logRotator(
-      numToKeepStr: '60',
+      numToKeepStr: '10',
-      daysToKeepStr: '30',
+      daysToKeepStr: '20',
-      artifactNumToKeepStr: '60',
+      artifactNumToKeepStr: '10',
     ))
   }
 
@@ -106,6 +106,11 @@ pipeline {
         script { cmn.gitHubNotifyPRSuccess() }
       }
     }
+    stage('Cleanup') {
+      steps {
+        script { cmn.clean() }
+      }
+    }
   }
   post {
     failure { script { load('ci/common.groovy').gitHubNotifyPRFail() } }

ci/common.groovy

@@ -149,8 +149,16 @@ def buildDuration() {
 
 def gitHubNotify(message) {
   def githubIssuesUrl = 'https://api.github.com/repos/status-im/status-react/issues'
-  /* CHANGE_ID can be provided via the build parameters */
+  /* CHANGE_ID can be provided via the build parameters or from parent */
-  def changeId = params.CHANGE_ID ? params.CHANGE_ID : env.CHANGE_ID
+  def changeId = env.CHANGE_ID
+  changeId = params.CHANGE_ID ? params.CHANGE_ID : changeId
+  changeId = getParentRunEnv('CHANGE_ID') ? getParentRunEnv('CHANGE_ID') : changeId
+  /* CHANGE_ID exists only when run as a PR build */
+  if (!changeId) {
+    println('This build is not related to a PR, CHANGE_ID missing.')
+    println('GitHub notification impossible, skipping...')
+    return
+  }
   def msgObj = [body: message]
   def msgJson = new JsonBuilder(msgObj).toPrettyString()
   withCredentials([usernamePassword(
@@ -264,4 +272,8 @@ def runTests() {
   sh 'lein test-cljs'
 }
 
+def clean() {
+  sh 'make clean'
+}
+
 return this

ci/desktop.groovy

@@ -2,12 +2,8 @@ cmn = load 'ci/common.groovy'
 
 packageFolder = './StatusImPackage'
 
-def cleanupBuild() {
-  sh 'make clean'
-}
-
 def cleanupAndDeps() {
-  cleanupBuild()
+  cmn.clean()
   sh 'cp .env.jenkins .env'
   sh 'lein deps'
   cmn.installJSDeps('desktop')

ci/mobile.groovy

@@ -36,7 +36,7 @@ def podUpdate() {
 def prep(type = 'nightly') {
   cmn.doGitRebase()
   /* ensure that we start from a known state */
-  sh 'make clean'
+  cmn.clean()
   /* select type of build */
   switch (type) {
     case 'nightly':