From 9eaee8864c66b994fac95ac202fa455c85939598 Mon Sep 17 00:00:00 2001 From: Andrea Maria Piana Date: Fri, 11 Aug 2023 15:05:14 +0100 Subject: [PATCH] Update status-go docs --- doc/merging-pr-process.md | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/doc/merging-pr-process.md b/doc/merging-pr-process.md index 4bd89e4843..e86174b951 100644 --- a/doc/merging-pr-process.md +++ b/doc/merging-pr-process.md @@ -40,7 +40,9 @@ In practice, this means that sometimes they need to be merged in lockstep. git push origin vx.y.z ``` 5) Update status-mobile with the new status-go version, using the new tag `scripts/update-status-go.sh "vx.y.z"` -6) In status-mobile, push, rebase against `develop` and merge it 🚀 +6) If you had to rebase status-go to include new changes, e2e test MUST be re-run. If there's any issue you will + have to fix in status-go with another PR and follow the same process. +7) In status-mobile, push, rebase against `develop` and merge it 🚀 important note : make sure your status-go PRs get a tested-ok by QA before merging them in.