status-im
/
status-react
mirror of https://github.com/status-im/status-react.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

fix store nodes not being found on iOS (#19798) 

90b18d4f...b124e2b4

fixes #19736

Corresponding go PR https://github.com/status-im/status-go/pull/5093

This commit fixes DNS resolution inside status-go by forcing pure go resolver at build time.
Reference -> https://pkg.go.dev/net#hdr-Name_Resolution

Store nodes must be available on Android & iOS app.

- Android
- iOS

status: ready
This commit is contained in:
Siddarth Kumar 2024-04-26 14:34:04 +02:00 committed by GitHub
parent cd54aa9b92
commit 8fc6f4776b
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 15 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
nix/status-go/library/default.nix
View File

@ -11,6 +11,12 @@ buildGoPackage {
phases = ["unpackPhase" "configurePhase" "buildPhase"]; phases = ["unpackPhase" "configurePhase" "buildPhase"];
# https://pkg.go.dev/net#hdr-Name_Resolution
# https://github.com/status-im/status-mobile/issues/19736
# https://github.com/status-im/status-mobile/issues/19581
# TODO: try removing when go is upgraded to 1.22
GODEBUG = "netdns=cgo+2";
preBuild = '' preBuild = ''
pushd go/src/$goPackagePath pushd go/src/$goPackagePath
go run cmd/library/*.go > $NIX_BUILD_TOP/main.go go run cmd/library/*.go > $NIX_BUILD_TOP/main.go

7
nix/status-go/mobile/build.nix
View File

@ -38,10 +38,15 @@ in buildGoPackage {
# Ensure XCode is present for iOS, instead of failing at the end of the build. # Ensure XCode is present for iOS, instead of failing at the end of the build.
preConfigure = optionalString isIOS enforceXCodeAvailable; preConfigure = optionalString isIOS enforceXCodeAvailable;
# https://pkg.go.dev/net#hdr-Name_Resolution
# https://github.com/status-im/status-mobile/issues/19736
# https://github.com/status-im/status-mobile/issues/19581
# TODO: try removing when go is upgraded to 1.22
GODEBUG = "netdns=cgo+2";
buildPhase = '' buildPhase = ''
runHook preBuild runHook preBuild
echo -e "\nBuilding $pname for: ${concatStringsSep "," targets}" echo -e "\nBuilding $pname for: ${concatStringsSep "," targets}"
gomobile bind \ gomobile bind \
${concatStringsSep " " goBuildFlags} \ ${concatStringsSep " " goBuildFlags} \
-ldflags="$ldflags" \ -ldflags="$ldflags" \

6
status-go-version.json
View File

@ -3,7 +3,7 @@
"_comment": "Instead use: scripts/update-status-go.sh <rev>", "_comment": "Instead use: scripts/update-status-go.sh <rev>",
"owner": "status-im", "owner": "status-im",
"repo": "status-go", "repo": "status-go",
"version": "v0.179.10", "version": "v0.179.11",
"commit-sha1": "90b18d4f8801b09f68bb5b794a5b6af92001d26e", "commit-sha1": "b124e2b4f27a2aa41ffebb1ccf385475c5e87781",
"src-sha256": "0dlrnpr7wj9z2ywm90avgdzdr9wg71dy82v5jjc9wmiz537mn7wy" "src-sha256": "142988smak33gmz0zd21ifkn2kajh9di858hrfffbk0xsxbv59rm"
} }