status-im/status-react
2
0
Fork 0
mirror of https://github.com/status-im/status-react.git synced 2025-01-28 03:36:23 +00:00
Code Issues Projects Releases Wiki Activity

Simplified pull request template (#21900)

Browse Source
This commit is contained in:
Volodymyr Kozieiev 2025-01-09 13:48:10 +00:00 committed by GitHub
parent 874aa9866d
commit 770963447a
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 16 additions and 34 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

50
.github/PULL_REQUEST_TEMPLATE.md vendored
View File

@ -1,39 +1,26 @@
[comment]: # (Please replace ... with your information. Remove < and >)
[comment]: # (To auto-close issue on merge, please insert the related issue number after # i.e fixes #566) [comment]: # (To auto-close issue on merge, please insert the related issue number after # i.e fixes #566)
If you submit PR for issue with bounty then write here Fixes #NN where NN is issue number
*otherwise*
fixes #... fixes #...
### Summary ## Summary
[comment]: # (Summarise the problem and how the pull request solves it) [comment]: # (Summarise the problem and how the pull request solves it)
... ...
<!-- (Optional, remove if no changes to documentation) --> ## Review notes
Documentation change PR (review please): https://github.com/status-im/status.im/pull/xxx [comment]: # (Optional. Specify if something in particular should be looked at, or ignored, during review)
### Review notes ## Testing notes
<!-- (Optional. Specify if something in particular should be looked at, or ignored, during review) --> [comment]: # (Optional)
### Testing notes ### Platforms
<!-- (Optional) --> [comment]: # (Optional. Specify which platforms should be tested)
#### Platforms
<!-- (Optional. Specify which platforms should be tested) -->
- Android - Android
- iOS - iOS
- macOS
- Linux
- Windows
#### Areas that maybe impacted ### Areas that may be impacted
<!-- (Optional. Specify if some specific areas has to be tested, for example 1-1 chats) --> [comment]: # (Optional. Specify if some specific areas need to be tested, such as 1-1 chats)
##### Functional #### Functional
- 1-1 chats - 1-1 chats
- public chats - public chats
@ -48,32 +35,27 @@ Documentation change PR (review please): https://github.com/status-im/status.im/
- fleet - fleet
- bootnodes - bootnodes
##### Non-functional #### Non-functional
- battery performance - battery performance
- CPU performance / speed of the app - CPU performance / speed of the app
- network consumption - network consumption
### Steps to test ## Steps to test
<!-- (Specify exact steps to test if there are such) --> [comment]: # (Specify exact steps to test if there are such)
- Open Status - Open Status
- ... - ...
- Step 3, etc. - Step 3, etc.
<!-- (PRs will only be accepted if squashed into single commit.) -->
### Before and after screenshots comparison [comment]: # (Can be ready or wip)
status: ready
| Figma (if available) | iOS (if available) | Android (if available)
| --- | --- | --- |
| Please embed Image/Video here of the before and after. | Please embed Image/Video here of the before and after. | Please embed Image/Video here of the before and after. |
status: ready <!-- Can be ready or wip -->
<!-- Uncomment this section for status-go upgrade/dogfooding pull requests <!-- Uncomment this section for status-go upgrade/dogfooding pull requests
- Specify potentially impacted user flows in _Areas that maybe impacted*. - Specify potentially impacted user flows in _Areas that may be impacted*.
- Ensure that _Steps to test_ is filled in. - Ensure that _Steps to test_ is filled in.
### Risk ### Risk