merge-pr script should prompt for multiple commits
Fixes #2971 Because I don't think it is worth a bounty - all the code required was already in the `merge-external-pr.sh` so I have just copied the relevant parts across and added the few necessary lines to ensure that PRs from core contributors cannot be merged unless they have been squashed down to a single commit. Changed fatal to confirm for merge-pr
This commit is contained in:
parent
e35edf1e90
commit
5f979cdf8c
|
@ -8,6 +8,13 @@ if [[ $# -eq 0 ]] ; then
|
|||
exit 0
|
||||
fi
|
||||
|
||||
confirm() {
|
||||
read -p "$1 (type 'yes' to continue) " r
|
||||
if [[ $r != yes ]]; then
|
||||
exit 3
|
||||
fi
|
||||
}
|
||||
|
||||
echo "[Merge PR from ${BRANCH}]"
|
||||
|
||||
echo "[Update remote and checkout branch]"
|
||||
|
@ -16,6 +23,9 @@ git checkout -B $BRANCH origin/$BRANCH && git pull
|
|||
|
||||
echo "[Rebase and squash to one commit (manual)]"
|
||||
git rebase -i origin/develop
|
||||
if [[ $(git rev-list $BRANCH..$PR_LOCAL_BRACNCH | wc -l) -ne 1 ]] ;then
|
||||
confirm "There are multiple commits in this PR. Are you sure you wish to continue without squashing?"
|
||||
fi
|
||||
|
||||
echo "[Verify signature and commit (manual), update PR]"
|
||||
git show --show-signature
|
||||
|
|
Loading…
Reference in New Issue