status-im
/
status-react
mirror of https://github.com/status-im/status-react.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

chore: remove identifiers screens (#20503) 

* chore: remove identifiers screens so users are navigated straight to enable notifications during onboarding

* removed navigated back button from enable notification screen

* fix top margin

* e2e: updated sign in flow

* make lint-fix

---------

Co-authored-by: Yevheniia Berdnyk <ie.berdnyk@gmail.com>
This commit is contained in:
John Ngei 2024-07-11 02:09:03 +02:00 committed by GitHub
parent f89b66f562
commit 311fde9409
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
4 changed files with 13 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/status_im/contexts/onboarding/enable_notifications/view.cljs
View File

@ -72,10 +72,7 @@
(let [insets (safe-area/get-insets)]
[rn/view {:style (style/page-container insets)}
[rn/view {:style style/page-heading}
[quo/page-nav
{:background :blur
:icon-name :i/arrow-left
:on-press #(rf/dispatch [:navigate-back])}]
[quo/page-nav {:type :no-title :background :blur}]
[page-title]]
[enable-notifications-simple]
[enable-notification-buttons {:insets insets}]]))

2
src/status_im/contexts/onboarding/events.cljs
View File

@ -73,7 +73,7 @@
:onboarding/navigated-to-enter-seed-phrase-from-screen
:screen/onboarding.new-to-status)]]
:dispatch-later [{:ms constants/onboarding-generating-keys-animation-duration-ms
:dispatch [:onboarding/navigate-to-identifiers]}]
:dispatch [:init-root :screen/onboarding.enable-notifications]}]
:db (-> db
(dissoc :profile/login)
(dissoc :auth-method)

11
src/status_im/navigation/screens.cljs
View File

@ -346,12 +346,11 @@
:component enter-seed-phrase/view}
{:name :screen/onboarding.enable-notifications
:options {:theme :dark
:layout options/onboarding-transparent-layout
:animations (merge
transitions/new-to-status-modal-animations
transitions/push-animations-for-transparent-background)
:modalPresentationStyle :overCurrentContext}
:options {:theme :dark
:layout options/onboarding-transparent-layout
:animations (merge
transitions/new-to-status-modal-animations
transitions/push-animations-for-transparent-background)}
:component enable-notifications/view}
{:name :screen/onboarding.identifiers

12
test/appium/views/sign_in_view.py
View File

@ -244,8 +244,8 @@ class SignInView(BaseView):
self.generate_keys_button.click_until_presence_of_element(self.profile_title_input)
self.set_profile(username)
self.set_password(password)
if self.enable_biometric_maybe_later_button.is_element_displayed(10):
self.enable_biometric_maybe_later_button.click()
# if self.enable_biometric_maybe_later_button.is_element_displayed(10):
# self.enable_biometric_maybe_later_button.click()
# self.next_button.click_until_absense_of_element(self.element_by_translation_id("intro-wizard-title2"))
# if keycard:
# keycard_flow = self.keycard_storage_button.click()
@ -256,7 +256,7 @@ class SignInView(BaseView):
# self.create_password_input.send_keys(password)
# self.confirm_your_password_input.send_keys(password)
# self.next_button.click()
self.identifiers_button.wait_and_click(30)
# self.identifiers_button.wait_and_click(30)
if enable_notifications:
self.enable_notifications_button.click_until_presence_of_element(self.start_button)
if self.allow_button.is_element_displayed():
@ -283,9 +283,9 @@ class SignInView(BaseView):
self.continue_button.click_until_presence_of_element(self.profile_title_input)
self.set_profile(username, set_image)
self.set_password(password)
if self.enable_biometric_maybe_later_button.is_element_displayed(10):
self.enable_biometric_maybe_later_button.click()
self.identifiers_button.wait_and_click(30)
# if self.enable_biometric_maybe_later_button.is_element_displayed(10):
# self.enable_biometric_maybe_later_button.click()
# self.identifiers_button.wait_and_click(30)
if enable_notifications:
self.enable_notifications_button.click_until_presence_of_element(self.start_button)
else: