status-im
/
status-react
mirror of https://github.com/status-im/status-react.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

[#4053] Quickfix to not log passwords from the transaction screen. 

Signed-off-by: Igor Mandrigin <i@mandrigin.ru>
This commit is contained in:
Igor Mandrigin 2018-05-21 16:16:09 +02:00
parent efdd6debb0
commit 1aae1a9645
No known key found for this signature in database
GPG Key ID: 4A0EDDE26E66BC8B
3 changed files with 10 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/status_im/utils/handlers.cljs
View File

@ -22,9 +22,12 @@
(defn- pretty-print-event [ctx] (defn- pretty-print-event [ctx]
(let [[first second] (get-coeffect ctx :event)] (let [[first second] (get-coeffect ctx :event)]
;; TODO wrap passwords in a custom type so it won't be possible to print them occasionally
(if (= first :wallet.send/set-password)
(str first " " "******") ;; special case not to expose password to the logs
(if (or (string? second) (keyword? second) (boolean? second)) (if (or (string? second) (keyword? second) (boolean? second))
(str first " " second) (str first " " second)
first))) first))))
(def debug-handlers-names (def debug-handlers-names
"Interceptor which logs debug information to js/console for each event." "Interceptor which logs debug information to js/console for each event."

4
test/appium/tests/__init__.py
View File

@ -73,7 +73,7 @@ transaction_users['D_USER']['public_key'] = "0x049191be3d0b0258732a4c3bd66d2e68c
"f51345417e42f56e16926b685f99448ac05b9608b0d42cf65ee58853f104696" "f51345417e42f56e16926b685f99448ac05b9608b0d42cf65ee58853f104696"
transaction_users['E_USER'] = dict() transaction_users['E_USER'] = dict()
transaction_users['E_USER']['password'] = "qwerty" transaction_users['E_USER']['password'] = "newuniquepassword12"
transaction_users['E_USER']['passphrase'] = "sea ill guard bounce gesture tomato walnut fitness plastic affair oven transfer" transaction_users['E_USER']['passphrase'] = "sea ill guard bounce gesture tomato walnut fitness plastic affair oven transfer"
transaction_users['E_USER']['username'] = "Chartreuse Comfortable Spadefoot" transaction_users['E_USER']['username'] = "Chartreuse Comfortable Spadefoot"
transaction_users['E_USER']['address'] = "f7cb60839c0de25e37be0391c33bb34a8f0f8414" transaction_users['E_USER']['address'] = "f7cb60839c0de25e37be0391c33bb34a8f0f8414"
@ -81,7 +81,7 @@ transaction_users['E_USER']['public_key'] = "0x04d27bda317be9b3d943db5e098b3ab1c
"09499522623dc686f5d0a3233c7f1f9724849127cedb5511945e12ca3b4d297" "09499522623dc686f5d0a3233c7f1f9724849127cedb5511945e12ca3b4d297"
transaction_users['F_USER'] = dict() transaction_users['F_USER'] = dict()
transaction_users['F_USER']['password'] = "qwerty" transaction_users['F_USER']['password'] = "newuniquepassword12"
transaction_users['F_USER']['passphrase'] = "style case lazy pole general section dawn royal slice evoke crowd boat" transaction_users['F_USER']['passphrase'] = "style case lazy pole general section dawn royal slice evoke crowd boat"
transaction_users['F_USER']['username'] = "Happygolucky Zigzag Stoat" transaction_users['F_USER']['username'] = "Happygolucky Zigzag Stoat"
transaction_users['F_USER']['address'] = "a94a2a7584620677d290549a96046e59a18f09ef" transaction_users['F_USER']['address'] = "a94a2a7584620677d290549a96046e59a18f09ef"

3
test/appium/tests/test_transaction.py
View File

@ -177,7 +177,8 @@ class TestTransaction(SingleDeviceTestCase):
send_transaction.recent_recipients_button.click_until_presence_of_element(recent_recipient) send_transaction.recent_recipients_button.click_until_presence_of_element(recent_recipient)
recent_recipient.click() recent_recipient.click()
send_transaction.sign_transaction_button.click() send_transaction.sign_transaction_button.click()
send_transaction.enter_password_input.send_keys(sender['password']) send_transaction.enter_password_input.click()
send_transaction.send_as_keyevent(sender['password'])
send_transaction.sign_transaction_button.click() send_transaction.sign_transaction_button.click()
send_transaction.got_it_button.click() send_transaction.got_it_button.click()
if sender['password'] in str(home_view.logcat): if sender['password'] in str(home_view.logcat):