2020-05-18 10:15:49 +00:00
|
|
|
# This derivation patches Node.js dependencies by
|
|
|
|
|
# taking the result of yarn2nix and symlinking what is fine,
|
|
|
|
|
# and copying and modifying what needs to be adjusted.
|
2020-05-07 10:21:39 +00:00
|
|
|
|
2020-05-18 10:15:49 +00:00
|
|
|
{ stdenv, deps, nodejs, patchMavenSources }:
|
2020-05-07 10:21:39 +00:00
|
|
|
|
|
|
|
|
stdenv.mkDerivation {
|
2020-05-18 10:15:49 +00:00
|
|
|
name = "${deps.nodejs.name}-patched";
|
2020-12-02 12:40:23 +00:00
|
|
|
phases = [
|
|
|
|
|
"unpackPhase"
|
|
|
|
|
"patchGradlePhase"
|
|
|
|
|
"patchBuildIdPhase"
|
2023-12-11 15:52:23 +00:00
|
|
|
"patchKeyChainPhase"
|
2023-12-07 10:06:08 +00:00
|
|
|
"patchGlogPhase"
|
Fix component tests, upgrade Jest & friends, and a few other goodies (#18276)
Fix all component tests after the latest RN upgrade.
Fixes https://github.com/status-im/status-mobile/issues/18157
Closes https://github.com/status-im/status-mobile/pull/18235
Dependency changes
- Upgraded Jest: from 26.6.3 to latest 29.7.0.
- Upgraded @testing-library/jest-native: from 5.3.0 to latest 5.4.3
- Upgraded @testing-library/react-native: from 11.5.4 to 12.4.2
- Removed explicit dependency on jest-circus, this is now the default test
runner.
- Removed explicit dependency on jest-environment-node. This is handled by the
package manager.
- Added jest-silent-reporter at version 0.5.0.
### Why component tests were failing?
Many tests were failing because we were using RN Testing Library (RNTL) in an
unreliable fashion. With the recent library upgrades, the unreliability was
excerbated. Other times, the tests were incorrectly arranging data.
### with-redefs does not work with async code
Generally speaking, with-redefs should not be used with async code, assume the
worst. The scope of the macro will cease to exist by the time the async code
runs. In many tests we were using with-redefs, then calling render, but for some
components that use use-effect, JS timers, animations, etc it's unreliable and
were the reason for failures.
It's easy to reproduce too:
```clojure
(defn foo []
:foo)
(foo)
;; => :foo
(with-redefs [foo (constantly :bar)]
(foo))
;; => :bar
(js/setTimeout
(fn []
(tap> [:calling-foo (foo)]))
100)
;; Taps [:calling-foo :foo]
;; As you would expect, when running without with-redefs, it prints :foo.
;; So far so good, but whatch what happens with async code:
(with-redefs [foo (constantly :bar)]
(js/setTimeout
(fn []
(tap> [:calling-foo (foo)]))
100))
;; Taps [:calling-foo :foo]
;; ====> PROBLEM: Taps :foo, not :bar as one might expect
```
### Not waiting on wait-for
When test-helpers.component/wait-for is used, subsequent assertions/etc should
be done after the promise returned by wait-for is resolved. But remember to not
perform side-effects inside the wait-for callback (check out the docs
https://callstack.github.io/react-native-testing-library/docs/api#waitfor).
Most, if not all of our usages of wait-for were not waiting.
#### Improvement 1 - Silence Jest on demand
If you need to re-run component tests frequently, you may want to reduce the
output verbosity. By passing JEST_USE_SILENT_REPORTER=true to make
component-test or make component-test-watch you will see a lot less noise and be
able to focus on what really matters to you.
#### Improvement 2 - Selectively focus/disable tests
Because of our need to first compile CLJS to JS before running tests via Jest,
we couldn't easily skip or focus on specific tests. From this commit onwards, we
should never again have to change the list of requires in files core_spec.cljs.
Commenting out required namespaces gives a bad DX because it causes constant
rebasing issues.
#### Improvement 3 - Translations now work as in prod code (but only English)
Translations performed by *-by-translation-text can be done now without any
workaround under the hood. The query functions are now linted just like
i18n/label, which means static translation keywords must be qualified with :t/,
which is good for consistency.
2023-12-26 14:58:23 +00:00
|
|
|
"installPhase"
|
2020-12-02 12:40:23 +00:00
|
|
|
];
|
2020-05-07 10:21:39 +00:00
|
|
|
|
|
|
|
|
# First symlink all modules as is
|
|
|
|
|
# WARNING: Metro has issues when dealing with symlinks!
|
|
|
|
|
unpackPhase = ''
|
|
|
|
|
mkdir -p ./node_modules/
|
2020-05-18 10:15:49 +00:00
|
|
|
for module in $(ls ${deps.nodejs}/node_modules); do
|
|
|
|
|
ln -s ${deps.nodejs}/node_modules/$module ./node_modules/
|
2020-05-07 10:21:39 +00:00
|
|
|
done
|
2020-05-18 10:15:49 +00:00
|
|
|
cp -r ${deps.nodejs}/node_modules/.bin ./node_modules/
|
2020-05-07 10:21:39 +00:00
|
|
|
'';
|
|
|
|
|
|
2020-12-02 12:40:23 +00:00
|
|
|
# Patch build.gradle files in 'react-native-*' dependencies to replace
|
|
|
|
|
# maven and google central repositories with our own local directories.
|
|
|
|
|
# This prevents the builder from downloading Maven artifacts
|
|
|
|
|
patchGradlePhase = ''
|
2023-03-03 16:15:38 +00:00
|
|
|
gradleConfigs=$(
|
|
|
|
|
find -L ./node_modules \
|
|
|
|
|
-name build.gradle -or \
|
|
|
|
|
-name build.gradle.kts -or \
|
|
|
|
|
-name settings.gradle -or \
|
|
|
|
|
-name settings.gradle.kts
|
|
|
|
|
)
|
|
|
|
|
for modBuildGradle in $gradleConfigs; do
|
2020-05-07 10:21:39 +00:00
|
|
|
relativeToNode=''${modBuildGradle#*node_modules/}
|
|
|
|
|
moduleName=''${relativeToNode%%/*}
|
|
|
|
|
if [[ -L ./node_modules/$moduleName ]]; then
|
|
|
|
|
unlink ./node_modules/$moduleName
|
2020-05-18 10:15:49 +00:00
|
|
|
cp -r ${deps.nodejs}/node_modules/$moduleName ./node_modules/
|
2020-05-15 16:36:03 +00:00
|
|
|
chmod u+w -R ./node_modules/$moduleName
|
2020-05-07 10:21:39 +00:00
|
|
|
fi
|
2020-05-19 18:15:41 +00:00
|
|
|
${patchMavenSources} $modBuildGradle
|
2020-05-07 10:21:39 +00:00
|
|
|
done
|
2020-12-02 12:40:23 +00:00
|
|
|
'';
|
2023-12-11 15:52:23 +00:00
|
|
|
|
2020-12-02 12:40:23 +00:00
|
|
|
# Do not add a BuildId to the generated libraries, for reproducibility
|
|
|
|
|
patchBuildIdPhase = ''
|
2023-12-11 15:52:23 +00:00
|
|
|
substituteInPlace ./node_modules/react-native/ReactAndroid/src/main/jni/CMakeLists.txt --replace \
|
|
|
|
|
'-Wl,--build-id' \
|
|
|
|
|
'-Wl,--build-id=none'
|
2020-12-02 12:40:23 +00:00
|
|
|
'';
|
2023-12-11 15:52:23 +00:00
|
|
|
|
2020-05-07 10:21:39 +00:00
|
|
|
installPhase = ''
|
|
|
|
|
mkdir -p $out
|
|
|
|
|
cp -R node_modules $out/
|
|
|
|
|
'';
|
|
|
|
|
|
2023-12-11 15:52:23 +00:00
|
|
|
# Remove gradle-test-logger-plugin:
|
|
|
|
|
# https://github.com/oblador/react-native-keychain/issues/595
|
|
|
|
|
# TODO: remove this patch when we this library fixes above issue
|
|
|
|
|
patchKeyChainPhase = ''
|
|
|
|
|
sed -i -e '/classpath/d' \
|
|
|
|
|
-e '/apply plugin: "com\.adarshr\.test-logger"/d' \
|
|
|
|
|
./node_modules/react-native-keychain/android/build.gradle
|
2023-04-12 09:55:19 +00:00
|
|
|
'';
|
|
|
|
|
|
2023-12-07 10:06:08 +00:00
|
|
|
# Fix pod issue after upgrading to MacOS Sonoma and Xcode 15
|
|
|
|
|
# https://github.com/status-im/status-mobile/issues/17682
|
|
|
|
|
patchGlogPhase = ''
|
|
|
|
|
substituteInPlace ./node_modules/react-native/scripts/ios-configure-glog.sh \
|
|
|
|
|
--replace 'export CC="' '#export CC="' \
|
|
|
|
|
--replace 'export CXX="' '#export CXX="'
|
|
|
|
|
'';
|
|
|
|
|
|
2020-05-07 10:21:39 +00:00
|
|
|
# The ELF types are incompatible with the host platform, so let's not even try
|
|
|
|
|
# TODO: Use Android NDK to strip binaries manually
|
|
|
|
|
dontPatchELF = true;
|
|
|
|
|
dontStripHost = true;
|
|
|
|
|
|
|
|
|
|
# Take whole sources into consideration when calculating sha
|
|
|
|
|
outputHashMode = "recursive";
|
|
|
|
|
outputHashAlgo = "sha256";
|
|
|
|
|
}
|
