status-im
/
status-react
mirror of https://github.com/status-im/status-react.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity
status-react/status-go-version.json

10 lines
338 B
JSON
Raw Normal View History

nix: Use status-go commit sha1 in Nix expression to allow for moving branches Signed-off-by: Jakub Sokołowski <jakub@status.im>
2019-07-19 18:42:16 +00:00
{
add mark all read for communities Signed-off-by: Michele Balistreri <michele@bitgamma.com>
2021-09-15 11:44:10 +00:00
"_comment": "THIS SHOULD NOT BE EDITED BY HAND.",
update-status-go: does not need to depend on make shell The dependency on `make shell` is confusing and unnecessary since `update-status-go.sh` script only requires availability of the `nix-prefetch-url` utility to check SHA256 of the `status-go` verison. Use of `make shell` with this script can also cause issues when running `make run-android` if already in the shell, which prevents spawning a new one and effectively stops changes to `status-go-verison.json` file taking effect. Signed-off-by: Jakub Sokołowski <jakub@status.im>
2021-09-14 20:16:42 +00:00
"_comment": "Instead use: scripts/update-status-go.sh <rev>",
nix: Use status-go commit sha1 in Nix expression to allow for moving branches Signed-off-by: Jakub Sokołowski <jakub@status.im>
2019-07-19 18:42:16 +00:00
"owner": "status-im",
build status-go for Nix cache Also fix scripts/update-status-go.sh to accept commit SHA1 Signed-off-by: Jakub Sokołowski <jakub@status.im>
2019-07-22 03:31:47 +00:00
"repo": "status-go",
Show "Added to group chat" notifications (#14785) Partially implements https://github.com/status-im/status-mobile/issues/14712 Fixes #14744 ### Summary This PR implements the first, among what will probably be many different kinds of membership notifications. For this PR, I started with implementing a particular flow for private group chats because it's already supported by `status-go` (albeit I had to make some changes, see [PR in status-go](https://github.com/status-im/status-go/pull/3088). 1. `A` and `B` are mutual contacts. 2. `A` creates a private group chat with `B` as member. 3. `B` sees the group chat in the app, but doesn't interact with it. 4. `B` reinstalls the app (remember to back up the seed phrase). 5. `A` mentions `B` in the group chat. 6. `B` should see a group chat notification, which can be accepted/declined. - [x] Also fixes #14744 ### Demo In the video I'm simulating the steps outlined in the *Summary*, but using the approach described in *Steps to test*, because it's way easier to iterate during development. [demo.webm](https://user-images.githubusercontent.com/46027/212470798-c135d229-948d-4ba5-98db-ee73cc5495cd.webm) ### Review Notes Some changes had to be made in `status-go` ([PR](https://github.com/status-im/status-go/pull/3088)), namely: - According to [Figma](https://www.figma.com/file/eDfxTa9IoaCMUy5cLTp0ys/Shell-for-Mobile?node-id=3806%3A586901&t=xLTAjLXjG1UtorpI-0), users should be able to see `accepted` group chat notifications. Until now, `status-go` hardcoded that `accepted` notifications would *not* be returned in query results, and so it would be impossible to show them to users. This was changed and now the RPC endpoint accepts an additional filter. The implementation on the backend is backwards compatible so as to not break Status desktop. - The `Membership` tab needs to display various types of notifications (group chat, community, etc), but the membership type doesn't exist on the backend. To overcome this constraint, this PR makes the membership type a logical/virtual type, i.e. a Clojure set of types. `status-go` was changed to support querying for multiple notification types (also backwards compatible). #### Platforms - Android - iOS ### Steps to test Please, follow the steps described in the Summary and you should be able to test. But during development, I followed these steps (recommended by @cammellos). I documented them here for reference. 1. Checkout `feature/e2e` in status-go. Apply the diff below. 2. `cd cmd/e2e && ./e2e` 3. This will create a temporary account automatically, let's call it `A`. 4. On another device, create account `B`. 5. Follow the steps documented in https://github.com/status-im/status-go/blob/bdc406ea2e6eb990ce5c0fed7ea2e84b63c92139/cmd/e2e/README.md#L2 in order for user `A` to create a group chat with `B` as member. Don't make `A` and `B` mutual contacts. 6. On `B`'s device, a notification should appear, and `B` should be able to accept or decline the "invitation" (actually *invitation* is another concept and related to another feature). ```diff modified cmd/e2e/main.go @@ -283,6 +283,11 @@ func defaultNodeConfig(installationID string) (*params.NodeConfig, error) { nodeConfig.NetworkID = 1 nodeConfig.LogLevel = "ERROR" nodeConfig.DataDir = "/ethereum/mainnet_rpc" + nodeConfig.HTTPEnabled = true + nodeConfig.HTTPPort = 8545 + nodeConfig.HTTPHost = "localhost" + nodeConfig.HTTPVirtualHosts = []string{"localhost"} + nodeConfig.APIModules = "wakuext,ext,waku" nodeConfig.UpstreamConfig = params.UpstreamRPCConfig{ modified protocol/messenger_group_chat.go @@ -26,17 +26,17 @@ func (m *Messenger) validateAddedGroupMembers(members []string) error { } contact, _ := m.allContacts.Load(contactID) - if contact == nil || !(contact.Added && contact.HasAddedUs) { - return ErrGroupChatAddedContacts - } + if contact == nil { + contact, err = buildContactFromPkString(contactID) + if err != nil { + return err + } + } } return nil } func (m *Messenger) CreateGroupChatWithMembers(ctx context.Context, name string, members []string) (*MessengerResponse, error) { - if err := m.validateAddedGroupMembers(members); err != nil { - return nil, err - } var response MessengerResponse logger := m.logger.With(zap.String("site", "CreateGroupChatWithMembers")) ```
2023-01-23 16:54:51 +00:00
"version": "v0.125.0",
"commit-sha1": "e40cbfc28f6195b31eb0f59cbd58fd1d77a12821",
"src-sha256": "0nmys3mf46pilmqrr937b0bc1qi9h51aamyswngy4qfb96nvky85"
[#13116] Load audio messages from http server Signed-off-by: andrey <motor4ik@gmail.com>
2022-02-23 14:46:57 +00:00
}