From dbcf4565f4ce9104890fd7a9174a778b7adcb916 Mon Sep 17 00:00:00 2001 From: Olufemi Ade-Olusile <11324939+OlufemiAdeOlusile@users.noreply.github.com> Date: Tue, 12 Jul 2022 16:58:48 +0100 Subject: [PATCH] chore(StatusIcon): Include Object Name to Status Icon (#761) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * Include auto generated object names for all Icons. This will help Squish tests easily identify Icons. Which is used in test case https://github.com/status-im/status-desktop/issues/6274 * Include auto generated object names for all Icons. This will help Squish tests easily identify Icons. Which is used in test case https://github.com/status-im/status-desktop/issues/6274 * Include auto generated object names for all Icons. This will help Squish tests easily identify Icons. Which is used in test case https://github.com/status-im/status-desktop/issues/6274 * refactor(isContact): rename isMutualContact to isContact BREAKING CHANGE: isMutualContact is replaced by isContact anywhere it was used * fix(StatusStackModal): init the next/finish buttons call `updateRightButtons()` also on creation to correctly initialize the Next and Finish buttons in derived classes, when one overrrides these can be seen in the Backup Seed dialog where the Next button is not enabled even though all 3 boxes are checked * feat(StatusFontSettings): Add StatusFontSettings component to change StatusMenuItems font attributes (#749) Required by #6090 * fix(StatusPinInput): `forceFocus` function exposed * fix(StatusTagSelector): corrected font size in to label Needed for https://github.com/status-im/status-desktop/issues/6349 * fix(StatusActivityCenterButton): fixed actvity icon position (#763) Closes https://github.com/status-im/status-desktop/issues/6350 * Include auto generated object names for all Icons. This will help Squish tests easily identify Icons. Which is used in test case https://github.com/status-im/status-desktop/issues/6274 * Include auto generated object names for all Icons. This will help Squish tests easily identify Icons. Which is used in test case https://github.com/status-im/status-desktop/issues/6274 * Include auto generated object names for all Icons. This will help Squish tests easily identify Icons. Which is used in test case https://github.com/status-im/status-desktop/issues/6274 Co-authored-by: Jonathan Rainville Co-authored-by: Lukáš Tinkl Co-authored-by: Michał Iskierko <61889657+endulab@users.noreply.github.com> Co-authored-by: Sale Djenic Co-authored-by: Alexandra Betouni <31625338+alexandraB99@users.noreply.github.com> --- src/StatusQ/Core/StatusIcon.qml | 1 + 1 file changed, 1 insertion(+) diff --git a/src/StatusQ/Core/StatusIcon.qml b/src/StatusQ/Core/StatusIcon.qml index 1eb5a33b..1344f137 100644 --- a/src/StatusQ/Core/StatusIcon.qml +++ b/src/StatusQ/Core/StatusIcon.qml @@ -15,6 +15,7 @@ Image { onIconChanged: { if (icon !== "") { source = "../../assets/img/icons/" + icon + ".svg"; + objectName = icon + "-icon" } }