status-im
/
status-mobile
mirror of https://github.com/status-im/status-mobile.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity
status-mobile/modules/react-native-status
History
Siddarth Kumar a68b2f357d
fix: node-pre-gyp warning (#19960) 
## Summary

any `yarn` command calls `node-pre-gyp rebuild` which prints out this warning message :

```
make[1]: Entering directory '/Users/siddarthkumar/code/experiments/status-mobile/build'
  CXX(target) Release/obj.target/status_nodejs_addon/modules/react-native-status/nodejs/status.o
../modules/react-native-status/nodejs/status.cpp:1153:11: warning: ignoring return value of function
declared with 'warn_unused_result' attribute [-Wunused-result]
          func->Call(isolate->GetCurrentContext(), v8::Null(isolate), argc, argv);
          ^~~~ ~~~~~~~~~~~~~
1 warning generated.
```

This happens due to return value of `func->Call` here :
52a6f5c17d/modules/react-native-status/nodejs/status.cpp (L1153)
not being used.
Which is not a huge red flag but produces a warning which is not nice when looking at logs and can be sometimes misleading for other devs.

This commit fixes that warning by assigning return value of that function and checking if its empty or not.

## Testing notes
not needed since this impacts only the integration tests.

## Platforms
- macOS

status: ready
 		2024-05-10 17:06:45 +05:30
..
android refactor(local pair sync)_: move partial config to backend (#19753) 2024-04-25 12:13:52 +08:00
ios/RCTStatus refactor(local pair sync)_: move partial config to backend (#19753) 2024-04-25 12:13:52 +08:00
nodejs fix: node-pre-gyp warning (#19960) 2024-05-10 17:06:45 +05:30
index.js update react-native and project dependencies 2017-12-15 16:06:13 +01:00
package.json Lint and fix missing trailing newlines (#16445) 2023-07-04 19:40:13 +00:00
react-native-status.podspec nix: upgrade gomobile to 2022-05-04 version 2022-06-20 19:01:14 +02:00