mirror of
https://github.com/status-im/status-mobile.git
synced 2025-01-11 09:15:56 +00:00
238e35a281
This is a continuation of https://github.com/status-im/status-mobile/pull/16500 (Lint & fix some shadowed core Clojure(Script) vars). Notes: As a reminder, the goal is to eventually disallow shadowing core Clojure vars entirely, but to get there and avoid rebase hell and regressions, we need to do in smaller steps, especially because we can't safely automate the process of unshadowing vars. We are already down from ~500 shadowed core vars to 350 in total. Why is this PR is using names such as "s", "v" or "sym"? Names such as s or v are the so called idiomatic names, and are listed in the Clojure Style Guide https://guide.clojure.style/#idiomatic-names. I used them whenever I felt appropriate. For the var cljs.core/symbol I opted to use sym, even though the symbol in question is not necessarily a Clojure symbol, I think the alias conveys the meaning well enough (https://www.clojure.org/guides/learn/syntax#_symbols_and_idents). New vars linted: - comparator - identity - str - symbol - val Outstanding shadowed vars include type, name, hash, comp.
39 lines
2.4 KiB
Clojure
39 lines
2.4 KiB
Clojure
{:lint-as {status-im.utils.views/defview clojure.core/defn
|
|
status-im.utils.views/letsubs clojure.core/let
|
|
reagent.core/with-let clojure.core/let
|
|
status-im.utils.fx/defn clj-kondo.lint-as/def-catch-all
|
|
utils.re-frame/defn clj-kondo.lint-as/def-catch-all
|
|
quo.react/with-deps-check clojure.core/fn
|
|
quo.previews.preview/list-comp clojure.core/for
|
|
status-im.utils.styles/def clojure.core/def
|
|
status-im.utils.styles/defn clojure.core/defn
|
|
test-helpers.unit/deftest-sub clojure.core/defn
|
|
taoensso.tufte/defnp clojure.core/defn}
|
|
:linters {:consistent-alias {:level :error
|
|
:aliases {clojure.string string
|
|
clojure.set set
|
|
clojure.walk walk
|
|
taoensso.timbre log}}
|
|
:shadowed-var {:level :error
|
|
;; We temporarily use :include to define an
|
|
;; allowlist of core Clojure vars. In the
|
|
;; future, as we progressively fix shadowed
|
|
;; vars, we should be able to delete this
|
|
;; option and lint all vars.
|
|
:include [comparator
|
|
count
|
|
identity
|
|
iter
|
|
key
|
|
str
|
|
symbol
|
|
time
|
|
val]}
|
|
:invalid-arity {:skip-args [status-im.utils.fx/defn utils.re-frame/defn]}
|
|
;; TODO remove number when this is fixed
|
|
;; https://github.com/borkdude/clj-kondo/issues/867
|
|
:unresolved-symbol {:exclude [PersistentPriorityMap.EMPTY
|
|
number
|
|
status-im.test-helpers/restore-app-db]}}
|
|
:config-in-ns {mocks.js-dependencies {:linters {:clojure-lsp/unused-public-var {:level :off}}}}}
|