status-im
/
status-mobile
mirror of https://github.com/status-im/status-mobile.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

Link preview follow up bug fixes (#19359)

This commit is contained in:
Ibrahem Khalil 2024-03-28 23:54:20 +02:00 committed by GitHub
parent 88d1a17a94
commit fef3165f24
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 9 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/status_im/contexts/chat/messenger/composer/link_preview/events.cljs
View File

@ -38,7 +38,8 @@
(let [cache (get-in db [:chat/link-previews :cache]) (let [cache (get-in db [:chat/link-previews :cache])
previews (urls->previews cache urls) previews (urls->previews cache urls)
new-urls (->> previews new-urls (->> previews
(filter :loading?) (filter (fn [{:keys [loading? status-link-preview?]}]
(or loading? status-link-preview?)))
(map :url)) (map :url))
;; `request-id` is a must because we need to process only the last ;; `request-id` is a must because we need to process only the last
;; unfurling event, as well as avoid needlessly updating the app db ;; unfurling event, as well as avoid needlessly updating the app db
@ -139,14 +140,18 @@
sent." sent."
{:events [:link-preview/reset-unfurled]} {:events [:link-preview/reset-unfurled]}
[{:keys [db]}] [{:keys [db]}]
{:db (update db :chat/link-previews dissoc :unfurled :request-id :cleared)}) {:db (-> db
(update :chat/link-previews dissoc :unfurled :request-id :cleared)
(update :chat/status-link-previews dissoc :unfurled :request-id :cleared))})
(rf/defn reset-all (rf/defn reset-all
"Reset all preview state. It is especially important to delete any cached "Reset all preview state. It is especially important to delete any cached
URLs, as failing to do so results in its unbounded growth." URLs, as failing to do so results in its unbounded growth."
{:events [:link-preview/reset-all]} {:events [:link-preview/reset-all]}
[{:keys [db]}] [{:keys [db]}]
{:db (dissoc db :chat/link-previews)}) {:db (-> db
(dissoc :chat/link-previews)
(dissoc :chat/status-link-previews))})
(rf/defn clear-link-previews (rf/defn clear-link-previews
"Mark current unfurled URLs as `cleared`, meaning the user won't see previews "Mark current unfurled URLs as `cleared`, meaning the user won't see previews
@ -156,4 +161,5 @@
(let [unfurled-urls (set (map :url (get-in db [:chat/link-previews :unfurled])))] (let [unfurled-urls (set (map :url (get-in db [:chat/link-previews :unfurled])))]
{:db (-> db {:db (-> db
(update :chat/link-previews dissoc :unfurled :request-id) (update :chat/link-previews dissoc :unfurled :request-id)
(update :chat/status-link-previews dissoc :unfurled :request-id)
(assoc-in [:chat/link-previews :cleared] unfurled-urls))})) (assoc-in [:chat/link-previews :cleared] unfurled-urls))}))