Feature flag descoped features from MVP to streamline initial release (#19690)

Feature flag descoped features from MVP:
- edit derivation path
- wallet/send/contacts
This commit is contained in:
Flavio Fraschetti 2024-04-18 07:44:32 -03:00 committed by GitHub
parent 3af4384e00
commit f708cdcf50
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
6 changed files with 13 additions and 19 deletions

View File

@ -25,9 +25,7 @@
(fn [] (fn []
[rn/view {:style style/container} [rn/view {:style style/container}
[create-or-edit-account/view [create-or-edit-account/view
{:page-nav-right-side [{:icon-name :i/info {:placeholder placeholder
:on-press #(js/alert "Get info (to be implemented)")}]
:placeholder placeholder
:account-name @account-name :account-name @account-name
:account-emoji @account-emoji :account-emoji @account-emoji
:account-color @account-color :account-color @account-color

View File

@ -20,9 +20,6 @@
:accessibility-label :import-using-phrase :accessibility-label :import-using-phrase
:label (i18n/label :t/import-using-phrase) :label (i18n/label :t/import-using-phrase)
:add-divider? true} :add-divider? true}
{:icon :i/keycard-card
:accessibility-label :import-from-keycard
:label (i18n/label :t/import-from-keycard)}
{:icon :i/key {:icon :i/key
:accessibility-label :import-private-key :accessibility-label :import-private-key
:label (i18n/label :t/import-private-key)}]]]) :label (i18n/label :t/import-private-key)}]]])

View File

@ -46,19 +46,18 @@
{:title (i18n/label :t/derivation-path) {:title (i18n/label :t/derivation-path)
:image :icon :image :icon
:image-props :i/derivated-path :image-props :i/derivated-path
:action :button :action (if (ff/enabled? ::ff/wallet.edit-derivation-path) :button :none)
:action-props {:on-press #(if (ff/enabled? ::ff/wallet.edit-derivation-path) :action-props {:on-press #(rf/dispatch [:standard-auth/authorize
(rf/dispatch [:standard-auth/authorize {:on-auth-success on-auth-success
{:on-auth-success on-auth-success :auth-button-label (i18n/label :t/continue)}])
:auth-button-label (i18n/label :t/continue)}])
(js/alert "Coming soon!"))
:button-text (i18n/label :t/edit) :button-text (i18n/label :t/edit)
:icon-left :i/face-id :icon-left :i/face-id
:alignment :flex-start} :alignment :flex-start}
:description :text :description :text
:description-props {:text formatted-path}}])) :description-props {:text formatted-path}}]))
(defn- f-view (defn- view-internal
[_] [_]
(let [top (safe-area/get-top) (let [top (safe-area/get-top)
bottom (safe-area/get-bottom) bottom (safe-area/get-bottom)
@ -180,8 +179,4 @@
:derivation-path derivation-path :derivation-path derivation-path
:customization-color customization-color})}]])))) :customization-color customization-color})}]]))))
(defn- view-internal
[]
[:f> f-view])
(def view (quo.theme/with-theme view-internal)) (def view (quo.theme/with-theme view-internal))

View File

@ -11,6 +11,7 @@
[status-im.contexts.wallet.item-types :as types] [status-im.contexts.wallet.item-types :as types]
[status-im.contexts.wallet.send.select-address.style :as style] [status-im.contexts.wallet.send.select-address.style :as style]
[status-im.contexts.wallet.send.select-address.tabs.view :as tabs] [status-im.contexts.wallet.send.select-address.tabs.view :as tabs]
[status-im.feature-flags :as ff]
[utils.debounce :as debounce] [utils.debounce :as debounce]
[utils.i18n :as i18n] [utils.i18n :as i18n]
[utils.re-frame :as rf])) [utils.re-frame :as rf]))
@ -18,7 +19,8 @@
(def ^:private tabs-data (def ^:private tabs-data
[{:id :tab/recent :label (i18n/label :t/recent) :accessibility-label :recent-tab} [{:id :tab/recent :label (i18n/label :t/recent) :accessibility-label :recent-tab}
{:id :tab/saved :label (i18n/label :t/saved) :accessibility-label :saved-tab} {:id :tab/saved :label (i18n/label :t/saved) :accessibility-label :saved-tab}
{:id :tab/contacts :label (i18n/label :t/contacts) :accessibility-label :contacts-tab} (when (ff/enabled? ::wallet.contacts)
{:id :tab/contacts :label (i18n/label :t/contacts) :accessibility-label :contacts-tab})
{:id :tab/my-accounts :label (i18n/label :t/my-accounts) :accessibility-label :my-accounts-tab}]) {:id :tab/my-accounts :label (i18n/label :t/my-accounts) :accessibility-label :my-accounts-tab}])
(defn- address-input (defn- address-input

View File

@ -16,7 +16,8 @@
::wallet.long-press-watch-only-asset (enabled-in-env? :FLAG_LONG_PRESS_WATCH_ONLY_ASSET_ENABLED) ::wallet.long-press-watch-only-asset (enabled-in-env? :FLAG_LONG_PRESS_WATCH_ONLY_ASSET_ENABLED)
::wallet.assets-modal-manage-tokens (enabled-in-env? :FLAG_ASSETS_MODAL_MANAGE_TOKENS) ::wallet.assets-modal-manage-tokens (enabled-in-env? :FLAG_ASSETS_MODAL_MANAGE_TOKENS)
::wallet.assets-modal-hide (enabled-in-env? :FLAG_ASSETS_MODAL_HIDE) ::wallet.assets-modal-hide (enabled-in-env? :FLAG_ASSETS_MODAL_HIDE)
::community.edit-account-selection (enabled-in-env? :FLAG_EDIT_ACCOUNT_SELECTION_ENABLED)})) ::community.edit-account-selection (enabled-in-env? :FLAG_EDIT_ACCOUNT_SELECTION_ENABLED)
::wallet.contacts (enabled-in-env? :FLAG_CONTACTS_ENABLED)}))
(defn feature-flags [] @feature-flags-config) (defn feature-flags [] @feature-flags-config)

View File

@ -105,6 +105,7 @@
chain-id chain-id
ens-address)] ens-address)]
(assert-address-details response))))) (assert-address-details response)))))
(defn assert-search-ens (defn assert-search-ens
[expected-result actual-result] [expected-result actual-result]
(is (= expected-result actual-result))) (is (= expected-result actual-result)))