status-im
/
status-mobile
mirror of https://github.com/status-im/status-mobile.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

[#4476]: Seed phrase is visible in logs during account recovery

This commit is contained in:
Aleksandr Pantiukhov 2018-05-28 11:47:31 +02:00 committed by Roman Volosovskyi
parent f432bad3c0
commit 3b1721dd0d
No known key found for this signature in database
GPG Key ID: 0238A4B5ECEE70DE
2 changed files with 21 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
src/status_im/ui/screens/accounts/recover/events.cljs
View File

@ -1,14 +1,15 @@
(ns status-im.ui.screens.accounts.recover.events (ns status-im.ui.screens.accounts.recover.events
(:require (:require
status-im.ui.screens.accounts.recover.navigation status-im.ui.screens.accounts.recover.navigation
[clojure.string :as string]
[re-frame.core :as re-frame] [re-frame.core :as re-frame]
[status-im.native-module.core :as status] [status-im.native-module.core :as status]
[status-im.ui.screens.accounts.events :as accounts-events] [status-im.ui.screens.accounts.events :as accounts-events]
[status-im.utils.types :as types] [status-im.utils.types :as types]
[status-im.utils.identicon :as identicon] [status-im.utils.identicon :as identicon]
[clojure.string :as string]
[status-im.utils.handlers :as handlers] [status-im.utils.handlers :as handlers]
[status-im.utils.gfycat.core :as gfycat] [status-im.utils.gfycat.core :as gfycat]
[status-im.utils.security :as security]
[status-im.utils.signing-phrase.core :as signing-phrase] [status-im.utils.signing-phrase.core :as signing-phrase]
[status-im.utils.hex :as utils.hex] [status-im.utils.hex :as utils.hex]
[status-im.constants :as constants])) [status-im.constants :as constants]))
@ -17,11 +18,18 @@
(re-frame/reg-fx (re-frame/reg-fx
::recover-account-fx ::recover-account-fx
(fn [[passphrase password]] (fn [[masked-passphrase password]]
(status/recover-account (status/recover-account
(string/trim passphrase) (security/unmask masked-passphrase)
password password
#(re-frame/dispatch [:account-recovered % password])))) (fn [result]
;; here we deserialize result, dissoc mnemonic and serialize the result again
;; because we want to have information about the result printed in logs, but
;; don't want secure data to be printed
(let [data (-> (types/json->clj result)
(dissoc :mnemonic)
(types/clj->json))]
(re-frame/dispatch [:account-recovered data password]))))))
;;;; Handlers ;;;; Handlers
@ -50,5 +58,5 @@
(handlers/register-handler-fx (handlers/register-handler-fx
:recover-account :recover-account
(fn [_ [_ passphrase password]] (fn [_ [_ masked-passphrase password]]
{::recover-account-fx [passphrase password]})) {::recover-account-fx [masked-passphrase password]}))

10
src/status_im/ui/screens/accounts/recover/views.cljs
View File

@ -1,6 +1,7 @@
(ns status-im.ui.screens.accounts.recover.views (ns status-im.ui.screens.accounts.recover.views
(:require-macros [status-im.utils.views :refer [defview letsubs]]) (:require-macros [status-im.utils.views :refer [defview letsubs]])
(:require [re-frame.core :as re-frame] (:require [clojure.string :as string]
[re-frame.core :as re-frame]
[reagent.core :as reagent] [reagent.core :as reagent]
[status-im.ui.components.text-input.view :as text-input] [status-im.ui.components.text-input.view :as text-input]
[status-im.ui.components.react :as react] [status-im.ui.components.react :as react]
@ -14,7 +15,8 @@
[status-im.utils.config :as config] [status-im.utils.config :as config]
[status-im.react-native.js-dependencies :as js-dependencies] [status-im.react-native.js-dependencies :as js-dependencies]
[cljs.spec.alpha :as spec] [cljs.spec.alpha :as spec]
[status-im.ui.components.common.common :as components.common])) [status-im.ui.components.common.common :as components.common]
[status-im.utils.security :as security]))
(defview passphrase-input [passphrase] (defview passphrase-input [passphrase]
(letsubs [error [:get-in [:accounts/recover :passphrase-error]] (letsubs [error [:get-in [:accounts/recover :passphrase-error]]
@ -65,4 +67,6 @@
{:forward? true {:forward? true
:label (i18n/label :t/sign-in) :label (i18n/label :t/sign-in)
:disabled? (not valid-form?) :disabled? (not valid-form?)
:on-press #(re-frame/dispatch [:recover-account passphrase password])}]]]))) :on-press (fn [_]
(let [masked-passphrase (security/mask-data (string/trim passphrase))]
(re-frame/dispatch [:recover-account masked-passphrase password])))}]]])))