status-im
/
status-mobile
mirror of https://github.com/status-im/status-mobile.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

Don't preload user & dev.user namespaces (#19985) 

Reverts the preloading mechanism from PR
https://github.com/status-im/status-mobile/pull/19927, which introduced a
problem I couldn't find any satisfactory solution. The namespaces user and
dev.user were being preloaded by shadow-cljs, but the problem is that preloading
will fail if those namespaces don't exist in your file system.

I couldn't find any solution to conditionally preload namespaces via shadow-cljs
and ClojureScript unfortunately doesn't support conditional requires like
Clojure.

At least we got to keep the code to not lint them and the whole idea to start to
commit dev-only code inside src/dev/.
This commit is contained in:
Icaro Motta 2024-05-10 15:42:04 -03:00 committed by GitHub
parent 225e3b1c2f
commit 22392464e0
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 1 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
shadow-cljs.edn
View File

@ -53,14 +53,7 @@
:dev {:devtools {:before-load-async status-im.setup.hot-reload/before-reload :dev {:devtools {:before-load-async status-im.setup.hot-reload/before-reload
:after-load-async status-im.setup.hot-reload/reload :after-load-async status-im.setup.hot-reload/reload
:build-notify status-im.setup.hot-reload/build-notify :build-notify status-im.setup.hot-reload/build-notify
:preloads [;; We preload user namespaces so that :preloads [re-frisk-remote.preload
;; their symbols are available without
;; the developer having to manually
;; evaluate them after app
;; initialization.
user
dev.user
re-frisk-remote.preload
status-im.setup.schema-preload status-im.setup.schema-preload
;; In order to use component test helpers in the REPL we ;; In order to use component test helpers in the REPL we
;; need to preload namespaces that are not normally required ;; need to preload namespaces that are not normally required