From 1c50dc706757c49f0c44cf3225495b03133a3258 Mon Sep 17 00:00:00 2001 From: Siddarth Kumar Date: Mon, 26 Jun 2023 12:51:39 +0530 Subject: [PATCH] nix: skip git-lfs checks failing on darwin On macOS `git-lfs` checks fail sometimes and they also take a lot of time to execute. ```log FAIL github.com/git-lfs/git-lfs/v3/lfshttp 0.820s FAIL error: builder for '/nix/store/abd6spw876qvcmlpcwsljsnbpbnvx1fg-git-lfs-3.3.0.drv' failed with exit code 1; last 10 log lines: > Error Trace: certs_test.go:210 > Error: Expected value not to be nil. > Test: TestCertFromSSLCAPathEnv > certs_test.go:210: > Error Trace: certs_test.go:210 > Error: Expected value not to be nil. > Test: TestCertFromSSLCAPathEnv > FAIL > FAIL github.com/git-lfs/git-lfs/v3/lfshttp 0.820s > FAIL For full logs, run 'nix-store -l /nix/store/abd6spw876qvcmlpcwsljsnbpbnvx1fg-git-lfs-3.3.0.drv'. ``` Failures initially observed by me and @smohamedjavid and then today again reported by @yqrashawn This commit adds a `nix` overlay that skips those checks --- nix/overlay.nix | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/nix/overlay.nix b/nix/overlay.nix index 9057d4644c..62a47371c2 100644 --- a/nix/overlay.nix +++ b/nix/overlay.nix @@ -44,6 +44,11 @@ in { }; }); + # Checks fail on darwin. + git-lfs = super.git-lfs.overrideAttrs (old: { + doCheck = false; + }); + # Package version adjustments gradle = super.gradle_7; nodejs = super.nodejs-18_x;