status-im/status-mobile
2
0
Fork 0
mirror of https://github.com/status-im/status-mobile.git synced 2025-01-28 17:36:38 +00:00
Code Issues Projects Releases Wiki Activity

Make popover delay configurable (#15225)

Browse Source 
Make the popover delay in milliseconds configurable.

To open the Activity Center, 30ms delay seems to be more than enough. It's a quick fix because the current 250ms to open the AC gives the wrong impression to users (and confuses even us developers) who think the AC has a performance issue to open.

See issue https://github.com/status-im/status-mobile/pull/15222 for the full discussion.
This commit is contained in:
Icaro Motta 2023-03-02 08:41:18 -03:00 committed by GitHub
parent 4190dfd26b
commit 041622d98b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 9 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/status_im/popover/core.cljs
View File

@ -4,10 +4,14 @@
(rf/defn show-popover (rf/defn show-popover
{:events [:show-popover]} {:events [:show-popover]}
[_ value] [_ value]
{:show-popover nil (let [delay-ms (or (:delay-ms value) 250)
;;TODO refactor popover just start animation on mount value (dissoc value :delay-ms)]
:dispatch-later [{:ms 250 :dispatch [:show-popover-db value]}] {:show-popover nil
:dismiss-keyboard nil}) ;; We should probably refactor to start the animation on mount, so that the
;; delay can be removed. See comment for more details:
;; https://github.com/status-im/status-mobile/pull/15222#issuecomment-1450162137
:dispatch-later [{:ms delay-ms :dispatch [:show-popover-db value]}]
:dismiss-keyboard nil}))
(rf/defn show-popover-db (rf/defn show-popover-db
{:events [:show-popover-db]} {:events [:show-popover-db]}

1
src/status_im2/contexts/activity_center/events.cljs
View File

@ -33,6 +33,7 @@
:dispatch [:show-popover :dispatch [:show-popover
{:view :activity-center {:view :activity-center
:style {:margin 0} :style {:margin 0}
:delay-ms 50
:disable-touchable-overlay? true :disable-touchable-overlay? true
:blur-view? true :blur-view? true
:blur-view-props {:blur-amount 20 :blur-view-props {:blur-amount 20