status-im
/
status-go
mirror of https://github.com/status-im/status-go.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

Created Modifying code in go-ethereum (markdown)

Ivan Daniluk 2017-11-25 21:19:51 +01:00
parent 796f514086
commit f5219d0334
1 changed files with 10 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
Modifying-code-in-go-ethereum.md Normal file

@ -0,0 +1,10 @@
We depend on `go-ethereum` and though the project is loaded as `vendor/github.com/ethereum/go-ethereum` , it actually comes from [`github.com/status-im/go-ethereum`](http://github.com/status-im/go-ethereum) .
The idea is keep all our local changes to `go-ethereum` in [github.com/status-im/go-ethereum](http://github.com/status-im/go-ethereum) and keep them documented and there's a special process to make this happen:
1. Do changes as usual in [`status-go`](http://github.com/status-im/status-go) including `go-ethereum` in the vendor folder.
2. Clone [`github.com/status-im/go-ethereum`](http://github.com/status-im/go-ethereum) and check out the latest branch like `status/1.7.2-stable` .
3. Copy your `go-ethereum` folder from the `status-go` vendor directory into the newly cloned `go-ethereum` .
4. Look at `git diff` and ensure there're only those changes you've intended to make.
5. Commit and push the new changes.
6. Modify [https://github.com/status-im/go-ethereum/wiki/Rebase-Geth-1.7.0](https://github.com/status-im/go-ethereum/wiki/Rebase-Geth-1.7.0) so that other's are aware what the commit there is.