mirror of
https://github.com/status-im/status-go.git
synced 2025-01-11 23:25:29 +00:00
6f088bb5c5
In some instances the communities migration would be skipped but not marked as `dirty`. This commit addresses the issue by: - Making sure that if dirty is set the migration is not skipped but replayed - If the version is on the communities migration and dirty is false, we check for the presence of the communities table. If not present we replay the communities migration. - Make community_id field in user_messages nullable It also removes all the `down` migration, as we can't use them effectively, as explained in the README.md added.
134 lines
3.8 KiB
Go
134 lines
3.8 KiB
Go
package sqlite
|
|
|
|
import (
|
|
"io/ioutil"
|
|
"os"
|
|
"path/filepath"
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/require"
|
|
)
|
|
|
|
func TestOpen(t *testing.T) {
|
|
dir, err := ioutil.TempDir("", "test-open")
|
|
require.NoError(t, err)
|
|
defer os.Remove(dir)
|
|
|
|
dbPath := filepath.Join(dir, "db.sql")
|
|
|
|
// Open the db for the first time.
|
|
db, err := openAndMigrate(dbPath, "some-key", reducedKdfIterationsNumber)
|
|
require.NoError(t, err)
|
|
|
|
// Insert some data.
|
|
_, err = db.Exec("CREATE TABLE test(name TEXT)")
|
|
require.NoError(t, err)
|
|
_, err = db.Exec(`INSERT INTO test (name) VALUES ("abc")`)
|
|
require.NoError(t, err)
|
|
db.Close()
|
|
|
|
// Open again with different key should fail
|
|
// because the file already exists and it should not
|
|
// be recreated.
|
|
_, err = openAndMigrate(dbPath, "different-key", reducedKdfIterationsNumber)
|
|
require.Error(t, err)
|
|
}
|
|
|
|
// TestCommunitiesMigrationDirty tests the communities migration when
|
|
// dirty flag has been set to true.
|
|
// We first make it fail, then clean up so that it can be replayed, and
|
|
// then execute again, and we should be all migrated.
|
|
func TestCommunitiesMigrationDirty(t *testing.T) {
|
|
// Open the db for the first time.
|
|
db, err := open(InMemoryPath, "some-key", reducedKdfIterationsNumber)
|
|
require.NoError(t, err)
|
|
|
|
// Create a communities table, so that migration will fail
|
|
_, err = db.Exec(`CREATE TABLE communities_communities (a varchar);`)
|
|
require.NoError(t, err)
|
|
|
|
// Migrate the database, this should fail
|
|
err = Migrate(db)
|
|
require.Error(t, err)
|
|
|
|
// Version and dirty should be true and set to communities migration
|
|
var version uint
|
|
var dirty bool
|
|
|
|
err = db.QueryRow(`SELECT version, dirty FROM `+migrationsTable).Scan(&version, &dirty)
|
|
require.NoError(t, err)
|
|
|
|
require.True(t, dirty)
|
|
require.Equal(t, communitiesMigrationVersion, version)
|
|
|
|
// Drop communities table and re-run migrations
|
|
|
|
_, err = db.Exec(`DROP TABLE communities_communities`)
|
|
|
|
require.NoError(t, err)
|
|
|
|
// Migrate the database, this should work
|
|
err = Migrate(db)
|
|
require.NoError(t, err)
|
|
|
|
// Make sure communities table is present
|
|
|
|
var name string
|
|
err = db.QueryRow(`SELECT name FROM sqlite_master WHERE type='table' AND name='communities_communities'`).Scan(&name)
|
|
|
|
require.NoError(t, err)
|
|
require.Equal(t, "communities_communities", name)
|
|
|
|
}
|
|
|
|
// TestCommunitiesMigrationNotDirty tests the communities migration when
|
|
// dirty flag has been set to false, and the communities migration has
|
|
// effectively been skipped.
|
|
// We first make it fail, then clean up so that it can be replayed, set
|
|
// dirty to false and then execute again, and we should be all migrated.
|
|
func TestCommunitiesMigrationNotDirty(t *testing.T) {
|
|
// Open the db for the first time.
|
|
db, err := open(InMemoryPath, "some-key", reducedKdfIterationsNumber)
|
|
require.NoError(t, err)
|
|
|
|
// Create a communities table, so that migration will fail
|
|
_, err = db.Exec(`CREATE TABLE communities_communities (a varchar);`)
|
|
require.NoError(t, err)
|
|
|
|
// Migrate the database, this should fail
|
|
err = Migrate(db)
|
|
require.Error(t, err)
|
|
|
|
// Set dirty to false
|
|
_, err = db.Exec(`UPDATE ` + migrationsTable + ` SET dirty = 0`)
|
|
require.NoError(t, err)
|
|
|
|
// Version and dirty should be true and set to communities migration
|
|
var version uint
|
|
var dirty bool
|
|
|
|
err = db.QueryRow(`SELECT version, dirty FROM `+migrationsTable).Scan(&version, &dirty)
|
|
require.NoError(t, err)
|
|
|
|
require.False(t, dirty)
|
|
require.Equal(t, communitiesMigrationVersion, version)
|
|
|
|
// Drop communities table and re-run migrations
|
|
_, err = db.Exec(`DROP TABLE communities_communities`)
|
|
|
|
require.NoError(t, err)
|
|
|
|
// Migrate the database, this should work
|
|
err = Migrate(db)
|
|
require.NoError(t, err)
|
|
|
|
// Make sure communities table is present
|
|
|
|
var name string
|
|
err = db.QueryRow(`SELECT name FROM sqlite_master WHERE type='table' AND name='communities_communities'`).Scan(&name)
|
|
|
|
require.NoError(t, err)
|
|
require.Equal(t, "communities_communities", name)
|
|
|
|
}
|