ed1cdf0418
This change makes invalidation mechanism more aggressive. With a primary goal to invalidate short living nodes faster. In current setup any node that became known in terms of discovery will stay in this state until it will fail to respond to 5 queries. Removing them earlier from a table allows to reduce latency for finding required nodes. The second change, one adds a version for discovery, separates status dht from ethereum dht. After we rolled out discovery it became obvious that our boot nodes became spammed with irrelevant nodes. And this made discovery process very long, for example with separate dht discovery takes ~2s, with mutual dht - it can take 1m-10m and there is still no guarantee to find a max amount of peers, cause status nodes is a very small part of whole ethereum infra. In my understanding, we don't need to be a part of ethereum dht, and lower latency is way more important for us. Closes: #941 Partially closes: #960 (960 requires futher investigations on devices)
Status Patches for geth (go-ethereum)
Status-go uses go-ethereum (upstream) as its dependency. As any other Go dependency go-ethereum code is vendored and stored in vendor/ folder.
However, there are a few changes has been made to the upstream, that are specific to Status and should not be merged to the upstream. We keep those changes as a set of patches, that can be applied upon each next release of go-ethereum. Patched version of go-ethereum is available in vendor folder.
We try to minimize number and amount of changes in those patches as much as possible, and whereas possible, to contribute changes into the upstream.
Creating patches
Instructions for creating a patch from the command line:
- Do changes in
vendor/github.com/ethereum/go-ethereum/, - Go to the root
status-godirectory, - Create a patch
git diff --relative=vendor/github.com/ethereum/go-ethereum > _assets/patches/geth/0000-name-of-the-patch.patch - Commit changes.
Updating patches
- Tweak the patch file.
- Run
make dep-ensureto re-apply patches.
Removing patches
- Remove the patch file
- Remove the link from [this README] (./README.md)
- Run
make dep-ensureto re-apply patches.
Updating
When a new stable release of go-ethereum comes out, we need to upgrade our vendored copy. We use dep for vendoring, so for upgrading:
- Change target branch for
go-ethereuminGopkg.toml. dep ensure -update github.com/ethereum/go-ethereummake dep-ensure
This will ensure that dependency is upgraded and fully patched. Upon success, you can do make vendor-check after committing all the changes, in order to ensure that all changes are valid.