e4cbce12c4
* Update `github.com/ethereum/go-ethereum` package to 1.8.1 branch. Part of #638 * Fix code due to some signature changes. Part of #638 * use upstream for whisper backend * Add patch to downgrade usage of Whisper v6 to v5 in some geth 1.8.1 vendor files. Part of #638 * Take into account the DNS rebinding protection introduced in 1.8.0 by adding exception for localhost. Part of #638 * Add patches required for cross-compiled builds starting with geth 1.8.0. Only applied during build. Part of #638 * Update expected JSON result in `TestRegressionGetTransactionReceipt()` and `TestCallRawResultGetTransactionReceipt()`. Part of #665 * Fix some failing e2e tests. Part of #638 * Address comments in PR #702. Part of #638
Status Patches for geth (go-ethereum)
Status-go uses go-ethereum (upstream) as its dependency. As any other Go dependency go-ethereum code is vendored and stored in vendor/ folder.
However, there are a few changes has been made to the upstream, that are specific to Status and should not be merged to the upstream. We keep those changes as a set of patches, that can be applied upon each next release of go-ethereum. Patched version of go-ethereum is available in vendor folder.
We try to minimize number and amount of changes in those patches as much as possible, and whereas possible, to contribute changes into the upstream.
Creating patches
Instructions for creating a patch from the command line:
- Enter the command line at the go-ethereum dependency root in vendor folder.
- Create the patch:
- If you already have a commit that represents the change, find its SHA1 (e.g.
$COMMIT_SHA1) and dogit diff $COMMIT_SHA1 > file.patch - If the files are staged, do
git diff --cached > file.patch
- If you already have a commit that represents the change, find its SHA1 (e.g.
Updating patches
- Tweak the patch file.
- Run
make dep-ensureto re-apply patches.
Removing patches
- Remove the patch file
- Remove the link from [this README] (./README.md)
- Run
make dep-ensureto re-apply patches.
Patches
0000-accounts-hd-keys.patch— adds support for HD extended keys (links/docs?)0004-whisper-notifications.patch— adds Whisper notifications (need to be reviewed and documented)0006-latest-cht.patch– updates CHT root hashes, should be updated regularly to keep sync fast, until proper Trusted Checkpoint sync is not implemented as part of LES/2 protocol.0009-whisper-envelopes-tracing.patch— adds Whisper envelope tracing (need to be reviewed and documented)0010-geth-17-fix-npe-in-filter-system.patch- Temp patch for 1.7.x to fix a NPE in the filter system.0014-whisperv6-notifications.patch— adds Whisper v6 notifications (need to be reviewed and documented)0015-whisperv6-envelopes-tracing.patch— adds Whisper v6 envelope tracing (need to be reviewed and documented)0017-geth-18-downgrade-to-whisperv5.patch— some files in geth 1.8 import Whisper v6, instead of v5. This patch ensures v5 is used everywhere
Updating
When a new stable release of go-ethereum comes out, we need to upgrade our vendored copy. We use dep for vendoring, so for upgrading:
- Change target branch for
go-ethereuminGopkg.toml. dep ensure -update github.com/ethereum/go-ethereummake dep-ensure
This will ensure that dependency is upgraded and fully patched. Upon success, you can do make vendor-check after committing all the changes, in order to ensure that all changes are valid.