mirror of
https://github.com/status-im/status-go.git
synced 2025-01-09 22:26:30 +00:00
248e4a7f24
This is a bigger change in how community membership requests are handled among admins, token masters, owners, and control nodes. Prior to this commit, all privileged users, also known as `EventSenders`, were able to accept and reject community membership requests and those changes would be applied by all users. This commit changes this behaviour such that: 1. EventSenders can make a decision (accept, reject), but merely forward their decision to the control node, which ultimately has to confirm it 2. EventSenders are no longer removing or adding members to and from communities 3. When an eventsender signaled a decision, the membership request will enter a pending state (acceptedPending or rejectedPending) 4. Once a decision was made by one eventsender, no other eventsender can override that decision This implementation is covered with a bunch of tests: - Ensure that decision made by event sender is shared with other event senders - `testAcceptMemberRequestToJoinResponseSharedWithOtherEventSenders()` - `testRejectMemberRequestToJoinResponseSharedWithOtherEventSenders()` - Ensure memebrship request stays pending, until control node has confirmed decision by event senders - `testAcceptMemberRequestToJoinNotConfirmedByControlNode()` - `testRejectMemberRequestToJoinNotConfirmedByControlNode()` - Ensure that decision made by event sender cannot be overriden by other event senders - `testEventSenderCannotOverrideRequestToJoinState()` These test cases live in three test suites for different event sender types respectively - `OwnerWithoutCommunityKeyCommunityEventsSuite` - `TokenMasterCommunityEventsSuite` - `AdminCommunityEventsSuite` In addition to the changes mentioned above, there's also a smaller changes that ensures membership requests to *not* attached revealed wallet addresses when the requests are sent to event senders (in addition to control nodes). Requests send to a control node will still include revealed addresses as the control node needs them to verify token permissions. This commit does not yet handle the case of event senders attempting to kick and ban members. Similar to accepting and rejecting membership requests, kicking and banning need a new pending state. However, we don't track such state in local databases yet so those two cases will be handled in future commit to not have this commit grow larger.
92 lines
2.8 KiB
Go
92 lines
2.8 KiB
Go
package communities
|
|
|
|
import (
|
|
"fmt"
|
|
"strconv"
|
|
"time"
|
|
|
|
"github.com/status-im/status-go/eth-node/types"
|
|
"github.com/status-im/status-go/protocol/protobuf"
|
|
)
|
|
|
|
type RequestToJoinState uint
|
|
|
|
const (
|
|
RequestToJoinStatePending RequestToJoinState = iota + 1
|
|
RequestToJoinStateDeclined
|
|
RequestToJoinStateAccepted
|
|
RequestToJoinStateCanceled
|
|
RequestToJoinStateAcceptedPending
|
|
RequestToJoinStateDeclinedPending
|
|
)
|
|
|
|
type RequestToJoin struct {
|
|
ID types.HexBytes `json:"id"`
|
|
PublicKey string `json:"publicKey"`
|
|
Clock uint64 `json:"clock"`
|
|
ENSName string `json:"ensName,omitempty"`
|
|
ChatID string `json:"chatId"`
|
|
CommunityID types.HexBytes `json:"communityId"`
|
|
State RequestToJoinState `json:"state"`
|
|
Our bool `json:"our"`
|
|
Deleted bool `json:"deleted"`
|
|
RevealedAccounts []*protobuf.RevealedAccount `json:"revealedAccounts,omitempty"`
|
|
}
|
|
|
|
func (r *RequestToJoin) CalculateID() {
|
|
r.ID = CalculateRequestID(r.PublicKey, r.CommunityID)
|
|
}
|
|
|
|
func (r *RequestToJoin) ToCommunityRequestToJoinProtobuf() *protobuf.CommunityRequestToJoin {
|
|
return &protobuf.CommunityRequestToJoin{
|
|
Clock: r.Clock,
|
|
EnsName: r.ENSName,
|
|
CommunityId: r.CommunityID,
|
|
RevealedAccounts: r.RevealedAccounts,
|
|
}
|
|
}
|
|
|
|
func (r *RequestToJoin) ToSyncProtobuf() *protobuf.SyncCommunityRequestsToJoin {
|
|
return &protobuf.SyncCommunityRequestsToJoin{
|
|
Id: r.ID,
|
|
PublicKey: r.PublicKey,
|
|
Clock: r.Clock,
|
|
EnsName: r.ENSName,
|
|
ChatId: r.ChatID,
|
|
CommunityId: r.CommunityID,
|
|
State: uint64(r.State),
|
|
RevealedAccounts: r.RevealedAccounts,
|
|
}
|
|
}
|
|
|
|
func (r *RequestToJoin) InitFromSyncProtobuf(proto *protobuf.SyncCommunityRequestsToJoin) {
|
|
r.ID = proto.Id
|
|
r.PublicKey = proto.PublicKey
|
|
r.Clock = proto.Clock
|
|
r.ENSName = proto.EnsName
|
|
r.ChatID = proto.ChatId
|
|
r.CommunityID = proto.CommunityId
|
|
r.State = RequestToJoinState(proto.State)
|
|
r.RevealedAccounts = proto.RevealedAccounts
|
|
}
|
|
|
|
func (r *RequestToJoin) Empty() bool {
|
|
return len(r.ID)+len(r.PublicKey)+int(r.Clock)+len(r.ENSName)+len(r.ChatID)+len(r.CommunityID)+int(r.State) == 0
|
|
}
|
|
|
|
func (r *RequestToJoin) MarkedAsPendingByPrivilegedAccount() bool {
|
|
return r.State == RequestToJoinStateAcceptedPending || r.State == RequestToJoinStateDeclinedPending
|
|
}
|
|
|
|
func AddTimeoutToRequestToJoinClock(clock uint64) (uint64, error) {
|
|
requestToJoinClock, err := strconv.ParseInt(fmt.Sprint(clock), 10, 64)
|
|
if err != nil {
|
|
return 0, err
|
|
}
|
|
|
|
// Adding 7 days to the request clock
|
|
requestTimeOutClock := uint64(time.Unix(requestToJoinClock, 0).AddDate(0, 0, 7).Unix())
|
|
|
|
return requestTimeOutClock, nil
|
|
}
|