mirror of
https://github.com/status-im/status-go.git
synced 2025-02-08 04:43:52 +00:00
author shashankshampi <shashank.sanket1995@gmail.com> 1729780155 +0530 committer shashankshampi <shashank.sanket1995@gmail.com> 1730274350 +0530 test: Code Migration from status-cli-tests fix_: functional tests (#5979) * fix_: generate on test-functional * chore(test)_: fix functional test assertion --------- Co-authored-by: Siddarth Kumar <siddarthkay@gmail.com> feat(accounts)_: cherry-pick Persist acceptance of Terms of Use & Privacy policy (#5766) (#5977) * feat(accounts)_: Persist acceptance of Terms of Use & Privacy policy (#5766) The original GH issue https://github.com/status-im/status-mobile/issues/21113 came from a request from the Legal team. We must show to Status v1 users the new terms (Terms of Use & Privacy Policy) right after they upgrade to Status v2 from the stores. The solution we use is to create a flag in the accounts table, named hasAcceptedTerms. The flag will be set to true on the first account ever created in v2 and we provide a native call in mobile/status.go#AcceptTerms, which allows the client to persist the user's choice in case they are upgrading (from v1 -> v2, or from a v2 older than this PR). This solution is not the best because we should store the setting in a separate table, not in the accounts table. Related Mobile PR https://github.com/status-im/status-mobile/pull/21124 * fix(test)_: Compare addresses using uppercased strings --------- Co-authored-by: Icaro Motta <icaro.ldm@gmail.com> test_: restore account (#5960) feat_: `LogOnPanic` linter (#5969) * feat_: LogOnPanic linter * fix_: add missing defer LogOnPanic * chore_: make vendor * fix_: tests, address pr comments * fix_: address pr comments fix(ci)_: remove workspace and tmp dir This ensures we do not encounter weird errors like: ``` + ln -s /home/jenkins/workspace/go_prs_linux_x86_64_main_PR-5907 /home/jenkins/workspace/go_prs_linux_x86_64_main_PR-5907@tmp/go/src/github.com/status-im/status-go ln: failed to create symbolic link '/home/jenkins/workspace/go_prs_linux_x86_64_main_PR-5907@tmp/go/src/github.com/status-im/status-go': File exists script returned exit code 1 ``` Signed-off-by: Jakub Sokołowski <jakub@status.im> chore_: enable windows and macos CI build (#5840) - Added support for Windows and macOS in CI pipelines - Added missing dependencies for Windows and x86-64-darwin - Resolved macOS SDK version compatibility for darwin-x86_64 The `mkShell` override was necessary to ensure compatibility with the newer macOS SDK (version 11.0) for x86_64. The default SDK (10.12) was causing build failures because of the missing libs and frameworks. OverrideSDK creates a mapping from the default SDK in all package categories to the requested SDK (11.0). fix(contacts)_: fix trust status not being saved to cache when changed (#5965) Fixes https://github.com/status-im/status-desktop/issues/16392 cleanup added logger and cleanup review comments changes fix_: functional tests (#5979) * fix_: generate on test-functional * chore(test)_: fix functional test assertion --------- Co-authored-by: Siddarth Kumar <siddarthkay@gmail.com> feat(accounts)_: cherry-pick Persist acceptance of Terms of Use & Privacy policy (#5766) (#5977) * feat(accounts)_: Persist acceptance of Terms of Use & Privacy policy (#5766) The original GH issue https://github.com/status-im/status-mobile/issues/21113 came from a request from the Legal team. We must show to Status v1 users the new terms (Terms of Use & Privacy Policy) right after they upgrade to Status v2 from the stores. The solution we use is to create a flag in the accounts table, named hasAcceptedTerms. The flag will be set to true on the first account ever created in v2 and we provide a native call in mobile/status.go#AcceptTerms, which allows the client to persist the user's choice in case they are upgrading (from v1 -> v2, or from a v2 older than this PR). This solution is not the best because we should store the setting in a separate table, not in the accounts table. Related Mobile PR https://github.com/status-im/status-mobile/pull/21124 * fix(test)_: Compare addresses using uppercased strings --------- Co-authored-by: Icaro Motta <icaro.ldm@gmail.com> test_: restore account (#5960) feat_: `LogOnPanic` linter (#5969) * feat_: LogOnPanic linter * fix_: add missing defer LogOnPanic * chore_: make vendor * fix_: tests, address pr comments * fix_: address pr comments chore_: enable windows and macos CI build (#5840) - Added support for Windows and macOS in CI pipelines - Added missing dependencies for Windows and x86-64-darwin - Resolved macOS SDK version compatibility for darwin-x86_64 The `mkShell` override was necessary to ensure compatibility with the newer macOS SDK (version 11.0) for x86_64. The default SDK (10.12) was causing build failures because of the missing libs and frameworks. OverrideSDK creates a mapping from the default SDK in all package categories to the requested SDK (11.0). fix(contacts)_: fix trust status not being saved to cache when changed (#5965) Fixes https://github.com/status-im/status-desktop/issues/16392 test_: remove port bind chore(wallet)_: move route execution code to separate module chore_: replace geth logger with zap logger (#5962) closes: #6002 feat(telemetry)_: add metrics for message reliability (#5899) * feat(telemetry)_: track message reliability Add metrics for dial errors, missed messages, missed relevant messages, and confirmed delivery. * fix_: handle error from json marshal chore_: use zap logger as request logger iterates: status-im/status-desktop#16536 test_: unique project per run test_: use docker compose v2, more concrete project name fix(codecov)_: ignore folders without tests Otherwise Codecov reports incorrect numbers when making changes. https://docs.codecov.com/docs/ignoring-paths Signed-off-by: Jakub Sokołowski <jakub@status.im> test_: verify schema of signals during init; fix schema verification warnings (#5947) fix_: update defaultGorushURL (#6011) fix(tests)_: use non-standard port to avoid conflicts We have observed `nimbus-eth2` build failures reporting this port: ```json { "lvl": "NTC", "ts": "2024-10-28 13:51:32.308+00:00", "msg": "REST HTTP server could not be started", "topics": "beacnde", "address": "127.0.0.1:5432", "reason": "(98) Address already in use" } ``` https://ci.status.im/job/nimbus-eth2/job/platforms/job/linux/job/x86_64/job/main/job/PR-6683/3/ Signed-off-by: Jakub Sokołowski <jakub@status.im> fix_: create request logger ad-hoc in tests Fixes `TestCall` failing when run concurrently. chore_: configure codecov (#6005) * chore_: configure codecov * fix_: after_n_builds
223 lines
6.4 KiB
Go
223 lines
6.4 KiB
Go
package rpc
|
|
|
|
import (
|
|
"context"
|
|
"encoding/json"
|
|
|
|
"go.uber.org/zap"
|
|
|
|
gethrpc "github.com/ethereum/go-ethereum/rpc"
|
|
)
|
|
|
|
const (
|
|
jsonrpcVersion = "2.0"
|
|
errInvalidMessageCode = -32700 // from go-ethereum/rpc/errors.go
|
|
)
|
|
|
|
// for JSON-RPC responses obtained via CallRaw(), we have no way
|
|
// to know ID field from actual response. web3.js (primary and
|
|
// only user of CallRaw()) will validate response by checking
|
|
// ID field for being a number:
|
|
// https://github.com/ethereum/web3.js/blob/develop/lib/web3/jsonrpc.js#L66
|
|
// thus, we will use zero ID as a workaround of this limitation
|
|
var defaultMsgID = json.RawMessage(`0`)
|
|
|
|
// CallRaw performs a JSON-RPC call with already crafted JSON-RPC body. It
|
|
// returns string in JSON format with response (successul or error).
|
|
func (c *Client) CallRaw(body string) string {
|
|
ctx := context.Background()
|
|
return c.callRawContext(ctx, json.RawMessage(body))
|
|
}
|
|
|
|
// jsonrpcMessage represents JSON-RPC message
|
|
type jsonrpcMessage struct {
|
|
Version string `json:"jsonrpc"`
|
|
ID json.RawMessage `json:"id"`
|
|
}
|
|
|
|
type jsonrpcRequest struct {
|
|
jsonrpcMessage
|
|
ChainID uint64 `json:"chainId"`
|
|
Method string `json:"method"`
|
|
Params json.RawMessage `json:"params,omitempty"`
|
|
}
|
|
|
|
type jsonrpcSuccessfulResponse struct {
|
|
jsonrpcMessage
|
|
Result json.RawMessage `json:"result"`
|
|
}
|
|
|
|
type jsonrpcErrorResponse struct {
|
|
jsonrpcMessage
|
|
Error jsonError `json:"error"`
|
|
}
|
|
|
|
// jsonError represents Error message for JSON-RPC responses.
|
|
type jsonError struct {
|
|
Code int `json:"code"`
|
|
Message string `json:"message"`
|
|
Data interface{} `json:"data,omitempty"`
|
|
}
|
|
|
|
// callRawContext performs a JSON-RPC call with already crafted JSON-RPC body and
|
|
// given context. It returns string in JSON format with response (successful or error).
|
|
//
|
|
// TODO(divan): this function exists for compatibility and uses default
|
|
// go-ethereum's RPC client under the hood. It adds some unnecessary overhead
|
|
// by first marshalling JSON string into object to use with normal Call,
|
|
// which is then umarshalled back to the same JSON. The same goes with response.
|
|
// This is waste of CPU and memory and should be avoided if possible,
|
|
// either by changing exported API (provide only Call, not CallRaw) or
|
|
// refactoring go-ethereum's client to allow using raw JSON directly.
|
|
func (c *Client) callRawContext(ctx context.Context, body json.RawMessage) string {
|
|
if isBatch(body) {
|
|
return c.callBatchMethods(ctx, body)
|
|
}
|
|
|
|
return c.callSingleMethod(ctx, body)
|
|
}
|
|
|
|
// callBatchMethods handles batched JSON-RPC requests, calling each of
|
|
// individual requests one by one and constructing proper batched response.
|
|
//
|
|
// See http://www.jsonrpc.org/specification#batch for details.
|
|
//
|
|
// We can't use gethtrpc.BatchCall here, because each call should go through
|
|
// our routing logic and router to corresponding destination.
|
|
func (c *Client) callBatchMethods(ctx context.Context, msgs json.RawMessage) string {
|
|
var requests []json.RawMessage
|
|
|
|
err := json.Unmarshal(msgs, &requests)
|
|
if err != nil {
|
|
return newErrorResponse(errInvalidMessageCode, err, defaultMsgID)
|
|
}
|
|
|
|
// run all methods sequentially, this seems to be main
|
|
// objective to use batched requests.
|
|
// See: https://github.com/ethereum/wiki/wiki/JavaScript-API#batch-requests
|
|
responses := make([]json.RawMessage, len(requests))
|
|
for i := range requests {
|
|
resp := c.callSingleMethod(ctx, requests[i])
|
|
responses[i] = json.RawMessage(resp)
|
|
}
|
|
|
|
data, err := json.Marshal(responses)
|
|
if err != nil {
|
|
c.logger.Error("Failed to marshal batch responses:", zap.Error(err))
|
|
return newErrorResponse(errInvalidMessageCode, err, defaultMsgID)
|
|
}
|
|
|
|
return string(data)
|
|
}
|
|
|
|
// callSingleMethod executes single JSON-RPC message and constructs proper response.
|
|
func (c *Client) callSingleMethod(ctx context.Context, msg json.RawMessage) string {
|
|
// unmarshal JSON body into json-rpc request
|
|
chainID, method, params, id, err := methodAndParamsFromBody(msg)
|
|
if err != nil {
|
|
return newErrorResponse(errInvalidMessageCode, err, id)
|
|
}
|
|
|
|
if chainID == 0 {
|
|
chainID = c.UpstreamChainID
|
|
}
|
|
|
|
// route and execute
|
|
var result json.RawMessage
|
|
err = c.CallContext(ctx, &result, chainID, method, params...)
|
|
|
|
// as we have to return original JSON, we have to
|
|
// analyze returned error and reconstruct original
|
|
// JSON error response.
|
|
if err != nil && err != gethrpc.ErrNoResult {
|
|
if er, ok := err.(gethrpc.Error); ok {
|
|
return newErrorResponse(er.ErrorCode(), err, id)
|
|
}
|
|
|
|
return newErrorResponse(errInvalidMessageCode, err, id)
|
|
}
|
|
|
|
// finally, marshal answer
|
|
return newSuccessResponse(result, id)
|
|
}
|
|
|
|
// methodAndParamsFromBody extracts Method and Params of
|
|
// JSON-RPC body into values ready to use with ethereum-go's
|
|
// RPC client Call() function. A lot of empty interface usage is
|
|
// due to the underlying code design :/
|
|
func methodAndParamsFromBody(body json.RawMessage) (uint64, string, []interface{}, json.RawMessage, error) {
|
|
msg, err := unmarshalMessage(body)
|
|
if err != nil {
|
|
return 0, "", nil, nil, err
|
|
}
|
|
params := []interface{}{}
|
|
if msg.Params != nil {
|
|
err = json.Unmarshal(msg.Params, ¶ms)
|
|
if err != nil {
|
|
return 0, "", nil, nil, err
|
|
}
|
|
}
|
|
|
|
return msg.ChainID, msg.Method, params, msg.ID, nil
|
|
}
|
|
|
|
// unmarshalMessage tries to unmarshal JSON-RPC message.
|
|
func unmarshalMessage(body json.RawMessage) (*jsonrpcRequest, error) {
|
|
var msg jsonrpcRequest
|
|
err := json.Unmarshal(body, &msg)
|
|
return &msg, err
|
|
}
|
|
|
|
func newSuccessResponse(result json.RawMessage, id json.RawMessage) string {
|
|
if id == nil {
|
|
id = defaultMsgID
|
|
}
|
|
|
|
msg := &jsonrpcSuccessfulResponse{
|
|
jsonrpcMessage: jsonrpcMessage{
|
|
ID: id,
|
|
Version: jsonrpcVersion,
|
|
},
|
|
Result: result,
|
|
}
|
|
data, err := json.Marshal(msg)
|
|
if err != nil {
|
|
return newErrorResponse(errInvalidMessageCode, err, id)
|
|
}
|
|
|
|
return string(data)
|
|
}
|
|
|
|
func newErrorResponse(code int, err error, id json.RawMessage) string {
|
|
if id == nil {
|
|
id = defaultMsgID
|
|
}
|
|
|
|
errMsg := &jsonrpcErrorResponse{
|
|
jsonrpcMessage: jsonrpcMessage{
|
|
ID: id,
|
|
Version: jsonrpcVersion,
|
|
},
|
|
Error: jsonError{
|
|
Code: code,
|
|
Message: err.Error(),
|
|
},
|
|
}
|
|
|
|
data, _ := json.Marshal(errMsg)
|
|
return string(data)
|
|
}
|
|
|
|
// isBatch returns true when the first non-whitespace characters is '['
|
|
// code from go-ethereum's rpc client (rpc/client.go)
|
|
func isBatch(msg json.RawMessage) bool {
|
|
for _, c := range msg {
|
|
// skip insignificant whitespace (http://www.ietf.org/rfc/rfc4627.txt)
|
|
if c == 0x20 || c == 0x09 || c == 0x0a || c == 0x0d {
|
|
continue
|
|
}
|
|
return c == '['
|
|
}
|
|
return false
|
|
}
|