mirror of
https://github.com/status-im/status-go.git
synced 2025-02-08 04:43:52 +00:00
c67d4030ac
author shashankshampi <shashank.sanket1995@gmail.com> 1729780155 +0530 committer shashankshampi <shashank.sanket1995@gmail.com> 1730274350 +0530 test: Code Migration from status-cli-tests fix_: functional tests (#5979) * fix_: generate on test-functional * chore(test)_: fix functional test assertion --------- Co-authored-by: Siddarth Kumar <siddarthkay@gmail.com> feat(accounts)_: cherry-pick Persist acceptance of Terms of Use & Privacy policy (#5766) (#5977) * feat(accounts)_: Persist acceptance of Terms of Use & Privacy policy (#5766) The original GH issue https://github.com/status-im/status-mobile/issues/21113 came from a request from the Legal team. We must show to Status v1 users the new terms (Terms of Use & Privacy Policy) right after they upgrade to Status v2 from the stores. The solution we use is to create a flag in the accounts table, named hasAcceptedTerms. The flag will be set to true on the first account ever created in v2 and we provide a native call in mobile/status.go#AcceptTerms, which allows the client to persist the user's choice in case they are upgrading (from v1 -> v2, or from a v2 older than this PR). This solution is not the best because we should store the setting in a separate table, not in the accounts table. Related Mobile PR https://github.com/status-im/status-mobile/pull/21124 * fix(test)_: Compare addresses using uppercased strings --------- Co-authored-by: Icaro Motta <icaro.ldm@gmail.com> test_: restore account (#5960) feat_: `LogOnPanic` linter (#5969) * feat_: LogOnPanic linter * fix_: add missing defer LogOnPanic * chore_: make vendor * fix_: tests, address pr comments * fix_: address pr comments fix(ci)_: remove workspace and tmp dir This ensures we do not encounter weird errors like: ``` + ln -s /home/jenkins/workspace/go_prs_linux_x86_64_main_PR-5907 /home/jenkins/workspace/go_prs_linux_x86_64_main_PR-5907@tmp/go/src/github.com/status-im/status-go ln: failed to create symbolic link '/home/jenkins/workspace/go_prs_linux_x86_64_main_PR-5907@tmp/go/src/github.com/status-im/status-go': File exists script returned exit code 1 ``` Signed-off-by: Jakub Sokołowski <jakub@status.im> chore_: enable windows and macos CI build (#5840) - Added support for Windows and macOS in CI pipelines - Added missing dependencies for Windows and x86-64-darwin - Resolved macOS SDK version compatibility for darwin-x86_64 The `mkShell` override was necessary to ensure compatibility with the newer macOS SDK (version 11.0) for x86_64. The default SDK (10.12) was causing build failures because of the missing libs and frameworks. OverrideSDK creates a mapping from the default SDK in all package categories to the requested SDK (11.0). fix(contacts)_: fix trust status not being saved to cache when changed (#5965) Fixes https://github.com/status-im/status-desktop/issues/16392 cleanup added logger and cleanup review comments changes fix_: functional tests (#5979) * fix_: generate on test-functional * chore(test)_: fix functional test assertion --------- Co-authored-by: Siddarth Kumar <siddarthkay@gmail.com> feat(accounts)_: cherry-pick Persist acceptance of Terms of Use & Privacy policy (#5766) (#5977) * feat(accounts)_: Persist acceptance of Terms of Use & Privacy policy (#5766) The original GH issue https://github.com/status-im/status-mobile/issues/21113 came from a request from the Legal team. We must show to Status v1 users the new terms (Terms of Use & Privacy Policy) right after they upgrade to Status v2 from the stores. The solution we use is to create a flag in the accounts table, named hasAcceptedTerms. The flag will be set to true on the first account ever created in v2 and we provide a native call in mobile/status.go#AcceptTerms, which allows the client to persist the user's choice in case they are upgrading (from v1 -> v2, or from a v2 older than this PR). This solution is not the best because we should store the setting in a separate table, not in the accounts table. Related Mobile PR https://github.com/status-im/status-mobile/pull/21124 * fix(test)_: Compare addresses using uppercased strings --------- Co-authored-by: Icaro Motta <icaro.ldm@gmail.com> test_: restore account (#5960) feat_: `LogOnPanic` linter (#5969) * feat_: LogOnPanic linter * fix_: add missing defer LogOnPanic * chore_: make vendor * fix_: tests, address pr comments * fix_: address pr comments chore_: enable windows and macos CI build (#5840) - Added support for Windows and macOS in CI pipelines - Added missing dependencies for Windows and x86-64-darwin - Resolved macOS SDK version compatibility for darwin-x86_64 The `mkShell` override was necessary to ensure compatibility with the newer macOS SDK (version 11.0) for x86_64. The default SDK (10.12) was causing build failures because of the missing libs and frameworks. OverrideSDK creates a mapping from the default SDK in all package categories to the requested SDK (11.0). fix(contacts)_: fix trust status not being saved to cache when changed (#5965) Fixes https://github.com/status-im/status-desktop/issues/16392 test_: remove port bind chore(wallet)_: move route execution code to separate module chore_: replace geth logger with zap logger (#5962) closes: #6002 feat(telemetry)_: add metrics for message reliability (#5899) * feat(telemetry)_: track message reliability Add metrics for dial errors, missed messages, missed relevant messages, and confirmed delivery. * fix_: handle error from json marshal chore_: use zap logger as request logger iterates: status-im/status-desktop#16536 test_: unique project per run test_: use docker compose v2, more concrete project name fix(codecov)_: ignore folders without tests Otherwise Codecov reports incorrect numbers when making changes. https://docs.codecov.com/docs/ignoring-paths Signed-off-by: Jakub Sokołowski <jakub@status.im> test_: verify schema of signals during init; fix schema verification warnings (#5947) fix_: update defaultGorushURL (#6011) fix(tests)_: use non-standard port to avoid conflicts We have observed `nimbus-eth2` build failures reporting this port: ```json { "lvl": "NTC", "ts": "2024-10-28 13:51:32.308+00:00", "msg": "REST HTTP server could not be started", "topics": "beacnde", "address": "127.0.0.1:5432", "reason": "(98) Address already in use" } ``` https://ci.status.im/job/nimbus-eth2/job/platforms/job/linux/job/x86_64/job/main/job/PR-6683/3/ Signed-off-by: Jakub Sokołowski <jakub@status.im> fix_: create request logger ad-hoc in tests Fixes `TestCall` failing when run concurrently. chore_: configure codecov (#6005) * chore_: configure codecov * fix_: after_n_builds
177 lines
4.3 KiB
Go
177 lines
4.3 KiB
Go
package node
|
|
|
|
import (
|
|
"context"
|
|
"database/sql"
|
|
"fmt"
|
|
"io/ioutil"
|
|
"os"
|
|
"strings"
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/require"
|
|
"go.uber.org/zap"
|
|
|
|
"github.com/status-im/status-go/appdatabase"
|
|
"github.com/status-im/status-go/multiaccounts"
|
|
"github.com/status-im/status-go/params"
|
|
"github.com/status-im/status-go/protocol/tt"
|
|
"github.com/status-im/status-go/t/helpers"
|
|
"github.com/status-im/status-go/walletdatabase"
|
|
)
|
|
|
|
type TestServiceAPI struct{}
|
|
|
|
func (api *TestServiceAPI) SomeMethod(_ context.Context) (string, error) {
|
|
return "some method result", nil
|
|
}
|
|
|
|
func setupTestDBs() (appDB *sql.DB, walletDB *sql.DB, closeFn func() error, err error) {
|
|
appDB, err = helpers.SetupTestMemorySQLDB(appdatabase.DbInitializer{})
|
|
if err != nil {
|
|
return nil, nil, nil, fmt.Errorf("failed to setup app db: %w", err)
|
|
}
|
|
|
|
walletDB, err = helpers.SetupTestMemorySQLDB(walletdatabase.DbInitializer{})
|
|
if err != nil {
|
|
return nil, nil, nil, fmt.Errorf("failed to setup wallet db: %w", err)
|
|
}
|
|
return appDB, walletDB, func() error {
|
|
appErr := appDB.Close()
|
|
walletErr := walletDB.Close()
|
|
if appErr != nil {
|
|
return fmt.Errorf("failed to close app db: %w", appErr)
|
|
}
|
|
if walletErr != nil {
|
|
return fmt.Errorf("failed to close wallet db: %w", walletErr)
|
|
}
|
|
return nil
|
|
}, err
|
|
}
|
|
|
|
func setupTestMultiDB() (*multiaccounts.Database, func() error, error) {
|
|
tmpfile, err := ioutil.TempFile("", "tests")
|
|
if err != nil {
|
|
return nil, nil, err
|
|
}
|
|
db, err := multiaccounts.InitializeDB(tmpfile.Name())
|
|
if err != nil {
|
|
return nil, nil, err
|
|
}
|
|
return db, func() error {
|
|
err := db.Close()
|
|
if err != nil {
|
|
return err
|
|
}
|
|
return os.Remove(tmpfile.Name())
|
|
}, nil
|
|
}
|
|
|
|
func createAndStartStatusNode(config *params.NodeConfig) (*StatusNode, error) {
|
|
statusNode := New(nil, tt.MustCreateTestLogger())
|
|
|
|
appDB, walletDB, stop, err := setupTestDBs()
|
|
defer func() {
|
|
err := stop()
|
|
if err != nil {
|
|
statusNode.logger.Error("stopping db", zap.Error(err))
|
|
}
|
|
}()
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
statusNode.appDB = appDB
|
|
statusNode.walletDB = walletDB
|
|
|
|
ma, stop2, err := setupTestMultiDB()
|
|
defer func() {
|
|
err := stop2()
|
|
if err != nil {
|
|
statusNode.logger.Error("stopping multiaccount db", zap.Error(err))
|
|
}
|
|
}()
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
statusNode.multiaccountsDB = ma
|
|
|
|
err = statusNode.Start(config, nil)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
return statusNode, nil
|
|
}
|
|
|
|
func createStatusNode() (*StatusNode, func() error, func() error, error) {
|
|
appDB, walletDB, stop1, err := setupTestDBs()
|
|
if err != nil {
|
|
return nil, nil, nil, err
|
|
}
|
|
statusNode := New(nil, tt.MustCreateTestLogger())
|
|
statusNode.SetAppDB(appDB)
|
|
statusNode.SetWalletDB(walletDB)
|
|
|
|
ma, stop2, err := setupTestMultiDB()
|
|
statusNode.SetMultiaccountsDB(ma)
|
|
|
|
return statusNode, stop1, stop2, err
|
|
}
|
|
|
|
func TestNodeRPCClientCallOnlyPublicAPIs(t *testing.T) {
|
|
var err error
|
|
|
|
statusNode, err := createAndStartStatusNode(¶ms.NodeConfig{
|
|
APIModules: "", // no whitelisted API modules; use only public APIs
|
|
WakuConfig: params.WakuConfig{
|
|
Enabled: true,
|
|
},
|
|
})
|
|
require.NoError(t, err)
|
|
defer func() {
|
|
err := statusNode.Stop()
|
|
require.NoError(t, err)
|
|
}()
|
|
|
|
client := statusNode.RPCClient()
|
|
require.NotNil(t, client)
|
|
|
|
// call public API with public RPC Client
|
|
result, err := statusNode.CallRPC(`{"jsonrpc": "2.0", "id": 1, "method": "eth_uninstallFilter", "params": ["id"]}`)
|
|
require.NoError(t, err)
|
|
|
|
// the call is successful
|
|
require.False(t, strings.Contains(result, "error"))
|
|
|
|
result, err = statusNode.CallRPC(`{"jsonrpc": "2.0", "id": 1, "method": "waku_info"}`)
|
|
require.NoError(t, err)
|
|
|
|
// call private API with public RPC client
|
|
require.Equal(t, ErrRPCMethodUnavailable, result)
|
|
|
|
}
|
|
|
|
func TestNodeRPCPrivateClientCallPrivateService(t *testing.T) {
|
|
var err error
|
|
|
|
statusNode, err := createAndStartStatusNode(¶ms.NodeConfig{
|
|
WakuConfig: params.WakuConfig{
|
|
Enabled: true,
|
|
},
|
|
})
|
|
require.NoError(t, err)
|
|
defer func() {
|
|
err := statusNode.Stop()
|
|
require.NoError(t, err)
|
|
}()
|
|
|
|
result, err := statusNode.CallPrivateRPC(`{"jsonrpc": "2.0", "id": 1, "method": "waku_info"}`)
|
|
require.NoError(t, err)
|
|
|
|
// the call is successful
|
|
require.False(t, strings.Contains(result, "error"))
|
|
|
|
_, err = statusNode.CallPrivateRPC(`{"jsonrpc": "2.0", "id": 1, "method": "settings_getSettings"}`)
|
|
require.NoError(t, err)
|
|
}
|