mirror of
https://github.com/status-im/status-go.git
synced 2025-01-09 22:26:30 +00:00
89251e8416
* Added community sync protobuf * Updated community sync send logic * Integrated syncCommunity handling * Added synced_at field and tidied up some other logic * persistence testing * Added testing and join functionality * Fixed issue with empty scan params * Finshed persistence tests for new db funcs * Midway debug of description not persisting after sync * Resolved final issues and tidied up * Polish * delint * Fix error not handled on SetPrivateKey * fix infinite loop, again * Added muted option and test fix * Added Muted to syncing functions, not just in persistence * Fix bug introduced with Muted property * Added a couple of notes for future devs * Added most of the sync RequestToJoin functionality Tests need to be completed and tests are giving some errors * Finished tests for getJoinedAndPending * Added note * Resolving lint * Fix of protobuf gen bug * Fixes to community sync tests * Fixes to test * Continued fix of e2e * Final fix to e2e testing * Updated migration position * resolve missing import * Apparently the linter spellchecks * Fix bug from #2276 merge * Bug fix for leaving quirkiness * Addressed superfluous MessengerResponse field * Addressed feedback * VERSION bump
How to write migrations?
We only write up
migrations, down
migrations are not always possible in sqlite or
too complex/too expensive. For example to remove a column you would have to duplicate
the table, copy over the data, delete and recreated.
This can be very expensive for some tables (user_messages for example), so should not be attempted.
Notes
One issue we faced multiple times is that updates to user_messages
can be very
expensive, leading to slow upgrade times and interrupted migrations. So avoid
writes if not necessary.