status-go/_assets/patches/geth
Dmitry Shulyak 707221954f
Make whisper tolerant to local time skews (#864)
This change adds adds an ability to use different source of time for whisper:

when envelope is created it is used to set expiry
to track when envelope needs to be expired
This time is then used to check validity of the envelope when it is received. Currently If we receive an envelope that is sent from future - peer will get disconnected. If envelope that was received has an expiry less then now it will be simply dropped, if expiry is less than now + 10*2 seconds peer will get dropped.

So, it is clear that whisper depends on time. And any time we get a skew with peers that is > 20s reliability will be grealy reduced.

In this change another source of time for whisper will be used. This time source will use ntp servers from pool.ntp.org to compute offset. When whisper queries time - this offset will be added/substracted from current time.

Query is executed every 2 mins, queries 5 different servers, cut offs min and max and the computes mean value. pool.ntp.org is resolved to different servers and according to documentation you will rarely hit the same.

Closes: #687
2018-05-04 11:23:38 +03:00
..
0000-accounts-hd-keys.patch Move non-go related files to the `_assets` folder. #621 (#630) 2018-02-09 14:38:18 +01:00
0010-geth-17-fix-npe-in-filter-system.patch Fix a couple of patches where new files are created so that new files are marked as such 2018-02-12 15:56:03 +01:00
0014-whisperv6-notifications.patch Add `shhext_getNewFilterMessages` function to RPC APIs. 2018-04-27 15:24:37 +02:00
0015-whisperv6-envelopes-tracing.patch Update go-ethereum to 1.8.5 (#854) 2018-04-24 18:50:26 +03:00
0016-fix-leveldb-issue.patch Add patch to fix race condition in `Downloader.Cancel` 2018-05-01 16:29:27 +02:00
0020-discv5-metrics.patch Update go-ethereum to 1.8.5 (#854) 2018-04-24 18:50:26 +03:00
0021-backends-simulated-chain-signer.patch Use chain aware signer in simulated backend 2018-04-09 14:41:50 +03:00
0022-node-attach-public.patch Update go-ethereum to 1.8.5 (#854) 2018-04-24 18:50:26 +03:00
0023-extract-personal-sign-api.patch Implement `personal_sign`. 2018-04-17 11:18:58 +02:00
0025-whisper-confirmations.patch Update go-ethereum to 1.8.5 (#854) 2018-04-24 18:50:26 +03:00
0026-ethdb-error-deadlock.patch Fix race condition in `LDBDatabase.Close()` 2018-05-03 20:39:42 +03:00
0027-whisper-time-source.patch Make whisper tolerant to local time skews (#864) 2018-05-04 11:23:38 +03:00
README.md Update go-ethereum to 1.8.5 (#854) 2018-04-24 18:50:26 +03:00

README.md

Status Patches for geth (go-ethereum)


Status-go uses go-ethereum (upstream) as its dependency. As any other Go dependency go-ethereum code is vendored and stored in vendor/ folder.

However, there are a few changes has been made to the upstream, that are specific to Status and should not be merged to the upstream. We keep those changes as a set of patches, that can be applied upon each next release of go-ethereum. Patched version of go-ethereum is available in vendor folder.

We try to minimize number and amount of changes in those patches as much as possible, and whereas possible, to contribute changes into the upstream.

Creating patches

Instructions for creating a patch from the command line:

  1. Enter the command line at the go-ethereum dependency root in vendor folder.
  2. Create the patch:
    1. If you already have a commit that represents the change, find its SHA1 (e.g. $COMMIT_SHA1) and do git diff $COMMIT_SHA1 > file.patch
    2. If the files are staged, do git diff --cached > file.patch

Updating patches

  1. Tweak the patch file.
  2. Run make dep-ensure to re-apply patches.

Removing patches

  1. Remove the patch file
  2. Remove the link from [this README] (./README.md)
  3. Run make dep-ensure to re-apply patches.

Updating

When a new stable release of go-ethereum comes out, we need to upgrade our vendored copy. We use dep for vendoring, so for upgrading:

  • Change target branch for go-ethereum in Gopkg.toml.
  • dep ensure -update github.com/ethereum/go-ethereum
  • make dep-ensure

This will ensure that dependency is upgraded and fully patched. Upon success, you can do make vendor-check after committing all the changes, in order to ensure that all changes are valid.