6fa8c11382
This is the initial implementation for the new URL unfurling requirements. The most important one is that only the message sender will pay the privacy cost for unfurling and extracting metadata from websites. Once the message is sent, the unfurled data will be stored at the protocol level and receivers will just profit and happily decode the metadata to render it. Further development of this URL unfurling capability will be mostly guided by issues created on clients. For the moment in status-mobile: https://github.com/status-im/status-mobile/labels/url-preview - https://github.com/status-im/status-mobile/issues/15918 - https://github.com/status-im/status-mobile/issues/15917 - https://github.com/status-im/status-mobile/issues/15910 - https://github.com/status-im/status-mobile/issues/15909 - https://github.com/status-im/status-mobile/issues/15908 - https://github.com/status-im/status-mobile/issues/15906 - https://github.com/status-im/status-mobile/issues/15905 ### Terminology In the code, I've tried to stick to the word "unfurl URL" to really mean the process of extracting metadata from a website, sort of lower level. I use "link preview" to mean a higher level structure which is enriched by unfurled data. "link preview" is also how designers refer to it. ### User flows 1. Carol needs to see link previews while typing in the chat input field. Notice from the diagram nothing is persisted and that status-go endpoints are essentially stateless. ``` #+begin_src plantuml :results verbatim Client->>Server: Call wakuext_getTextURLs Server-->>Client: Normalized URLs Client->>Client: Render cached unfurled URLs Client->>Server: Unfurl non-cached URLs.\nCall wakuext_unfurlURLs Server->>Website: Fetch metadata Website-->>Server: Metadata (thumbnail URL, title, etc) Server->>Website: Fetch thumbnail Server->>Website: Fetch favicon Website-->>Server: Favicon bytes Website-->>Server: Thumbnail bytes Server->>Server: Decode & process images Server-->>Client: Unfurled data (thumbnail data URI, etc) #+end_src ``` ``` ,------. ,------. ,-------. |Client| |Server| |Website| `--+---' `--+---' `---+---' | Call wakuext_getTextURLs | | | ---------------------------------------> | | | | | Normalized URLs | | | <- - - - - - - - - - - - - - - - - - - - | | | | |----. | | | | Render cached unfurled URLs | | |<---' | | | | | | Unfurl non-cached URLs. | | | Call wakuext_unfurlURLs | | | ---------------------------------------> | | | | | | Fetch metadata | | | ------------------------------------> | | | | | Metadata (thumbnail URL, title, etc)| | | <- - - - - - - - - - - - - - - - - - | | | | | Fetch thumbnail | | | ------------------------------------> | | | | | Fetch favicon | | | ------------------------------------> | | | | | Favicon bytes | | | <- - - - - - - - - - - - - - - - - - | | | | | Thumbnail bytes | | | <- - - - - - - - - - - - - - - - - - | | | | |----. | | | | Decode & process images | | |<---' | | | | | Unfurled data (thumbnail data URI, etc)| | | <- - - - - - - - - - - - - - - - - - - - | ,--+---. ,--+---. ,---+---. |Client| |Server| |Website| `------' `------' `-------' ``` 2. Carol sends the text message with link previews in the RPC request wakuext_sendChatMessages. status-go assumes the link previews are good because it can't and shouldn't attempt to re-unfurl them. ``` #+begin_src plantuml :results verbatim Client->>Server: Call wakuext_sendChatMessages Server->>Server: Transform link previews to\nbe proto-marshalled Server->DB: Write link previews serialized as JSON Server-->>Client: Updated message response #+end_src ``` ``` ,------. ,------. ,--. |Client| |Server| |DB| `--+---' `--+---' `+-' | Call wakuext_sendChatMessages| | | -----------------------------> | | | | | |----. | | | | Transform link previews to | | |<---' be proto-marshalled | | | | | | | | | Write link previews serialized as JSON| | | --------------------------------------> | | | | Updated message response | | | <- - - - - - - - - - - - - - - | ,--+---. ,--+---. ,+-. |Client| |Server| |DB| `------' `------' `--' ``` 3. The message was sent over waku and persisted locally in Carol's device. She should now see the link previews in the chat history. There can be many link previews shared by other chat members, therefore it is important to serve the assets via the media server to avoid overloading the ReactNative bridge with lots of big JSON payloads containing base64 encoded data URIs (maybe this concern is meaningless for desktop). When a client is rendering messages with link previews, they will have the field linkPreviews, and the thumbnail URL will point to the local media server. ``` #+begin_src plantuml :results verbatim Client->>Server: GET /link-preview/thumbnail (media server) Server->>DB: Read from user_messages.unfurled_links Server->Server: Unmarshal JSON Server-->>Client: HTTP Content-Type: image/jpeg/etc #+end_src ``` ``` ,------. ,------. ,--. |Client| |Server| |DB| `--+---' `--+---' `+-' | GET /link-preview/thumbnail (media server)| | | ------------------------------------------> | | | | | | Read from user_messages.unfurled_links| | | --------------------------------------> | | | | |----. | | | | Unmarshal JSON | | |<---' | | | | | HTTP Content-Type: image/jpeg/etc | | | <- - - - - - - - - - - - - - - - - - - - - | ,--+---. ,--+---. ,+-. |Client| |Server| |DB| `------' `------' `--' ``` ### Some limitations of the current implementation The following points will become separate issues in status-go that I'll work on over the next couple weeks. In no order of importance: - Improve how multiple links are fetched; retries on failure and testing how unfurling behaves around the timeout limits (deterministically, not by making real HTTP calls as I did). https://github.com/status-im/status-go/issues/3498 - Unfurl favicons and store them in the protobuf too. - For this PR, I added unfurling support only for websites with OpenGraph https://ogp.me/ meta tags. Other unfurlers will be implemented on demand. The next one will probably be for oEmbed https://oembed.com/, the protocol supported by YouTube, for example. - Resize and/or compress thumbnails (and favicons). Often times, thumbnails are huge for the purposes of link previews. There is already support for compressing JPEGs in status-go, but I prefer to work with compression in a separate PR because I'd like to also solve the problem for PNGs (probably convert them to JPEGs, plus compress them). This would be a safe choice for thumbnails, favicons not so much because transparency is desirable. - Editing messages is not yet supported. - I haven't coded any artificial limit on the number of previews or on the size of the thumbnail payload. This will be done in a separate issue. I have heard the ideal solution may be to split messages into smaller chunks of ~125 KiB because of libp2p, but that might be too complicated at this stage of the product (?). - Link preview deletion. - For the moment, OpenGraph metadata is extracted by requesting data for the English language (and fallback to whatever is available). In the future, we'll want to unfurl by respecting the user's local device language. Some websites, like GoDaddy, are already localized based on the device's IP, but many aren't. - The website's description text should be limited by a certain number of characters, especially because it's outside our control. Exactly how much has not been decided yet, so it'll be done separately. - URL normalization can be tricky, so I implemented only the basics to help with caching. For example, the url https://status.im and HTTPS://status.im are considered identical. Also, a URL is considered valid for unfurling if its TLD exists according to publicsuffix.EffectiveTLDPlusOne. This was essential, otherwise the default Go url.Parse approach would consider many invalid URLs valid, and thus the server would waste resources trying to unfurl the unfurleable. ### Other requirements - If the message is edited, the link previews should reflect the edited text, not the original one. This has been aligned with the design team as well. - If the website's thumbnail or the favicon can't be fetched, just ignore them. The only mandatory piece of metadata is the website's title and URL. - Link previews in clients should be generated in near real-time, that is, as the user types, previews are updated. In mobile this performs very well, and it's what other clients like WhatsApp, Telegram, and Facebook do. ### Decisions - While the user typing in the input field, the client is constantly (debounced) asking status-go to parse the text and extract normalized URLs and then the client checks if they're already in its in-memory cache. If they are, no RPC call is made. I chose this approach to achieve the best possible performance in mobile and avoid the whole RPC overhead, since the chat experience is already not smooth enough. The mobile client uses URLs as cache keys in a hashmap, i.e. if the key is present, it means the preview is readily available (naive, but good enough for now). This decision also gave me more flexibility to find the best UX at this stage of the feature. - Due to the requirement that users should be able to see independent loading indicators for each link preview, when status-go can't unfurl a URL, it doesn't return it in the response. - As an initial implementation, I added the BLOB column unfurled_links to the user_messages table. The preview data is then serialized as JSON before being stored in this column. I felt that creating a separate table and the related code for this initial PR would be inconvenient. Is that reasonable to you? Once things stabilize I can create a proper table if we want to avoid this kind of solution with serialized columns. |
||
|---|---|---|
| .. | ||
| 000001_init.down.db.sql | ||
| 000001_init.up.db.sql | ||
| 000002_add_last_ens_clock_value.up.sql | ||
| 1586358095_add_replace.up.sql | ||
| 1588665364_add_image_data.up.sql | ||
| 1589365189_add_pow_target.up.sql | ||
| 1591277220_add_index_messages.up.sql | ||
| 1593087212_add_mute_chat_and_raw_message_fields.up.sql | ||
| 1595862781_add_audio_data.up.sql | ||
| 1595865249_create_emoji_reactions_table.up.sql | ||
| 1596805115_create_group_chat_invitations_table.up.sql | ||
| 1597322655_add_invitation_admin_chat_field.up.sql | ||
| 1597757544_add_nickname.up.sql | ||
| 1598955122_add_mentions.up.sql | ||
| 1599641390_add_emoji_reactions_index.up.sql | ||
| 1599720851_add_seen_index_remove_long_messages.up.sql | ||
| 1603198582_add_profile_chat_field.up.sql | ||
| 1603816533_add_links.up.sql | ||
| 1603888149_create_chat_identity_last_published_table.up.sql | ||
| 1605075346_add_communities.up.sql | ||
| 1610117927_add_message_cache.up.sql | ||
| 1610959908_add_dont_wrap_to_raw_messages.up.sql | ||
| 1610960912_add_send_on_personal_topic.up.sql | ||
| 1612870480_add_datasync_id.up.sql | ||
| 1614152139_add_communities_request_to_join.up.sql | ||
| 1615374373_add_confirmations.up.sql | ||
| 1617694931_add_notification_center.up.sql | ||
| 1618923660_create_pin_messages.up.sql | ||
| 1619094007_add_joined_chat_field.up.sql | ||
| 1619099821_add_last_synced_field.up.sql | ||
| 1621933219_add_mentioned.up.sql | ||
| 1622010048_add_unviewed_mentions_count.up.sql | ||
| 1622061278_add_message_activity_center_notification_field.up.sql | ||
| 1622464518_set_synced_to_from.up.sql | ||
| 1622464519_add_chat_description.up.sql | ||
| 1622622253_add_pinned_by_to_pin_messages.up.sql | ||
| 1623938329_add_author_activity_center_notification_field.up.sql | ||
| 1623938330_add_edit_messages.up.sql | ||
| 1624978434_add_muted_community.up.sql | ||
| 1625018910_add_repply_message_activity_center_notification_field.up.sql | ||
| 1625762506_add_deleted_messages.up.sql | ||
| 1627388946_add_communities_synced_at.up.sql | ||
| 1628280060_create-usermessages-index.sql | ||
| 1632303896_modify_contacts_table.up.sql | ||
| 1633349838_add_emoji_column_in_chats.up.sql | ||
| 1634831235_add_highlight_column_in_chats.up.sql | ||
| 1634896007_add_last_updated_locally_and_removed.up.sql | ||
| 1635840039_add_clock_read_at_column_in_chats.up.sql | ||
| 1637852321_add_received_invitation_admin_column_in_chats.up.sql | ||
| 1645034601_display_name.up.sql | ||
| 1645034602_add_mutual_contact_request.up.sql | ||
| 1650373957_add_contact_request_state.up.sql | ||
| 1656958989_contact_verification.up.sql | ||
| 1658236268_add_discord_message_authors_table.up.sql | ||
| 1659619997_add_discord_messages_table.up.sql | ||
| 1660226788_create_chat_identity_social_links.up.sql | ||
| 1660226789_add_walletconnectsessions_table.up.sql | ||
| 1661242854_add_communities_requests_to_leave.up.sql | ||
| 1662044232_add_chat_image.up.sql | ||
| 1662106895_add_chat_first_message_timestamp.up.sql | ||
| 1662723928_add_discord_author_image_fields.up.sql | ||
| 1664195977_add_deleted_for_mes.up.sql | ||
| 1664367420_add_discord_attachments_table.up.sql | ||
| 1665079662_add_spectated_column_in_communities.up.sql | ||
| 1665479047_add_community_id_in_notifications.up.sql | ||
| 1665484435_add_encrypted_messages.up.sql | ||
| 1665560200_add_contact_verification_individual.up.sql | ||
| 1670921937_add_album_id.up.sql | ||
| 1673373000_add_replied.up.sql | ||
| 1673428910_add_image_width_height.up.sql | ||
| 1674210659_add_contact_request_local_clock.up.sql | ||
| 1675212323_add_deleted_by.up.sql | ||
| 1675247084_add_activity_center_states.up.sql | ||
| 1675272329_fix_protocol_migration.up.sql | ||
| 1676998418_fix_activity_center_migration.up.sql | ||
| 1677278861_add_deleted_column_to_activity_center_notifications_table.up.sql | ||
| 1677486338_add_community_tokens_table.up.sql | ||
| 1678292329_add_collapsed_categories.up.sql | ||
| 1678800760_add_index_to_raw_messages.up.sql | ||
| 1678877478_add_communities_requests_to_join_revealed_addresses_table.up.sql | ||
| 1679326850_add_community_token_owners.up.sql | ||
| 1680011500_add_album_images_count.up.sql | ||
| 1680114896_add_index_on_album_id.up.sql | ||
| 1681655289_add_mute_till.up.sql | ||
| 1681934966_add_index_response_to.up.sql | ||
| 1682528339_add_index_user_messages_unseen.up.sql | ||
| 1683707289_recreate_deleted_for_mes.up.sql | ||
| 1683725607_mark_discord_messages_as_seen.up.sql | ||
| 1684174617_add_url_previews_to_user_messages.up.sql | ||
| README.md | ||
| doc.go | ||
README.md
How to write migrations?
We only write up migrations, down migrations are not always possible in sqlite or
too complex/too expensive. For example to remove a column you would have to duplicate
the table, copy over the data, delete and recreated.
This can be very expensive for some tables (user_messages for example), so should not be attempted.
Notes
One issue we faced multiple times is that updates to user_messages can be very
expensive, leading to slow upgrade times and interrupted migrations. So avoid
writes if not necessary.