mirror of
https://github.com/status-im/status-go.git
synced 2025-02-08 12:54:37 +00:00
author shashankshampi <shashank.sanket1995@gmail.com> 1729780155 +0530 committer shashankshampi <shashank.sanket1995@gmail.com> 1730274350 +0530 test: Code Migration from status-cli-tests fix_: functional tests (#5979) * fix_: generate on test-functional * chore(test)_: fix functional test assertion --------- Co-authored-by: Siddarth Kumar <siddarthkay@gmail.com> feat(accounts)_: cherry-pick Persist acceptance of Terms of Use & Privacy policy (#5766) (#5977) * feat(accounts)_: Persist acceptance of Terms of Use & Privacy policy (#5766) The original GH issue https://github.com/status-im/status-mobile/issues/21113 came from a request from the Legal team. We must show to Status v1 users the new terms (Terms of Use & Privacy Policy) right after they upgrade to Status v2 from the stores. The solution we use is to create a flag in the accounts table, named hasAcceptedTerms. The flag will be set to true on the first account ever created in v2 and we provide a native call in mobile/status.go#AcceptTerms, which allows the client to persist the user's choice in case they are upgrading (from v1 -> v2, or from a v2 older than this PR). This solution is not the best because we should store the setting in a separate table, not in the accounts table. Related Mobile PR https://github.com/status-im/status-mobile/pull/21124 * fix(test)_: Compare addresses using uppercased strings --------- Co-authored-by: Icaro Motta <icaro.ldm@gmail.com> test_: restore account (#5960) feat_: `LogOnPanic` linter (#5969) * feat_: LogOnPanic linter * fix_: add missing defer LogOnPanic * chore_: make vendor * fix_: tests, address pr comments * fix_: address pr comments fix(ci)_: remove workspace and tmp dir This ensures we do not encounter weird errors like: ``` + ln -s /home/jenkins/workspace/go_prs_linux_x86_64_main_PR-5907 /home/jenkins/workspace/go_prs_linux_x86_64_main_PR-5907@tmp/go/src/github.com/status-im/status-go ln: failed to create symbolic link '/home/jenkins/workspace/go_prs_linux_x86_64_main_PR-5907@tmp/go/src/github.com/status-im/status-go': File exists script returned exit code 1 ``` Signed-off-by: Jakub Sokołowski <jakub@status.im> chore_: enable windows and macos CI build (#5840) - Added support for Windows and macOS in CI pipelines - Added missing dependencies for Windows and x86-64-darwin - Resolved macOS SDK version compatibility for darwin-x86_64 The `mkShell` override was necessary to ensure compatibility with the newer macOS SDK (version 11.0) for x86_64. The default SDK (10.12) was causing build failures because of the missing libs and frameworks. OverrideSDK creates a mapping from the default SDK in all package categories to the requested SDK (11.0). fix(contacts)_: fix trust status not being saved to cache when changed (#5965) Fixes https://github.com/status-im/status-desktop/issues/16392 cleanup added logger and cleanup review comments changes fix_: functional tests (#5979) * fix_: generate on test-functional * chore(test)_: fix functional test assertion --------- Co-authored-by: Siddarth Kumar <siddarthkay@gmail.com> feat(accounts)_: cherry-pick Persist acceptance of Terms of Use & Privacy policy (#5766) (#5977) * feat(accounts)_: Persist acceptance of Terms of Use & Privacy policy (#5766) The original GH issue https://github.com/status-im/status-mobile/issues/21113 came from a request from the Legal team. We must show to Status v1 users the new terms (Terms of Use & Privacy Policy) right after they upgrade to Status v2 from the stores. The solution we use is to create a flag in the accounts table, named hasAcceptedTerms. The flag will be set to true on the first account ever created in v2 and we provide a native call in mobile/status.go#AcceptTerms, which allows the client to persist the user's choice in case they are upgrading (from v1 -> v2, or from a v2 older than this PR). This solution is not the best because we should store the setting in a separate table, not in the accounts table. Related Mobile PR https://github.com/status-im/status-mobile/pull/21124 * fix(test)_: Compare addresses using uppercased strings --------- Co-authored-by: Icaro Motta <icaro.ldm@gmail.com> test_: restore account (#5960) feat_: `LogOnPanic` linter (#5969) * feat_: LogOnPanic linter * fix_: add missing defer LogOnPanic * chore_: make vendor * fix_: tests, address pr comments * fix_: address pr comments chore_: enable windows and macos CI build (#5840) - Added support for Windows and macOS in CI pipelines - Added missing dependencies for Windows and x86-64-darwin - Resolved macOS SDK version compatibility for darwin-x86_64 The `mkShell` override was necessary to ensure compatibility with the newer macOS SDK (version 11.0) for x86_64. The default SDK (10.12) was causing build failures because of the missing libs and frameworks. OverrideSDK creates a mapping from the default SDK in all package categories to the requested SDK (11.0). fix(contacts)_: fix trust status not being saved to cache when changed (#5965) Fixes https://github.com/status-im/status-desktop/issues/16392 test_: remove port bind chore(wallet)_: move route execution code to separate module chore_: replace geth logger with zap logger (#5962) closes: #6002 feat(telemetry)_: add metrics for message reliability (#5899) * feat(telemetry)_: track message reliability Add metrics for dial errors, missed messages, missed relevant messages, and confirmed delivery. * fix_: handle error from json marshal chore_: use zap logger as request logger iterates: status-im/status-desktop#16536 test_: unique project per run test_: use docker compose v2, more concrete project name fix(codecov)_: ignore folders without tests Otherwise Codecov reports incorrect numbers when making changes. https://docs.codecov.com/docs/ignoring-paths Signed-off-by: Jakub Sokołowski <jakub@status.im> test_: verify schema of signals during init; fix schema verification warnings (#5947) fix_: update defaultGorushURL (#6011) fix(tests)_: use non-standard port to avoid conflicts We have observed `nimbus-eth2` build failures reporting this port: ```json { "lvl": "NTC", "ts": "2024-10-28 13:51:32.308+00:00", "msg": "REST HTTP server could not be started", "topics": "beacnde", "address": "127.0.0.1:5432", "reason": "(98) Address already in use" } ``` https://ci.status.im/job/nimbus-eth2/job/platforms/job/linux/job/x86_64/job/main/job/PR-6683/3/ Signed-off-by: Jakub Sokołowski <jakub@status.im> fix_: create request logger ad-hoc in tests Fixes `TestCall` failing when run concurrently. chore_: configure codecov (#6005) * chore_: configure codecov * fix_: after_n_builds
257 lines
6.0 KiB
Go
257 lines
6.0 KiB
Go
package timesource
|
|
|
|
import (
|
|
"bytes"
|
|
"errors"
|
|
"sort"
|
|
"sync"
|
|
"time"
|
|
|
|
"github.com/beevik/ntp"
|
|
"go.uber.org/zap"
|
|
|
|
"github.com/status-im/status-go/common"
|
|
"github.com/status-im/status-go/logutils"
|
|
)
|
|
|
|
const (
|
|
// DefaultMaxAllowedFailures defines how many failures will be tolerated.
|
|
DefaultMaxAllowedFailures = 4
|
|
|
|
// FastNTPSyncPeriod period between ntp synchronizations before the first
|
|
// successful connection.
|
|
FastNTPSyncPeriod = 2 * time.Minute
|
|
|
|
// SlowNTPSyncPeriod period between ntp synchronizations after the first
|
|
// successful connection.
|
|
SlowNTPSyncPeriod = 1 * time.Hour
|
|
|
|
// DefaultRPCTimeout defines write deadline for single ntp server request.
|
|
DefaultRPCTimeout = 2 * time.Second
|
|
)
|
|
|
|
// defaultServers will be resolved to the closest available,
|
|
// and with high probability resolved to the different IPs
|
|
var defaultServers = []string{
|
|
"time.apple.com",
|
|
"pool.ntp.org",
|
|
"time.cloudflare.com",
|
|
"time.windows.com",
|
|
"ntp.neu.edu.cn",
|
|
"ntp.nict.jp",
|
|
"amazon.pool.ntp.org",
|
|
"android.pool.ntp.org",
|
|
}
|
|
var errUpdateOffset = errors.New("failed to compute offset")
|
|
|
|
type ntpQuery func(string, ntp.QueryOptions) (*ntp.Response, error)
|
|
|
|
type queryResponse struct {
|
|
Offset time.Duration
|
|
Error error
|
|
}
|
|
|
|
type multiRPCError []error
|
|
|
|
func (e multiRPCError) Error() string {
|
|
var b bytes.Buffer
|
|
b.WriteString("RPC failed: ")
|
|
more := false
|
|
for _, err := range e {
|
|
if more {
|
|
b.WriteString("; ")
|
|
}
|
|
b.WriteString(err.Error())
|
|
more = true
|
|
}
|
|
b.WriteString(".")
|
|
return b.String()
|
|
}
|
|
|
|
func computeOffset(timeQuery ntpQuery, servers []string, allowedFailures int) (time.Duration, error) {
|
|
if len(servers) == 0 {
|
|
return 0, nil
|
|
}
|
|
responses := make(chan queryResponse, len(servers))
|
|
for _, server := range servers {
|
|
go func(server string) {
|
|
defer common.LogOnPanic()
|
|
response, err := timeQuery(server, ntp.QueryOptions{
|
|
Timeout: DefaultRPCTimeout,
|
|
})
|
|
if err == nil {
|
|
err = response.Validate()
|
|
}
|
|
if err != nil {
|
|
responses <- queryResponse{Error: err}
|
|
return
|
|
}
|
|
responses <- queryResponse{Offset: response.ClockOffset}
|
|
}(server)
|
|
}
|
|
var (
|
|
rpcErrors multiRPCError
|
|
offsets []time.Duration
|
|
collected int
|
|
)
|
|
for response := range responses {
|
|
if response.Error != nil {
|
|
rpcErrors = append(rpcErrors, response.Error)
|
|
} else {
|
|
offsets = append(offsets, response.Offset)
|
|
}
|
|
collected++
|
|
if collected == len(servers) {
|
|
break
|
|
}
|
|
}
|
|
if lth := len(rpcErrors); lth > allowedFailures {
|
|
return 0, rpcErrors
|
|
} else if lth == len(servers) {
|
|
return 0, rpcErrors
|
|
}
|
|
sort.SliceStable(offsets, func(i, j int) bool {
|
|
return offsets[i] > offsets[j]
|
|
})
|
|
mid := len(offsets) / 2
|
|
if len(offsets)%2 == 0 {
|
|
return (offsets[mid-1] + offsets[mid]) / 2, nil
|
|
}
|
|
return offsets[mid], nil
|
|
}
|
|
|
|
var defaultTimeSource = &NTPTimeSource{
|
|
servers: defaultServers,
|
|
allowedFailures: DefaultMaxAllowedFailures,
|
|
fastNTPSyncPeriod: FastNTPSyncPeriod,
|
|
slowNTPSyncPeriod: SlowNTPSyncPeriod,
|
|
timeQuery: ntp.QueryWithOptions,
|
|
now: time.Now,
|
|
}
|
|
|
|
// Default initializes time source with default config values.
|
|
func Default() *NTPTimeSource {
|
|
return defaultTimeSource
|
|
}
|
|
|
|
// NTPTimeSource provides source of time that tries to be resistant to time skews.
|
|
// It does so by periodically querying time offset from ntp servers.
|
|
type NTPTimeSource struct {
|
|
servers []string
|
|
allowedFailures int
|
|
fastNTPSyncPeriod time.Duration
|
|
slowNTPSyncPeriod time.Duration
|
|
timeQuery ntpQuery // for ease of testing
|
|
now func() time.Time
|
|
|
|
quit chan struct{}
|
|
started bool
|
|
|
|
mu sync.RWMutex
|
|
latestOffset time.Duration
|
|
}
|
|
|
|
// Now returns time adjusted by latest known offset
|
|
func (s *NTPTimeSource) Now() time.Time {
|
|
s.mu.RLock()
|
|
defer s.mu.RUnlock()
|
|
n := s.now()
|
|
return n.Add(s.latestOffset)
|
|
}
|
|
|
|
func (s *NTPTimeSource) updateOffset() error {
|
|
offset, err := computeOffset(s.timeQuery, s.servers, s.allowedFailures)
|
|
if err != nil {
|
|
logutils.ZapLogger().Error("failed to compute offset", zap.Error(err))
|
|
return errUpdateOffset
|
|
}
|
|
logutils.ZapLogger().Info("Difference with ntp servers", zap.Duration("offset", offset))
|
|
s.mu.Lock()
|
|
defer s.mu.Unlock()
|
|
s.latestOffset = offset
|
|
|
|
return nil
|
|
}
|
|
|
|
// runPeriodically runs periodically the given function based on NTPTimeSource
|
|
// synchronization limits (fastNTPSyncPeriod / slowNTPSyncPeriod)
|
|
func (s *NTPTimeSource) runPeriodically(fn func() error, starWithSlowSyncPeriod bool) {
|
|
if s.started {
|
|
return
|
|
}
|
|
|
|
period := s.fastNTPSyncPeriod
|
|
if starWithSlowSyncPeriod {
|
|
period = s.slowNTPSyncPeriod
|
|
}
|
|
s.quit = make(chan struct{})
|
|
go func() {
|
|
defer common.LogOnPanic()
|
|
for {
|
|
select {
|
|
case <-time.After(period):
|
|
if err := fn(); err == nil {
|
|
period = s.slowNTPSyncPeriod
|
|
} else if period != s.slowNTPSyncPeriod {
|
|
period = s.fastNTPSyncPeriod
|
|
}
|
|
|
|
case <-s.quit:
|
|
return
|
|
}
|
|
}
|
|
}()
|
|
}
|
|
|
|
// Start initializes the local offset and starts a goroutine that periodically updates the local offset.
|
|
func (s *NTPTimeSource) Start() {
|
|
if s.started {
|
|
return
|
|
}
|
|
|
|
// Attempt to update the offset synchronously so that user can have reliable messages right away
|
|
err := s.updateOffset()
|
|
if err != nil {
|
|
// Failure to update can occur if the node is offline.
|
|
// Instead of returning an error, continue with the process as the update will be retried periodically.
|
|
logutils.ZapLogger().Error("failed to update offset", zap.Error(err))
|
|
}
|
|
|
|
s.runPeriodically(s.updateOffset, err == nil)
|
|
|
|
s.started = true
|
|
}
|
|
|
|
// Stop goroutine that updates time source.
|
|
func (s *NTPTimeSource) Stop() error {
|
|
if s.quit == nil {
|
|
return nil
|
|
}
|
|
close(s.quit)
|
|
s.started = false
|
|
return nil
|
|
}
|
|
|
|
func (s *NTPTimeSource) GetCurrentTime() time.Time {
|
|
s.Start()
|
|
return s.Now()
|
|
}
|
|
|
|
func (s *NTPTimeSource) GetCurrentTimeInMillis() uint64 {
|
|
return convertToMillis(s.GetCurrentTime())
|
|
}
|
|
|
|
func GetCurrentTime() time.Time {
|
|
ts := Default()
|
|
ts.Start()
|
|
return ts.Now()
|
|
}
|
|
|
|
func GetCurrentTimeInMillis() uint64 {
|
|
return convertToMillis(GetCurrentTime())
|
|
}
|
|
|
|
func convertToMillis(t time.Time) uint64 {
|
|
return uint64(t.UnixNano() / int64(time.Millisecond))
|
|
}
|