mirror of
https://github.com/status-im/status-go.git
synced 2025-01-29 16:06:47 +00:00
Jonathan Rainville
0794edc3db
feat(community)_: add version to image url to let clients update (#6118)
Fixes https://github.com/status-im/status-desktop/issues/16688 Since we use the local image server to show the community image, the URL never changes when we update the image, since it's served using a query string containing the community ID. eg: `https://Localhost:46739/communityDescriptionImages?communityID=0x03c5ece7da362d31199fb02d632f85fdf853af57d89c3204b4d1e90c6ec13bb23c&name=thumbnail` Because of that, the clients cannot know if the image was updated, so they had to force update the image every time, which was inefficient. We discovered this issue when I refactored the community client code in Desktop so that we only update the changed properties of a community instead of reseting the whole thing. The solution I came up with in the PR is to add a `version` to the URL when we detect that the image changed. This let's the clients detect when the image was updated without having to do any extra logic.
…
…
…
…
…
…
…
…
…
…
…
…
Status bindings for go-ethereum
Docs
- How to Build
- How to Contribute
- How to Release
- How to configure status-go
- How to run status-go as HTTP server
Policies
License
Description
Languages
Go
98.6%
Python
0.7%
Shell
0.4%
Makefile
0.1%
Groovy
0.1%