Commit Graph

729 Commits

Author SHA1 Message Date
saledjenic f7821cfc3d
fix_: calculating route for erc721 checks one more call if the function doesn't exist on the contract (#5691)
Old ERC721 contracts do not have  `safeTransferFrom` function, because of that we couldn't estimate the gas
and we couldn't resolve the right route. Now we firstly check for `safeTransferFrom` function which is supported
by ERC721A contracts and if the contract doesn't have it then we do `transferFrom` function call.

Example of ERC721A contract:
- https://etherscan.io/address/0x0024bc1035d30ae229a4712189b32131758cb000#code

Example of ERC721 contract:
- https://etherscan.io/address/0x06012c8cf97bead5deae237070f9587f8e7a266d#code
2024-08-13 16:26:20 +01:00
saledjenic c39baa80d2
chore_: cherry-pick #5658: improvements on resolving nonce (#5690)
* chore_: unused `BuildTx` function removed from the processor interface and types that are implement it

Since the `BuildTx` function is not used anywhere, it's removed from the code.

* fix_: resolving nonce improvements

When the app sends more than a single tx from the same account on the same chain, some
chains do not return appropriate nonce (they do not consider pending txs), because of
that we place more tx with the same nonce, where all but the first one fail.

Changes in this PR keep track of nonces being used in the same sending/bridging flow, which means
for the first tx from the multi txs the app asks the chain for the nonce, and every next nonce is resolved
by incrementing the last used nonce by 1.
2024-08-13 11:17:08 +01:00
dlipicar af0be7ec2f feat(wallet): add split onramp url endpoint (#5656)
* feat(wallet)_: add split onramp url endpoint & fix onrmap url
2024-08-12 13:54:05 +01:00
Anthony Laibe 9c9753f12e fix(wallet)_: return balance when available, do not fail all 2024-08-12 14:08:41 +02:00
dlipicar d4c6734a44
feat(wallet)_: handle paraswap price impact error (#5622) (#5680) 2024-08-09 18:52:53 +01:00
saledjenic c04e0dab4a
feat_: accounts/saved addresses capacity related api endpoints added (#5657)
Added endpoints:
- `RemainingAccountCapacity`
- `RemainingKeypairCapacity`
- `RemainingWatchOnlyAccountCapacity`
- `RmaininngCapacityForSavedAddresses`
2024-08-06 15:40:04 +01:00
Igor Sirotin 8ff95326c4
fix_: conversion from int to string causes code scanning error (#5600) (#5655)
fixes #5599

Co-authored-by: Godfrain Jacques <gkounkou@gmail.com>
2024-08-05 21:06:56 +01:00
Belal Shehab 67373ddbfc
fix(wallet)_: Handle balance fetching errors & fallback to cached values (#5641)
- Return errors from fetchBalancesForChain and GetBalancesAtByChain instead of silently ignoring them.
 - Use cached balances if fetching new data fails, preventing empty wallets and ensuring data consistency.
 - Fixed unit tests that was expecting GetBalancesAtByChain to always return nil error

Closes #15767

Co-authored-by: belalshehab <belal@status.im>
2024-08-05 11:07:54 +01:00
saledjenic bb9f14233c
fix_: the last known route with positive balance returned if no route without balance/bonder error (#5648)
The Router algorithm is checking all the routes in order to find one the user has a balance to execute it
even that one is not the cheapest one. But if the user has some balances, but not enough to execute any
of suggested routes, we we're returning the last route which was checked, with the changes from this commit
we will return the last route for which the user has some balance, but not enough.
2024-08-02 18:57:08 +01:00
saledjenic ca25be4516
fix(wallet)_: fixed error with parsing coingecko response. (#5650)
For tokens that it does not support and some that were listed in mapping
we responded with error

Co-authored-by: Ivan Belyakov <ivan.belyakov.job@gmail.com>
2024-08-02 18:56:16 +01:00
Icaro Motta a57055f43b
fix(wallet)_: fix provider down event happening too often (#5595) (#5649)
* fix(wallet)_: fix provider down event happening too often

- handle context cancelled error
- do not count expected errors when calling tokenURI as providers
  errors
- use archival not for optimism (was silently added by Grove makeing the
  old URL non-archival)

Closes #5555

* test(wallet)_: add test for collectibles manager to verify that main
circuit is not tripped calling by tokenURI method

Co-authored-by: IvanBelyakoff <ivan.belyakov.job@gmail.com>
2024-08-01 19:29:05 -03:00
IvanBelyakoff e16d820ecd
chore_: CHERRY-PICK Proxy URLs for blockchain providers (#5644)
* feat(wallet)_: add basic auth for cryptocompare proxy (#5536)

* feat(wallet)_: add basic auth for cryptocompare proxy

* test(wallet)_: add a test for httpclient used in market clients

* feat(wallet)_: add status proxy RPC urls for blockchain providers

Replace the status proxy URL for cryptocompare.
2024-08-01 10:06:34 +01:00
saledjenic 8dcaf21576
chore_: endpoint for checking address checksum validity added to wallet api (#5632)
- added `IsChecksumValidForAddress` function to `wallet` api
2024-07-31 17:25:13 -03:00
saledjenic dca591f39a
feat_: added new error which will be returned in case bonder fee is higher than the amount being sent (#5637) 2024-07-31 18:25:07 +01:00
saledjenic 82b63ccf29
chore_: needed router changes (#5620)
* fix_: setting best route only when we have it

* chore_: when returning errors, give precedence to custom (network) errors

* chore_: skip flaky tests (#5606)

* chore_: skip TestPeerCount

* chore_: skip flaky wallet tests

* chore_: skip flaky TestMemberReceivesPendingRequestToJoinAfterAfterGettingTokenMasterRole

* test_: flaky router tests fixed

Closes https://github.com/status-im/status-go/issues/5601

---------

Co-authored-by: Igor Sirotin <sirotin@status.im>
2024-07-29 18:03:13 +01:00
Icaro Motta 3ca29b87c3
chore_: cherry-pick PRs #5581 #5557 (#5596)
* fix(Wallet)_: Add quotes around token symbol in insufficient balance error messages to ensure valid JSON parsing

* feat_: migrate v1 keycard account (#5557)

---------

Co-Authored-By: belalshehab <belal@status.im>
Co-Authored-By: flexsurfer <flexsurfer@users.noreply.github.com>
2024-07-28 23:22:47 +05:30
Igor Sirotin 0e579fbd01
fix_: tests (#5585) (#5588)
* fix_: router tests errors sprintf

* chore_: skip flaky tests
2024-07-26 10:46:38 +01:00
saledjenic 2bbdb35f6c
Added improvements in resolving the best route (#5569)
* fix_: filtering out routes which do not match the amount in

* fix_: finding the best route logic updated

* fix_: "to" chains being used in sending bridge tx via hop are more explicit

Using `ChainIDTo` depicts better an intention which chain should be used.

* chore_: checking for required balance improved

An error contains now more details, for which token on which chain there is not enough balance for
executing a tx. Also check for required balance now calculates in fees for all tx that possibly can be
sent from the same chain.
2024-07-25 08:15:30 -04:00
dlipicar 0456dcef8b
fix(wallet)_: exclude paraswap providers not supporting partner fees (#5573) 2024-07-24 16:29:54 -04:00
Dario Gabriel Lipicar 7c4b43b4d9 feat(wallet)_: incorporate partner fees for L1 paraswap swaps 2024-07-23 15:27:43 -03:00
Sale Djenic 4d2d20cff4 fix_: allow sending 0 value transactions 2024-07-23 18:19:10 +02:00
Dario Gabriel Lipicar 67890853bf feat_: add support for approve and swap activity entries 2024-07-22 18:29:13 -03:00
Dario Gabriel Lipicar afc6e7bcb9 feat(router)_: return processor error when no routes are found 2024-07-19 17:44:08 +02:00
Dario Gabriel Lipicar 6a155bc6dc feat_: add Mercuryio widget id 2024-07-19 09:03:15 -03:00
Stefan dc62171219 fix(dapps)_: don't require chain ID for signing typed data v4
The reused implementation from signing typed data V1 was used
in case of signing typed data V4. This implementation required
chain ID to be present in the typed data. This change fixes
the issue by making chainID optional for signing typed data V4.
2024-07-19 09:00:01 +02:00
Ivan Belyakov d07f9b5b16 fix(wallet)_: no balance chart for tokens, due to wrong symbol (ETH) used
instead.

Fixed padding points being removed from final result, regression.
Edge points not added per address as it does not make sense.
Fixed padding points number with respect to edge points number.
Padding points now duplicate previous entry.
Fixed timestamp boundaries to ignore addresses, as we want the whole
range for all passed addresses.
Fixed missing indices in balance_history table and clean up of
duplicate rows.
Removed ERC1155 from balance history sql query
2024-07-18 13:11:02 +02:00
Emil Sawicki eac07af5d7 fix(activity)_: Remove duplicated ids for nft fetching 2024-07-17 12:20:35 +02:00
Emil Sawicki 89f1feade0 fix(activity)_: report other token types than ERC20
This fixes incremental updates for tokens and proper report of
token type for mobile (in desktop we didn't use it)

Closes: #15233
2024-07-17 12:20:35 +02:00
Emil Sawicki 094d26dc66 fix_: Add pending tx for collectibles 2024-07-15 13:00:21 +01:00
Dario Gabriel Lipicar 21101c9444 feat(wallet)!: return routerV2 suggested routes whenever available, on top of error if the best route doesn't pass all checks 2024-07-12 17:59:41 -03:00
Andrea Maria Piana 9a59d6a459 feat(metrics)_: add centralized metrics
This commit adds support for centralized metrics.
There are two providers as of now, and we haven't quite decided which
one to go for, so for the time being both are supported.
It also introduces a new endpoint InitializeApplication that replaces
OpenAccounts
2024-07-11 10:05:31 +01:00
Emil Sawicki b2e5e7a81c feat(wallet)_: Remove deprecated for estimated time api 2024-07-09 14:39:52 +02:00
Stefan 5336c47f1b feat(dapps)_: extend and improve sign
Add `wallet_SafeSignTypedDataForDApps` with support for
`eth_signTypedData` and `eth_signTypedData_v4`
Reject if the chain to sign doesn't matches the target chain
for typed data signing

Add `wallet_HashMessageForSigning` with to support hashing messages
for signing in a safe way as per EIP-191 v45 and supporting
to hash messages for signing on the client side (keycard)

Deprecate `wallet_SignTypedDataV4``

Updates: #15361
2024-07-09 09:01:36 +02:00
Sale Djenic 378e5741b9 feat_: the router - add candidates, as potential paths, by taking the max amount on enabled chains 2024-07-05 14:51:34 +02:00
Ivan Belyakov 4b19845592 chore(wallet)_: Added a test for Market manager FetchTokenMarketValues
Added a nil/empty command test for circuit breaker
2024-07-05 12:39:19 +01:00
Ivan Belyakov a009855bbb feat(wallet)_: use CircuitBreaker for blockhain RPC calls
fix usage of circuit breaker for collectibles and market data to
match the implementation
2024-07-05 12:39:19 +01:00
Ivan Belyakov 23b185ae2b fix(wallet)_: fixed some errors handling that caused provider up/down
banner
2024-07-05 13:35:44 +02:00
Anthony Laibe abb570dd3f fix_: l1 fees at 0 and fix base fees sepolia 2024-07-05 11:04:29 +02:00
Ivan Belyakov 3983114ae5 test(wallet)_: add unit tests for balance fetcher
replace types with interfaces where necessary to allow mocking
implement fake eth scanner and erc20 contracts
2024-07-04 09:29:49 +02:00
Ivan Belyakov d180e19fa8 test(wallet)_: moved all balance related code from token.Manager to
balance_fetcher.BalanceFetcher

Split methods into smaller ones for testability
2024-07-04 09:29:49 +02:00
Anthony Laibe 135ab9a5cf chore_: add missing token 2024-07-04 09:28:18 +02:00
belalshehab 1e0a24f1b8 fix(wallet)_: use consistent invalid timestamp constant
- Replaced `unknownUpdateTimestamp` with `InvalidTimestamp` to maintain consistency.
2024-07-04 02:22:01 +03:00
belalshehab f98c411b32 feat(wallet)_: add new API to restart the wallet reload timer
- Added `restartWalletReloadTimer` method in `api.go` to expose an API for restarting the wallet reload timer.
- Implemented `Restart` method in `reader.go` to stop and start the wallet reader.
- Updated reader_test.go to comply with minimum test coverage threshold
2024-07-03 20:36:17 +03:00
Samuel Hawksby-Robinson 5f666e6ad9 test(router_validation)_: blended my validation with latest develop 2024-07-03 11:47:04 +01:00
Samuel Hawksby-Robinson 3c1326be48 test(router_validation)_: Resolved invalid recursive type aliasing
Additionally I've resolved a panic when AmountIn and/or AmountOut is nil
2024-07-03 11:47:04 +01:00
Samuel Hawksby-Robinson 59853fdbe2 test(router_validation)_: integrated the new errors into test loigc 2024-07-03 11:47:04 +01:00
Samuel Hawksby-Robinson e4420533d6 test(router_validation)_: removed error consts, see #5362 2024-07-03 11:47:04 +01:00
Samuel Hawksby-Robinson da2af02049 test(router_validation)_: Added test cases for Sticker and Swaps 2024-07-03 11:47:04 +01:00
Samuel Hawksby-Robinson cdaca322d0 test(router_validation)_: Added Error consts for all tested paths 2024-07-03 11:47:04 +01:00
Samuel Hawksby-Robinson 79d0d08cfd test(router_validation)_: Added full test cases for validateInputData 2024-07-03 11:47:04 +01:00