Commit Graph

3125 Commits

Author SHA1 Message Date
Ivan Tomilov 004aa83d84 Remove unnecessary return 2017-10-26 22:36:45 +03:00
Alexander Ewetumo 7a2c7651db Skip does not need return 2017-10-26 20:10:34 +01:00
Alexander Ewetumo df2100bf49 Update readme 2017-10-26 20:05:12 +01:00
Alexander Ewetumo f0c992974c Add network id to make file 2017-10-26 20:03:53 +01:00
Ivan Tomilov 2897f0ec0f Merge pull request #390 from status-im/issue/refactor-api-notify-send-messages-#342
Refactor and little bit clean up Notify api:

Created interface and package "notification" and extracted related code into it
Set dependencies into constructor notificatotion.Manager
Mocks for notificatotion.Manager and FCMClient
Bacis unit tests for Notify and Send
Notify func is now deprecated
Notify users uses new API: message, Payload and a list of tokens
2017-10-26 20:54:12 +03:00
Alexander Ewetumo 61c277cccd Revise to seperate go test commands 2017-10-26 16:52:48 +01:00
Alexander Ewetumo 8145412d1c Ensure to return err for nil RPCCLient 2017-10-26 14:25:38 +01:00
Alexander Ewetumo efa10134e8 Fixing missing imports 2017-10-26 14:14:11 +01:00
Alexander Ewetumo 1cc90541da Update makefiles and make changes regards review 2017-10-26 14:11:24 +01:00
Ivan Tomilov 34e851a57f Merge pull request #425 from status-im/feature/pull-request-template
Introduce a simple pull request template which sets pull request format and forces people expound their changes structurally.
2017-10-26 15:35:39 +03:00
Alexander Ewetumo 681a2d2d83 Skip test requiring network url for statuschain 2017-10-26 13:33:42 +01:00
Ivan Tomilov 55b10483be Merge pull request #436 from status-im/bugfix/fix-linter-435
Fixes all make lint errors and warning across the whole project.
2017-10-26 14:34:46 +03:00
Adam Babik 71c259dd95 turn off vet shadow 2017-10-26 13:10:56 +02:00
Adam Babik d058b9105a remove goimports 2017-10-26 12:50:30 +02:00
Adam Babik 8cbd7ed1c4 fix linter across the whole project 2017-10-26 12:20:16 +02:00
Alexander Ewetumo 41d883a564 Update makefile with network flag for needed test and fix failing tests 2017-10-25 23:36:47 +01:00
Alexander Ewetumo e80768a090 Swap GetNetworkIDHash/GetHeadHashForNetworkID 2017-10-25 23:24:01 +01:00
Alexander Ewetumo 8207a2724d Update usage of direct network id 2017-10-25 23:09:27 +01:00
Alexander Ewetumo 4d356e0873 Update regards review 2017-10-25 23:07:50 +01:00
Ivan Tomilov 8275391c09 Merge pull request #419 from status-im/feature/linter-in-travis
Divided Travis integration into stages: lint, unit tests, e2e tests
2017-10-25 16:37:20 +03:00
Ivan Tomilov 53cea066e7 Fix duplicate lint 2017-10-25 16:36:03 +03:00
Alexander Ewetumo ec18e0843e Removing mainnet from testing networks 2017-10-25 13:50:04 +01:00
Alexander Ewetumo a2fbe0c1a8 Remove -networkurl flag 2017-10-25 13:48:09 +01:00
Alexander Ewetumo 468a52737a Fixing changes and url bug in accounts and transactions 2017-10-25 13:37:42 +01:00
Alexander Ewetumo ed61a1b19c Update code with network id and url returner 2017-10-25 13:08:33 +01:00
Ivan Tomilov cdd2a31449 Fixed according to comments 2017-10-24 19:58:18 +03:00
Ivan Tomilov 96212b912c Fixed make lint (goimports) 2017-10-24 19:54:13 +03:00
Ivan Tomilov 39cc60b8a7 Fixed make lint 2017-10-24 19:48:31 +03:00
Ivan Tomilov d1c47c5358 Merge branch 'develop' into feature/linter-in-travis
# Conflicts:
#	.travis.yml
#	Makefile
2017-10-24 19:44:54 +03:00
Ivan Tomilov f80827dc1f Feature/integrate linters into ci#387 (#427)
Solves #387 linters was integrated into ci
Added inergration linters to CI
Important changes:
- new linter warnings was fixed
- extracted linters targets into separated mk file
2017-10-24 19:36:52 +03:00
Alexander Ewetumo 6b9298fbc1 Update readme 2017-10-24 16:14:26 +01:00
Alexander Ewetumo aed88e234e Restore usage of string for -network flag 2017-10-24 16:13:19 +01:00
Alexander Ewetumo ca221f41f5 Fix import usage for jail test 2017-10-24 11:50:10 +01:00
Alexander Ewetumo 33fdc7dc82 Fix import usage for jail test 2017-10-24 11:44:15 +01:00
Alexander Ewetumo 46c46436f7 Fix conflicts with develop 2017-10-24 11:36:46 +01:00
Alexander Ewetumo a2cabd9d68 Fix test to ensure consistency with checks 2017-10-24 11:35:13 +01:00
Alexander Ewetumo a1668add06 Update readme and update code for testing 2017-10-24 11:23:53 +01:00
Evgeny Danienko 0e72e3d6b4
Update notify interface and mark old one as deprecated 2017-10-24 00:47:09 +03:00
Frank Mueller e14b2331eb Made EnsureNodeSync() throws a panic instead of returning an error (#431)
EnsureNodeSync() has been changed to return no error anymore, Instead in case of an internal error or a timeout a panic is thrown.
2017-10-24 00:39:13 +03:00
Alexander Ewetumo a257d1c201 Fix errors on network chain id validation in tests 2017-10-23 18:18:09 +01:00
Alexander Ewetumo d856660d09 Update readme and fix pointer bug 2017-10-23 17:28:12 +01:00
Alexander Ewetumo aa2779d3a9 Fix missed call of StartTestBackend 2017-10-23 17:22:19 +01:00
Alexander Ewetumo 14c124aef8 Switch to flag.String from flag.StringVar, removing init() 2017-10-23 17:16:15 +01:00
Alexander Ewetumo 7718bd5990 Move all tests to retrieve NetworkId from flag or default to statuschain 2017-10-23 17:03:07 +01:00
Alexander Ewetumo a98238ad97 Add GetNetworkID function for tests 2017-10-23 14:56:47 +01:00
Alexander Ewetumo d341e385fa Add networkSelected flag for test 2017-10-23 14:27:14 +01:00
Ivan Tomilov c500fbc423 Made all tests run on StatusChain instead of Rinkeby or Ropsten (#426)
The reason is that we don't currently have a possibility to run tests on public testnets without compromising accounts and funds on them.
2017-10-23 14:05:52 +03:00
b00ris 1de852134b
fix linters warnings 2017-10-23 13:41:41 +03:00
b00ris 22fb4dfc30
integrate linters into travis 2017-10-23 13:28:48 +03:00
Adam Babik 1dcf30142d Merge branch 'develop' into feature/linter-in-travis 2017-10-23 12:07:41 +02:00