6f1b82966a
feat_: light, no-network versions of permission checking functions
...
Light functions are based on the fact that permissions are met if the user is on community/channel member list.
If the user is not on the list, permissions will not be met and the client is responsible to use regular permissions-check functions.
For all permissions-check functions, corresponding light versions are added: CheckAllChannelsPermissionsLight,
CheckChannelPermissionsLight, CheckPermissionToJoinLight.
Issue #14220
2024-05-20 14:17:40 +02:00
20d3a7b69b
fix_: Use UnixMilli()
2024-05-20 14:39:46 +03:00
d8a5665871
fix_: encryption.GetCurrentTime implementation
2024-05-20 14:39:46 +03:00
da12c52596
fix_: loading hash_ratchet_encryption from database checks group_id
2024-05-20 14:39:46 +03:00
Jakub Sokołowski
c7397e18dd
chore(all)_: remove obsolete eth.staging fleet
...
And leftovers of `eth.test` fleet which no longer exists.
Signed-off-by: Jakub Sokołowski <jakub@status.im>
2024-05-17 20:21:00 +02:00
77541725aa
chore(community)_: reevaluateMembers optimization ( #5169 )
...
* chore(community)_: reevaluateMembers optinizations
2024-05-17 18:15:39 +02:00
948e09af03
fix(communities)_: ensure `ScheduleMembersReevaluation` is non-blocking ( #5176 )
2024-05-17 15:06:33 +02:00
ae08ba6ad1
feat(search)_: filter out messages from non-viewable channels ( #5161 )
...
Fixes https://github.com/status-im/status-desktop/issues/14586
2024-05-16 12:41:04 -04:00
574450289c
feat_: Move community tokens transaction listening to status-go
...
Use EventWatcher to catch wallet events.
Handling all community tokens wallet events in communitytokens service (database and messenger operations).
Adding new signal to nim: CommunityTokenTransactionSignal, which is emitted everytime when the event is received.
Issue #4351
2024-05-16 16:18:15 +02:00
00ee631a22
chore_: cleanup `hash_ratchet_encrypted_messages` periodically
...
closes : #5036
2024-05-16 16:15:30 +02:00
0db114f544
fix(communities)_: ensure read-only channels are not encrypted
...
fixes : status-im/status-desktop#14748
2024-05-16 11:21:55 +02:00
82ae41f6d5
feat(waku2)_: allow using an env variable to set the node's key ( #5152 )
2024-05-15 19:15:22 -04:00
9e0fb30f8d
chore_: bump go-waku ( #5150 )
2024-05-15 19:15:00 -04:00
5ca1cb0a0f
fix(messenger)_: make sure chats have an unread count of 0 for channels you can't view ( #5062 )
...
Fixes https://github.com/status-im/status-desktop/issues/14421
The problem is that you can receive messages to a channel, then later, before marking them as read, a permission is added to them, so you no longer have access.
Then, you can't even mark it as read if it's hidden.
Here, I fix it by setting the unread count on Init at 0 if the user doesn't have view access to it. And I make sure we update the counts when we are removed from a channel
2024-05-15 15:57:12 -04:00
bf56cb7ee2
fix_: saving profile image changes ens display name to non-ens ( #5156 )
...
When a user updates the preferred name, we should just ignore if the name is an ENS name,
because the ENS name is set only in the ENS popup. But this also means that if a user set
the profile name to an ENS name, this change will also be ignored.
2024-05-15 12:37:04 -07:00
3b5eab3bf1
fix_:sync contact request decision ( #5130 )
...
* fix_:sync contact request decision
* chore_:optimise test
* chore_:address feedback from review
2024-05-15 08:01:47 +08:00
c46e395a58
Extend peersyncing to sync 1-to-1 messages ( #4962 )
...
* fix_: extend peersyncing to sync 1-to-1 messages
* fix_: tests
2024-05-14 12:20:13 +02:00
8f50b578d1
refactor(chat)_: remove concept of ChannelGroup and remove api functions ( #4997 )
...
For status-im/status-desktop#12595
2024-05-13 15:06:21 -04:00
eb6ebade8e
fix_:failed test relate to old status community
2024-05-13 21:17:25 +08:00
6eb40bf781
chore_: Remove old status community from the database
2024-05-13 21:17:25 +08:00
627e23ffa5
fix_: mitigate permission stuck in pending state ( #5070 )
...
This PR mitigates permission stuck in pending state upon making device a
control node. It fixes [#14023 ](status-im/status-desktop#14023 )
2024-05-10 08:56:40 -07:00
cb4c19cece
feat(encryption)_: request control node to resend ecnryption keys during restoring account by a seed phrase ( #5142 )
2024-05-10 10:04:46 +02:00
349ea8ad6e
feat_: force members reevaluation ( #5139 )
...
* chore_: enable adding community manager options from messenger config
* chore_: make `reevaluateMembers` private method
* fix(MessengerCommunitiesTokenPermissionsSuite)_: proper waiting
* feat_: `ForceMembersReevaluation` method
* test_: increate some test timeouts
2024-05-09 22:59:51 +03:00
8cd4560823
fix(communities)_: prepare messages content for GetCommunityMemberAllMessages
...
Fixes #14060
2024-05-09 20:27:05 +07:00
6b5315b1fd
fix(communities)_: delay starting torrent client until connection is established
...
Fixes # 14510
2024-05-09 11:00:53 +07:00
529c658374
fix_: flaky TestSharedAddressesReturnsRevealedAccount ( #5137 )
2024-05-09 00:54:28 +01:00
5f4aab3121
feat(community)_: send signals about member reevaluation in progress ( #5120 )
...
Needed for https://github.com/status-im/status-desktop/issues/14378
2024-05-08 15:55:30 -04:00
db0cc10a73
fix(permisisons)_: private permisisons shouldn't affect the check ( #5116 )
...
Fixes https://github.com/status-im/status-desktop/issues/14608
2024-05-08 14:45:58 -04:00
3e4367a7cf
fix_: community members reevaluation fixes ( #5117 )
...
* fix_: prevent publishing older community description
* fix_: schedule member reevaluation instead of reevaluating in parallel
* fix_: lock community on members reevaluation
* fix(TestJoinCommunityAsAdminWithMemberAndAdminPermission)_: setup waitOnCommunitiesEvent in advance
* fix(TestEditSharedAddresses)_: remove redundant community description retrieval
2024-05-08 16:32:46 +01:00
522f3288b0
chore_: uncomment and skip TestBecomeMemberPermissions ( #5121 )
2024-05-08 15:53:34 +01:00
1c43b7a29b
chore_: better community json log ( #5118 )
2024-05-08 15:49:41 +01:00
59c6ee5ffe
chore_: disable discv5 in tests ( #5119 )
2024-05-07 15:06:45 +01:00
9c2c638aaf
fix(communities)_: fix curated comm fetch not starting for unknown comm ( #5110 ) ( #5111 )
2024-05-03 13:17:11 -04:00
8c5a735438
feat_: retry sending specific messages
2024-05-02 05:40:49 +08:00
852a5beb39
feat_: limit number of members in a community and number of pending requests ( #5107 )
...
* feat(community): limit nb of requests to join and members
Needed for https://github.com/status-im/status-desktop/issues/14532
* chore: simplify TestRequestAccessAgain
* chore: add a test for the member limit
2024-05-01 13:27:31 -04:00
2fb6d615fd
fix_: add method to retrieve prepared message ( #5102 )
...
* Add Test_WHEN_MessageContainsImage_THEN_PreparedMessageByIDContainsLink
* Add Messenger.PreparedMessageByID call
fixes #13684
2024-05-01 09:54:47 +04:00
b5f8f792d5
chore: fix flaky tests in 'TestMessengerProfileShowcase' ( #5104 )
...
* chore_: fix flaky tests in 'TestMessengerProfileShowcase'
Close #5100
* chore_: fix flaky `TestShareShowcasePreferences`
Close #4751
2024-04-30 19:46:42 +02:00
1551c98f96
chore_: override DNS for iOS as well ( #5093 )
...
We need to apply the DNS override hack for iOS as well.
This PR -> https://github.com/status-im/status-mobile/pull/19798 in status-mobile fixes the DNS resolution issue for
iOS ARM Simulators and for Android x86 Emulators.
But we still need this change to ensure storenodes are found on real iOS devices and on Android arm Emulators.
2024-04-26 14:14:17 +02:00
0ef4fb8cc7
chore_: log revealed addresses on join/edit ( #5073 )
2024-04-24 18:54:25 -07:00
70a9996d82
fix_: bio length check ( #5074 )
2024-04-24 20:41:08 +03:00
faf823f62f
fix_: filter private permissions & add Id keys in check_permissions_response ( #5059 )
2024-04-19 09:23:54 -07:00
3baaac3e63
chore_: move grant exiration to a new test ( #5078 )
2024-04-19 16:23:27 +02:00
d6c4682479
chore_: bump go to 1.20 ( #5027 )
...
This commit attempts to upgrade go version to 1.20.12
This commit also removes the following items from lint checks :
* `goconst`
* `structcheck`
* `deadcode`
* `golint`
* `varcheck`
Mobile PR for QA purposes -> https://github.com/status-im/status-mobile/pull/19564
2024-04-18 18:48:02 +02:00
78db9054fc
fix_: Add contact to removeTrustStatus response ( #5058 )
...
* Split function for reseting trust status and verification+trust status
* Refactoring: extract setTrustStatusForContact, setContactVerificationStatus functions
* Tests
2024-04-18 19:28:44 +04:00
9e5462eb9e
feat_: introduce forward error correction in segmentation layer
...
closes : #4330
2024-04-17 22:05:53 +02:00
bd91f5ab49
fix_: keep community locks map unreleased when Manager stops
...
`ReevaluateMembers` is run as a separate goroutine and sometimes it is
executed after `Manager` has been stopped. It tries to use the lock and
in consequence, it panics. Ensuring the map is still there prevents that.
^Happened in test: `TestCreateTokenPermission`.
2024-04-17 17:31:38 +02:00
9d309886f7
fix_: mitigate race conditions on community
...
mitigates: status-im/status-desktop#14432
2024-04-17 17:31:38 +02:00
6da423fc71
feat: Add an expiration and periodical publishing for community grants ( #5024 )
...
* feat_: add periodical publishing for community grants
feat_: Validate grant when receiving it
feat_: add expiration for grants
feat_: add test for grants expiration
fix_: move grants test to profile showcase, fix a few bugs
* feat_: use one group mesage to update grants
* chore_: review fixes
2024-04-17 16:53:51 +02:00
1211b86151
chore_: update pb.go files according protoc version from nix ( #5052 )
2024-04-12 19:04:00 +02:00
116fda7461
fix_: Remove rpc client from push notification servers and avoid panic
2024-04-11 17:12:14 +01:00
e6fee1a84e
fix_: token-permitted channel input not locked ( #5046 )
...
Issue #14117
2024-04-10 10:51:58 -07:00
21eba9928c
chore_: bump `hash_ratchet_encrypted_messages_key_id` migration
...
This is to ensure proper migration from release branch.
2024-04-10 16:40:57 +02:00
dcf3ed2388
fix_: improve performance of `GetHashRatchetMessages`
...
This time with proper migration timestamp.
part of: #5036
2024-04-10 14:27:14 +02:00
18cc3a16d5
Return request to join acceptance notifications ( #4909 )
2024-04-09 21:32:03 +02:00
e2a4a22896
chore: refactor status cli ( #5010 )
...
* chore: remove opts when create account
* chore: namings and better logging
* chore: config api modules with flag.
* chore: renaming
* chore: use methods on object
* fix: allow less characters for name
* fix: display name unit test
* chore: revert display name check.
* chore: change simulate display name.
2024-04-09 18:44:43 +03:00
69326767d8
add image to chat preview ( #4888 )
2024-04-09 17:39:14 +02:00
c921079761
fix: handle bridge message edits
...
Issue #14044
2024-04-07 23:24:46 +02:00
6c82a6c2be
fix(manager): make both perms satisfied if viewAndPost is satisfied
...
Fixes https://github.com/status-im/status-desktop/issues/14209
2024-04-04 14:34:59 -04:00
107d7a9822
fix: increase mute interval check
...
Each 3 seconds is much too frequent, it leads to all communities being
read from the database and as a consequence to extensive memory
consumption (most likely garbage collector was not fast enough to
cleanup allocated memory).
mitigates: status-im/status-desktop#14281
2024-04-04 10:59:47 -04:00
aa73a0512c
feat: add contact customization color ( #4869 )
2024-04-03 22:49:57 +08:00
3c76fdc626
fix: crash in dbRecordBundleToCommunity if event was signed not by a control node ( #5009 )
2024-04-03 14:51:28 +02:00
3bd00cb416
chore: log incorrect amountInWeis ( #5005 )
2024-04-02 14:54:24 +01:00
30e143ca40
Fix(Profile): Remove profile showcase from general response via signal ( #4982 )
...
* Fix(Profile): Remove profile showcase from general responce via signal
* Fix(Profile): Restore community membership validation for the prodile showcase
* feat: Make profile validation optional
* fix: review fixes
2024-03-29 11:22:44 +01:00
e4c1abb5ce
fix: validate display name on account creation ( #4994 )
2024-03-28 16:57:59 +01:00
223a1d759e
Login endpoints improvements ( #4980 )
2024-03-28 15:01:44 +00:00
c21e6430a2
fix(wallet): cleanup token_balances table on account removed
...
Updates #4937
2024-03-27 14:54:30 +01:00
5b7910ae5a
fix: validate community events read from database
...
Despite the expectation that only validated events are stored in the
database, instances have been identified where invalid events are saved.
This can lead to unexpected behavior or crashes.
This commit adds validation for community events read from the database
to prevent such cases.
**NOTE**: this fix does not address the root cause, which involves
invalid events being saved to the database. The exact scenario leading
to this issue has yet to be identified.
mitigates: status-im/status-desktop#14106
2024-03-27 14:31:03 +01:00
1a2880b365
Fix/community tags indices ( #4992 )
...
* fix: strict order of community tags
* make tags containers private
* fix RandomCommunityTags implementation
2024-03-26 20:02:12 +00:00
edcb8ba3b8
fix: sync pending contacts ( #4986 )
2024-03-26 13:47:12 +00:00
1886dc3360
[Feature] Allow setting TestNetworksEnabled in Create/Restore Account ( #4971 )
...
This commit adds the ability to set the "TestNetworksEnabled" flag while creating an account.
Function affected: "generateOrImportAccount"
This helps Dev/E2E/PR builds to enable Test Networks by default and disable them on release/nightly builds.
Signed-off-by: Mohamed Javid <19339952+smohamedjavid@users.noreply.github.com>
2024-03-26 17:08:16 +05:30
0d9b6138d6
fix: race condition with empty PreferredName (status-desktop/14053) ( #4981 )
2024-03-25 15:43:45 +00:00
7f44d4d12a
refactor: remove unused `COMMUNITY_EVENTS_MESSAGE_REJECTED`
2024-03-25 13:18:20 +01:00
e878f89b65
fix: Remove proof of membership for the profile showcase communities ( #4961 )
...
https://github.com/status-im/status-desktop/issues/14084
2024-03-22 21:50:15 +01:00
b931a75bd8
fix: crash on control node side dutring handling edited shared address from the member who left the community ( #4967 )
2024-03-22 15:25:37 +01:00
c7e7445f5c
Fix: ignore nil contact 'IsDisplayNameDupeOfCommunityMember' ( #4956 )
2024-03-21 20:43:51 +01:00
0aed93ff04
fix: encrypt community's Categories and ActiveMembersCount
...
fixes : #4943
fixes : #4944
2024-03-20 18:41:07 -04:00
894eb5758e
Add canView to chat & fix admin role
2024-03-20 16:48:07 -04:00
c85bf76f21
fix: Update and improve `TestFetchRealCommunity` ( #4949 )
2024-03-20 18:10:02 +00:00
ad342c8887
feat: get and delete community member messages API ( #4932 )
2024-03-19 20:44:49 +01:00
b911297a3d
Feature: store and retrieve a contact's bio ( #4916 )
...
* chore: create migration for adding bio field to contacts table
* feature: update contact persistence to save and query contact bio
* test: ensure that the protocol can store and retrieve contact bio data
2024-03-19 18:09:13 +00:00
78bf40994a
remove confusing debug log ( #4948 )
2024-03-19 19:11:18 +02:00
a1033f466a
feat: add new CommunityMemberState - CommunityMemberBanWithAllMessagesDelete ( #4941 )
2024-03-19 14:40:23 +01:00
f0d6a4f64f
Send direct message using CLI ( #4913 )
...
* feat: send dm with cli
* fix: send contact request works
* feat: accept contact request
* feat: send dm
* fix: log
* feat: more dm
* fix: lint
* refactor: fix comments
* fix: more refactor
* fix: refoctor more
* fix: more refacotr
* fix: refactor dm
* fix: context from cli
* fix: add light mode flag
* fix: remove sleep when start node
* fix: better log
* fix: better logger
* fix: lint
* fix: comments
* fix: const flags
* fix: named logger
* feat: inteactive mode
* fix: send message in loop
* fix: better context manage
* feat: cli serve
* fix: readme
* extract to multi files
* fix: status cli rpc
* feat: create and login account
* fix: missing messagess
* fix: missing messages because data sync is not started.
* feat: start http service
* fix: lint
* fix: more build instructions.
* fix: review comments
2024-03-19 08:31:35 +08:00
17c5ab414b
fix: ensure `CommunityDescription` reprocessing on decryption failure
...
Previously, `CommunityDescription` instances failing partial decryption
were not reprocessed due to duplicate message check. This commit fixes
the issue by bypassing the check for such descriptions, allowing their
reprocessing upon receiving missing encryption key.
fixes : status-im/status-desktop#13647
2024-03-18 22:24:24 +01:00
b9d9938209
make generate
2024-03-18 15:01:29 +01:00
8bf03609fc
feat: Add HideIfPermissionsNotMet to CommunityChat struct
...
Issue #13291
2024-03-18 15:01:29 +01:00
0aa1fb9eff
Fix: handle accepted contact verifaction if persistedVR is null ( #4918 )
2024-03-14 20:56:26 +01:00
2311da2475
Port back migrations from release branch
2024-03-14 13:27:12 +00:00
b987e8d6f5
Fix: the validation of collectibles should not be dependent on capitalization ( #4917 )
2024-03-13 15:19:33 +01:00
9db149d4f6
feat: handling replies for bridged messages
...
BridgeMessage struct has MessageID and ParentMessageID.
MessageID keeps the original Discord message ID.
ParentMessageID keeps the original Discord parent message ID (response_to).
When the new bridge message is received, corresponding status message response_to field is updated.
Issue #13258
2024-03-13 12:50:15 +01:00
67dfff2324
Add index to hash ratchet & cache processed description
2024-03-13 11:35:11 +00:00
8c0e24dc26
Add favicons to external link previews ( #4788 )
2024-03-12 22:47:51 +02:00
3f1547fc63
chore: add test that validates that the member role gets updated
2024-03-12 11:04:45 -04:00
6f119b9c53
fix(community): fix member role not being updated
2024-03-12 11:04:45 -04:00
605e3a4ed0
fix(community): fix editing a community channel loses the members
2024-03-12 11:04:45 -04:00
e3810148d8
feat: add ViewersCanPostReactions to Chat object
...
Needed https://github.com/status-im/status-desktop/issues/13523
2024-03-12 11:04:45 -04:00
b02e3b19e2
feat: add permissions reevaluation request
...
Token master can't manage members directly, so it must request
reevaluation from the control node.
fixes : status-im/status-desktop#13778
2024-03-12 14:15:01 +01:00
1de61d1933
fix: channel members evaluation on request acceptance
...
If there is only `viewAndPost` permission set on a channel, members who
don't satisfy the criteria shouldn't be able to view the channel.
2024-03-12 14:15:01 +01:00
2995518939
chore: skip flaky TestSetStorenodeForCommunity_fetchMessagesFromNewStorenode
2024-03-11 22:02:07 +01:00
c8044bf400
chore: disable curated communities loop in tests ( #4894 )
2024-03-09 09:42:06 +00:00
6522d52016
Feat: Simplify profile showcase preferences ( #4854 )
...
* Feat: simplify profile showcase preferences
* Feat: remove old profile showcase preferences on save
* Feat: add getters for showcase entries limits
2024-03-08 17:20:23 +01:00
5a54d703c7
fix: flaky test request profile info ( #4895 )
2024-03-08 15:50:46 +00:00
c3e7d3823f
fix: process empty albumId in albumMessages ( #4874 ) ( #4898 )
...
* fix: process empty albumId in albumMessages
* fix: right `prepareMessage` for empty album
2024-03-08 13:48:22 +00:00
7f671f7632
chore: make generate with custom `-modtime` ( #4896 )
2024-03-08 09:25:17 +00:00
deb56c2c81
fix: race condition on updating account.Name during handle BackupData
2024-03-07 20:18:50 +08:00
0e37ec2058
Fix contact details large image is always empty ( #4864 )
...
fixes #13563 contact details largeImage is always empty
2024-03-06 09:25:19 -08:00
67fd2ce93e
chore: skip TestBackupSettings
2024-03-06 18:05:40 +01:00
e9f0d7f597
chore: skip TestMessengerPeersyncingSuite
2024-03-06 18:05:40 +01:00
26bc564b38
Peer syncing toggle ( #4758 )
...
* Peer syncing toggle
* bindata.go
2024-03-05 11:44:09 +01:00
c217692c76
chore: improve StoreNodeRequestManager for community custom storenodes ( #4860 )
2024-03-04 20:46:25 +00:00
bdb2b261a6
feature: view only channel reactions ( #4820 )
...
* CommunityMember channel role
* make generate
2024-03-01 17:15:38 +00:00
84713384bb
fix: TestAdminBanMemberWithDeletingAllMessages test fix ( #4855 )
2024-03-01 17:37:20 +01:00
571f30777e
chore: make generate with nix-shell ( #4853 )
2024-03-01 13:58:24 +00:00
5d29c20f94
Feat: Add 'IsDisplayNameDupeOfCommunityMember' endpoint ( #4839 )
...
* feat: Add 'TestScanCommunitiesMembersForName' endpoint
* feat: validate display name amoung community members
2024-03-01 15:46:48 +03:00
e87e9b6f81
fix: recovering/migrating keypairs fixes
...
- fixed issue with displaying 3 words name on the login screen after recovering from waku
- fixed inability to delete account after recovering from waku
2024-03-01 11:11:16 +01:00
390d706b3f
fix: fix permission criteria being empty ( #4841 )
...
Fixes https://github.com/status-im/status-desktop/issues/13775
2024-02-29 16:25:34 -05:00
ff2eaf58e8
chore: unskip flaky tests
2024-02-29 21:58:36 +01:00
77214dcb5d
feat: admins can delete all members messages during the ban ( #4834 )
2024-02-29 18:54:17 +01:00
577db512c6
Feat: add endpoint for getting latest pending CR for a contact ( #4819 )
2024-02-28 23:00:35 +03:00
f0dcc60a17
fix: check nil pointer in saveProfileShowcasePreferencesProto ( #4821 )
2024-02-28 11:36:13 +00:00
168398d7a5
chore: faster TestCommunityOfflineEdit ( #4800 )
...
* chore: faster TestCommunityOfflineEdit
* chore: enable debug logs in TestSyncDeviceSuite
2024-02-27 19:38:40 +00:00
9fa396e797
chore: nix-shell make generate ( #4824 )
2024-02-27 19:35:43 +00:00
df930b1d73
feat: New field in TokenCriteria proto
...
AmountInWei will have a wei-like units.
Amount field becomes deprecated because it kept string with float value.
Comparison (in case of Decimals == 5):
Amount (deprecated) = "1.2"
AmountInWei = "120000"
Issue #11588
2024-02-27 16:25:26 +01:00
34fd0e87e4
chore: skip failing tests
2024-02-27 11:00:29 +01:00
1f42f2582a
Revert "Comment out all logged flaky tests"
...
This reverts commit 0bd4a06edc
2024-02-27 11:00:29 +01:00
0a1a66afa7
fix: prevent messenger being started twice
...
Previously, Messenger was `Start`ed multiple times, which resulted in
the shutdown process not being invoked on previously initialized
Messenger's sub-instances. This led to the failure of MVDS instance
shutdown causing massive error logs due to the attempts to read from a
closed database.
2024-02-27 11:00:29 +01:00
bafb0a71d0
fix: prevent `panic: send on closed channel`
2024-02-27 11:00:29 +01:00
5aed0d178f
chore: unskip flaky tests
2024-02-27 11:00:29 +01:00
fcd8e62b40
chore: introduce silent test logger config
2024-02-27 11:00:29 +01:00
2445cda3e0
fix(contacts): fix blocking a non-contact sends a signal to the other ( #4799 )
...
Fixes https://github.com/status-im/status-desktop/issues/13545
The code is correct in sending an updated CR to make sure the sync doesn't sync back the previous state or at least overrides it.
However, if we never were a contact with the person sending us a CR, and we block them, it sends them a "you got removed" message, which first doesn't make sense but also could let them know they got blocked/ignored.
The trick is just to make sure we added them first. Then dismissing the CR makes sense.
2024-02-26 12:49:04 -05:00
eeaff0d3e3
fix: sync&backup channels encryption keys
...
fixes : status-im/status-desktop#13356
2024-02-26 16:41:30 +01:00
7cc4c12642
Feat: Add social links to the profile showcase ( #4775 )
...
* feat: add social links to the profile showcase
* fix: deprecate old social links, add synced profile showcase to response
2024-02-26 16:53:40 +03:00
92bc64bb41
feat: kicked/banned member should not have spectated mode after the kick/ban ( #4806 )
2024-02-26 13:33:07 +01:00
4581c4f5f7
fix: sometimes channels do not randomly appear in test community after its creation ( #4669 )
2024-02-23 10:16:51 +08:00
ba7faea027
fix: Use correct chains when checking permissions: mainnet or testnet ( #4793 )
...
Fix #18896
2024-02-22 10:17:35 -05:00
3959948c4c
chore: fix ban/unban flow and delete all messages feature ( #4743 )
...
feat: delete all messages for banned member and ban/unban AC notifications
2024-02-22 11:25:13 +01:00
eb5bad4868
Feat: Profile showcase validate collectible ownership ( #4737 )
...
* feat: profile showcase checks then presenting collectibles
* chore: more obvious CollectiblesManager configuration
2024-02-22 11:08:58 +03:00
01b3f8ace4
fix flaky test TestMarkMessagesSeenMarksNotificationsRead ( #4781 )
...
* fix flaky test TestMarkMessagesSeenMarksNotificationsRead
* address review feedback
2024-02-22 09:44:14 +08:00
569a401643
fix flaky test TestBackupSettings ( #4772 )
2024-02-21 10:51:12 +08:00
e2cab1a8ae
fix: ensure community events eventual consistency
...
- Extracted `community_events_factory.go`
- Introduced `eventsProcessor`
- Improved processing logic order
- Improved events filtering
- Introduced concept of `EventTypeID` to prevent redundant events handling
- Added sanity check before events appliance when reading community from
database
- Removed reject&re-apply scheme (no more ping-pong issue)
- Fixed and added more variants to eventual consistency test
fixes : status-im/status-desktop#13387
fixes : status-im/status-desktop#13388
2024-02-20 21:07:01 +01:00
f7c40d4c40
chore: use lamport timestamp for events clock
...
- make clock logical per event type
- increase clock precision to millisecends
Rationale:
https://www.notion.so/Eventual-consistency-9d6a9c6c55c14ab1aee76f801301522b
iterates: status-im/status-desktop#13387
2024-02-20 21:07:01 +01:00
3f19972c8e
enable custom community storenodes ( #4532 )
...
* enable custom community store nodes
* fix
* fix
* fix
* fix
* cleanup
* fix
* migration
* fix
* cleanup
* fix
* cleanup
* fix
* fix
* cleanup
* message to update the community storenodes
* rename
* fix test
* wait for availability only if global storenode
* fix test
* fix typo
* sync community storenodes
* remove unused
* add tests
* fix imports
* fix todo
* unused
* pr comments
* pr feedback
* revert merge deleted
* fix lint
* fix db and perform ms request
* typo
* fix log
* fix go imports
* refactor handle message
* cleanup public message
* add tests
* fix test
* cleanup test
* fix test
* avoid making one file to big to keep codeclimate from complaining
* fix lint
* revert
* Update protocol/storenodes/database.go
Co-authored-by: richΛrd <info@richardramos.me>
* Update protocol/messenger_mailserver_cycle.go
Co-authored-by: richΛrd <info@richardramos.me>
* PR comment
* fix tx
* proto files
* pr comment
---------
Co-authored-by: richΛrd <info@richardramos.me>
2024-02-20 17:49:39 +02:00
515dbdf2b3
fix: waku connection status subscription lock ( #4762 )
...
* fix: lock waku connStatus subscription for sending
* update skipped tests
2024-02-19 23:44:38 +00:00
30f4edf48d
fix: keep flaky tests compilable and easy to find
2024-02-19 21:46:35 +01:00
1fca1e1743
Revert "Comment out flaky tests ( #4741 )"
...
This reverts commit 582927868d
2024-02-19 21:46:35 +01:00
a866b8025e
feat: Community token received notification ( #4682 )
2024-02-19 14:55:38 +01:00
582927868d
Comment out flaky tests ( #4741 )
2024-02-19 10:10:37 +01:00
85c0e282ae
feature: profile showcase preferences sync&backup ( #4729 )
2024-02-17 18:07:20 +00:00
f0e6fd31de
chore: TestFetchingHistoryWhenOnline ( #4701 )
2024-02-16 18:34:04 +00:00
add46fbda0
chore: `make generate` with nix-shell ( #4745 )
2024-02-16 12:48:27 +00:00
789ee81201
fix: saved addresses sync (`TestSyncDeletesOfSavedAddresses` flaky test) ( #4742 )
2024-02-16 09:45:10 +00:00
526e3d74f1
Feat: proof of membership for profile showcase communities ( #4713 )
...
* chore: move profile showcase structures to the indentity package
* feat: implement proof of membership for unecrypted communities
* feat: implement proof of membership for encrypted communties with grants
2024-02-15 22:13:12 +03:00
27f0884b51
Exclude watch only accounts from permissions checks
2024-02-14 17:03:28 +00:00
3a0fe0e62f
fix: fix contact not updating when an ID verif is canceled ( #4719 )
...
Fixes https://github.com/status-im/status-desktop/issues/13412
2024-02-13 14:34:56 -05:00
598d58f0d6
fix: a proper clock set when dispatching saved addresses
2024-02-13 17:39:10 +01:00
2bdc7ec0f4
fix(handler): fix CR received from a removed contact removed ( #4708 )
...
Fixes https://github.com/status-im/status-desktop/issues/13488
The problem was that when you add a contact, it create the chat. Then, if you remove them, it doesn't remove the chat, so `chat.Active` is true.
Now I check in that case if it's a 1x1 chat and if so, if we are contact.
2024-02-13 10:15:42 -05:00
5149976ce0
fix: improve messenger offline detection ( #4703 )
2024-02-13 13:12:59 +00:00
598e3217ba
Signal user if the networks are not supported
2024-02-13 12:09:46 +00:00
5e905518aa
fix: missing fields in Communtiy CreateDeepCopy ( #4718 )
2024-02-12 23:26:32 +00:00
432bfeea2f
fix: flaky `MessengerStoreNodeRequestSuite` ( #4721 )
2024-02-12 22:30:19 +00:00
1c42c07760
feat(discord_import): send signal when the import was cleaned up ( #4693 )
...
This is to let the front end know that the community was deleted so it can also delete it from the UI
2024-02-12 16:04:12 -05:00
44c39d345e
chore: testWakuV2Config ( #4704 )
...
* chore: testWakuV2Config
* renamed to `NewTestWakuV2`
2024-02-12 12:53:15 +00:00
8d4f4904c6
fix: better calculation of from/to mailserver batch parameters ( #4702 )
2024-02-12 12:20:56 +00:00
daef5c56e2
Add HighestRole & ordered roles to permission response
...
This commit adds HighestRole & a list of permissions in order of
importance to the CheckPermissionToJoinResponse.
This simplify client code so that it doesn't need to be calculated on
the client.
2024-02-12 12:18:56 +00:00
3ea2002904
Feat: Modify grants for profile showcase use ( #4694 )
...
* chore: regenerate proto binaries
* feat: remove unused grant code for community's canPost
2024-02-11 15:11:04 +03:00
ec1238e020
fix: adapt to `response.RequestsToJoinCommunity` interface change ( #4705 )
...
fixes tests build
2024-02-09 18:23:24 +00:00
cc66f43713
fix: fix permissions checker
...
Improve CheckPermissions function.
Check separately member and admin+tokenmaster permissions..
Issue #12884
2024-02-09 19:00:43 +01:00
87199a8c99
chore: cover community events eventual consistency with test
...
It proves eventual consistency is broken for contact request events.
iterates: status-im/status-desktop#13387
2024-02-09 16:02:17 +01:00
a0e7b1374e
feat: introduce `MessagesOrderController`
...
Enables controlling order of messages in tests. Useful for deterministic
reproduction of out-of-order messages.
Required for: status-im/status-desktop#13387
2024-02-09 16:02:17 +01:00
a8b7854ce9
feat: introduce `testWakuWrapper` and `testPublicWakuAPIWrapper`
...
Enables `PublicWakuAPI` introspection.
2024-02-09 16:02:17 +01:00
7e8b61f888
feat: introduce `MessagesIterator`
...
Enables customization of iteration strategy for retrieved messages.
2024-02-09 16:02:17 +01:00
9b7926b23b
feat: delete profile showcase community entry on community leave or kicked ( #4686 )
2024-02-09 12:37:54 +03:00
2350461818
feat: Dispatch profile showcase message on mutual/verified contacts change ( #4678 )
2024-02-09 12:36:54 +03:00
c49a0fc314
[ Fixes : #4687 ] Change requestsToJoinCommunity to a map
...
The test was flaky because of re-receiving the message, which resulted
in multiple identical requestsToJoin being added to messengerResponse.
We should in general avoid using arrays in messengerResponse and prefer
maps for exactly this reason.
2024-02-08 11:18:53 +00:00
e7e6782241
Fix: linter error
2024-02-07 20:10:49 +00:00
31277f1e9e
Fix: cover case where criteria doesn't have token IDs
2024-02-07 20:10:49 +00:00
b727f1e14b
Extract entire permissioned balances logic to separate file
2024-02-07 20:10:49 +00:00
105703e2eb
Remove zombie code from experiments
2024-02-07 20:10:49 +00:00
4f8a66fc07
Create endpoint to get permissioned balances
2024-02-07 20:10:49 +00:00
18e7b6c331
Fix Discord Import getting stuck ( #4681 )
...
* fix(community_import): fix import getting stuck in case of error in msgs
Fixes #13438 and #13439
* fix(community_import): fixes a bug with the timestamp format
The importer didn't like `-` time zones like `-4`. Using the standard date format makes it work.
2024-02-07 13:02:47 -05:00
70ee70a19a
feat: implement new endpoint to set customization color ( #4568 )
2024-02-07 18:20:54 +03:00
605fe40e32
Fix encryption metadata issues #4613
...
This commit fixes a few issues with communities encryption:
Key distribution was disconnected from the community description, this created a case where the key would arrive after the community description and that would result in the client thinking that it was kicked.
To overcome this, we added a message that signals the user that is kicked. Also, we distribute the key with the community description so that there's no more issues with timing.
This is a bit expensive for large communities, and it will require some further optimizations.
Key distribution is now also connected to the request to join response, so there are no timing issues.
Fixes an issue with key distribution (race condition) where the community would be modified before being compared, resulting in a comparison of two identical communities, which would result in no key being distributed. This commit only partially address the issue.
2024-02-07 10:25:41 +00:00
47b9978525
Feat: Save and dispatch profile showcase on wallet account change ( #4674 )
...
* Feat: Save and dispatch profile showcase on wallet account change
* Feat: Remove entry and dispatch profile showcase on wallet account removal
2024-02-07 12:30:56 +03:00
33c46dd59d
fix(protocol): crash in concurrent map write/read
2024-02-05 15:21:44 +01:00
2dc1b48968
[ #4671 ] Increase interval between calls to Directory contract ( #4672 )
2024-02-05 14:01:59 +01:00
e9b10c4beb
chore: sync history regardless of connection type ( #4656 )
2024-02-02 13:03:55 -04:00
9b10b29da2
[ #4630 ] Add wallet_fetchOrGetCachedWalletBalances method ( #4666 )
2024-02-02 11:42:56 +01:00
9879b1ea77
fix: set display name issue ( #4642 )
2024-02-01 19:13:41 +03:30
0c2a935578
fix: fetch history when back online ( #4651 )
2024-01-30 18:13:18 +00:00
98c1ebec05
fix: handle community shard unassignment and update ( #4627 )
2024-01-30 13:56:59 -04:00
1f0fc2935c
fix: clear waku envelopes cache when deleting a chat ( #4621 )
...
* chore: extract `ErrPermissionToJoinNotSatisfied`
* chore: disable resending messages in communities tests
* chore: move newTestMessenger extraOptions to testMessengerConfig
* chore: `WithTestStoreNode` messenger option
* feat: waku `ClearEnvelopesCache` method
* fix: call `ClearEnvelopesCache` when deleting chat
* chore: `TestBecomeMemberPermissions` checks messages after rejoin
2024-01-30 13:43:34 +00:00
73a5189398
feat(BridgeMessage): Add new type of chat message content: BridgeMessage
...
BridgeMessage is a type of chat message content which will be sent from Matterbridge.
It contains fields:
- bridge name - depends on the used bridge, eg. "discord", "slack", etc...
- user name - username the message was received from
- content - message content
- user avatar
- message id
- parent message id - used in case of replies
Message is saved to a separated table: bridge_messages, similarly to discord messages.
The user_messages table is untouched.
bridge_messages table contains user_messages_id in order to join with user_messages table.
Issue #13098
2024-01-30 12:14:54 +01:00
4a7d15b36d
fix: use CommunityShardKey's clock rather than community's clock
2024-01-29 21:31:11 +01:00
ac81c15805
fix: ignore outdated COMMUNITY_SHARD_KEY messages
...
This mitigates issue where community shard on client's side was not in
sync with owner's.
relates to: status-im/status-desktop#13217
2024-01-29 18:21:51 +01:00
67e18a8ff0
chore: introduce `unhandledMessagesTracker`
2024-01-29 18:21:51 +01:00
6403a7413b
feat: new endpoint added which returns accounts of all contacts that match the passed address
2024-01-29 13:15:24 +01:00
ab641c0c78
fix: remove store node envelopes ordering hotfix ( #4622 )
2024-01-27 13:02:12 +00:00
fb98ee93ce
Correct profile showcase tokens and collectibles ( #4511 )
...
* feat: add profile showcase collectibles & assets missing fileds
* feat: resolve collectible identification issue
* feat: add validation for collectible visibility relative account
* feat: separate profile showcase assets on verified and unverified tokens
* fix: make chainId uint64, comment collectible account check
* chore: re-generate protobuf binaries with right protoc version
* Update protocol/messenger_profile_showcase.go
Co-authored-by: Igor Sirotin <sirotin@status.im>
2024-01-25 20:48:27 +04:00
bea0b5a63d
fix TestMarkAllActivityCenterNotificationsReadMarksMessagesAsSeen ( #4615 )
2024-01-25 13:56:56 +08:00
5f6f7e502d
(fix/status-go) fix profile picture update/removal ( #4570 )
...
This PR fixes [9947](status-im/status-desktop#9947 ) and contains :
- Commit to fix the changing of custom picture and having the change
reflected on contact's side
- Commit to fix the deleting of picture and having the change reflected
on contact's side
- Rename confusing `ImageType` to `ImageFormat`
2024-01-24 12:09:28 -08:00
1a85a29b1b
chore: cover community sharding with tests
...
closes : #4262
2024-01-24 14:24:57 +01:00
5162c285a8
refactor: introduce `newTestCommunitiesMessenger`
2024-01-24 14:24:57 +01:00
92f43bac78
chore: extend `CreateWakuV2Network` with `useShardAsDefaultTopic`
2024-01-24 14:24:57 +01:00
2a91fba1fa
chore: added and fixed some logs ( #4577 )
...
* chore: logs for successful storenode request
2024-01-23 18:20:01 +00:00
e65760ca85
Add basic peersyncing
...
This commit adds basic syncing capabilities with peers if they are both
online.
It updates the work done on MVDS, but I decided to create the code in
status-go instead, since it's very tight to the application (similarly
the code that was the inspiration for mvds, bramble, is all tight
together at the database level).
I reused parts of the protobufs.
The flow is:
1) An OFFER message is sent periodically with a bunch of message-ids and
group-ids.
2) Anyone can REQUEST some of those messages if not present in their
database.
3) The peer will then send over those messages.
It's disabled by default, but I am planning to add a way to set up the
flags.
2024-01-23 12:46:17 +00:00
bf5dcacdeb
refactor: introduce `newTestMessenger`
...
This avoids duplication and enables better configuration possibilities
for clients.
Next step is to cleanup all `newMessenger` derivatives in tests.
2024-01-22 13:08:58 +01:00
436d229856
Add last opened at key for community ( #4514 )
2024-01-21 12:55:14 +02:00
81f4c86086
fix: return CustomizationColor only on db rows affected ( #4593 )
2024-01-19 18:26:39 +08:00
926f6a3c72
Revert "test: bump go-libp2p"
...
This reverts commit d0ca4447c6
2024-01-18 20:29:33 +00:00
0d2c3cef7c
feat: implement token management settings for collectibles
2024-01-18 11:46:35 -03:00
d0ca4447c6
test: bump go-libp2p
2024-01-18 14:28:06 +00:00
ea3e59ffee
replace mention name with public key ( #4579 )
...
* replace mention with public key
* bump version
2024-01-18 21:18:01 +08:00
0bd4a06edc
Comment out all logged flaky tests
2024-01-18 06:36:12 +00:00
9aef13f83e
[ #4200 ] Enable prevention of tx detection on unrevealed mnemonic/address ( #4444 )
2024-01-16 15:17:02 +01:00
a5acffc001
fix: TestFetchRealCommunity with shards fleet ( #4553 )
...
* fix: TestFetchRealCommunity with shards fleet
* fix: DefaultShardPubsubTopic
* chore: print waku query request id
2024-01-16 13:38:41 +03:00
94bee02ef7
chore: fetch comunity token metadata during handling community description ( #4562 )
2024-01-16 09:08:56 +01:00
3d7ab79d91
fix: execute BeforeDispatch only once
...
Issue #4557
2024-01-15 17:03:33 +01:00
3ddec465c5
fix: restore FetchCommunity&TryDatabase fallback to store nodes
...
Add missing check caused by recent `communities.GetByID` refactoring.
2024-01-12 13:15:29 +01:00
280f48877d
chore(savedaddresses)!: favourite property removed and primary key updated
...
- favourite column removed from the saved_addresses table
- favourite property removed from the SavedAddress struct
- ens name removed from the primary key, the primary key now is composed of address and is_test columns
- ens parameter removed from wakuext_deleteSavedAddress
- wallet_getSavedAddresses moved to wakuext_getSavedAddresses (to keep them all in a single place)
- saved addresses related endpoints removed from the wallet service, even they logically belong there, a reason for that
is avoiding emitting sync message if one uses calls from the wallet service, while that's not the case in ext service. Once
we refactor this and introduce devices syncing mechanism in the wallet service, we should not only these but other wallet
related endpoints move there (removed: wallet_getSavedAddresses, wallet_addSavedAddress and wallet_deleteSavedAddress).
Affected area:
Saved addresses
2024-01-10 19:30:56 +01:00
2a5dc6dec0
chore: remove boilerplate check of `communities.GetByID` clients
...
motivated by:
https://github.com/status-im/status-go/pull/4514#discussion_r1445808116
2024-01-10 18:58:17 +01:00
781a2c7c8e
fix: ensure needed community tokens are available in the db
...
Fixes #13171
2024-01-10 12:57:10 -03:00
5cb1972261
chore: return chats after mark all notifications read ( #4432 )
2024-01-10 09:36:33 +08:00
e1b52f9eae
Add joined at key to communities ( #4513 )
2024-01-09 20:36:47 +02:00
9d9c40b7cf
fix: make fetchCommunity return latest available community
...
Fixes #13145
2024-01-08 18:09:21 -03:00
16f11d49df
fix: flaky TestEncryptionDecryption
...
fixes : #4510
2024-01-08 21:18:51 +01:00
9d8b55e3d9
This PR (status-go) fixes #12821 ( #4516 )
...
- Add album_images column to the user_messages table
- Migrate the database
2024-01-08 10:18:57 -08:00
405d468e0e
fix: force verifiedOwner in `handleSyncInstallationCommunity` ( #4405 ) ( #4538 )
2024-01-08 15:57:57 +00:00
53ac61bb8b
fix: a few adjustments for matterbridge
...
- exposig Online info
- adding ability to disable backup loop and auto message loop
Issue #12710
2024-01-08 14:21:26 +01:00
5c704b2ec2
chore: check and manualy verify community if during the fetchCommunity, community was added to the verification loop ( #4533 )
2024-01-05 18:09:38 +01:00
7814f39cd7
feat: Add advanced token settings ( #4524 )
2024-01-05 12:12:53 +01:00
846a4e2363
feat: Community token received notification ( #4515 )
2024-01-04 13:22:06 +01:00
a8357dceac
feat: color field added to saved address
...
- `color` column added to `saved_addresses` table
- `colorId` parameter exposed via `SavedAddress` struct
Affected area - saved addresses.
The following endpoints return or receive `SavedAddress` instance:
- `UpsertSavedAddress`
- `GetSavedAddresses`
- `AddSavedAddress`
2023-12-29 10:39:52 +01:00
195982c950
fix_(StoreNodeRequestManager): various fixes and improvements ( #4509 )
2023-12-27 13:53:19 +00:00
843bae5659
feat: Return seen/unseen messages count in MessnegerResponse ( #4461 )
2023-12-25 13:25:22 +07:00
151185c436
chore: log message contents before being sent ( #4494 )
...
When debugging message reliability we often get the number of messages sent and their IDs but we do not know the content of the messages and the type of message sent.
This commit adds debug level logs so that it helps in investigations.
ref : https://github.com/status-im/status-mobile/issues/18031
Closes [#18206 ](https://github.com/status-im/status-mobile/issues/18206 )
2023-12-23 09:42:45 +05:30
a90589f4f7
chore: test filters are in the right place after store node requests ( #4500 )
2023-12-22 19:23:39 +00:00
1d3c618fb4
feat: encrypt `CommunityDescription` fields
...
Extended `CommunityDescription` with a `privateData` map. This map
associates each hash ratchet `key_id` and `seq_no` with an encrypted
`CommunityDescription`. Each encrypted instance includes only data
requiring encryption.
closes : status-im/status-desktop#12851
closes : status-im/status-desktop#12852
closes : status-im/status-desktop#12853
2023-12-22 18:17:06 +01:00
9cbfda69da
chore: share shard info independently on waku version ( #4507 )
2023-12-22 17:43:38 +01:00
1317f0c796
hotfix: Update profile showcase proto ( #4506 )
2023-12-22 22:43:27 +07:00
134137f9c5
feat: implemented a mechanism to retrieve shard information for a given community ID ( #4499 )
...
* feat: a mechanism to retrieve shard information for a given community ID
2023-12-22 13:37:37 +01:00
dac7a0daf9
feat: Fetch community data for tokens ( #4497 )
2023-12-22 10:43:19 +01:00
29ade0f817
fix (@status-go/stickers) Stickers still show in the recent list after being uninstalled ( #4474 )
...
fixes #12677
2023-12-21 10:05:30 -08:00
7fc3e4440f
Fix: Don't create extra mutual state messages when accepting the CR again ( #4488 )
...
* Fix: don't create extra system messages when accepting the CR again
* chore: add one more test for cr flows repeated
* chore: use deprecation.AddChatsCount in contact requests tests
2023-12-22 00:38:14 +07:00
6bfe626558
feat: Use media server for community token images ( #4493 )
2023-12-21 16:05:29 +01:00
6d77fb771a
fix(windows-build): Remove free space check for archives ( #4485 )
2023-12-20 21:21:02 +03:00
92f0479a0c
chore: fetch contact with `StoreNodeRequestManager` ( #4484 )
2023-12-20 12:49:12 +00:00
a5f6a6c2f6
fix: privileged member accepted/rejected request to join action is not approved by the control node after the member leaved and tries to join the community again ( #4487 )
2023-12-19 14:45:34 +01:00
0818c98fca
fix_: don't start mailserver cycle when no mailservers set ( #4457 )
2023-12-19 11:58:44 +00:00
45bd8c16da
fix: do not ignore banned list if EventsData is nil ( #4473 )
2023-12-19 12:00:29 +01:00
88fd1ce942
Surface acks, offers, requests to messenger
2023-12-18 10:33:05 +00:00
Michal Iskierko
Vitaly Vlasov
Igor Sirotin
Jakub Sokołowski
Mykhailo Prakhov
osmaczko
Jonathan Rainville
Patryk Osmaczko
richΛrd
Godfrain Jacques
frank
Alexander
Parvesh Monu
Andrey Bocharnikov
Mikhail Rogachev
Siddarth Kumar
Ajay Sivan
Mohsen
Andrea Maria Piana
Ibrahem Khalil
kaichao
flexsurfer
yqrashawn
Ivan Belyakov
Mohamed Javid
Sean Hagstrom
Pablo Lopez
Sale Djenic
Michał Iskierko
Cuteivist
Roman Volosovskyi
Icaro Motta
Dario Gabriel Lipicar
Boris Melnik