From ba37c32c07d1b05a94d1c7f7cb1b38fb82730f7b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jakub=20Soko=C5=82owski?= Date: Sat, 5 Oct 2024 09:53:44 +0200 Subject: [PATCH] fix(make)_: avoid calling version script unnecessarily MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit If we use `:=` we always call it, but it's not necessary for most targetrs. It requires `git` which is not available in Nix build sandbox. Signed-off-by: Jakub SokoĊ‚owski --- Makefile | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/Makefile b/Makefile index d2577828b..d4c93cfed 100644 --- a/Makefile +++ b/Makefile @@ -29,9 +29,9 @@ help: SHELL := /bin/sh help: ##@other Show this help @perl -e '$(HELP_FUN)' $(MAKEFILE_LIST) -RELEASE_TAG:=$(shell ./_assets/scripts/version.sh) -RELEASE_DIR := /tmp/release-$(RELEASE_TAG) -GOLANGCI_BINARY=golangci-lint +RELEASE_TAG ?= $(shell ./_assets/scripts/version.sh) +RELEASE_DIR ?= /tmp/release-$(RELEASE_TAG) +GOLANGCI_BINARY = golangci-lint IPFS_GATEWAY_URL ?= https://ipfs.status.im/ ifeq ($(OS),Windows_NT) # is Windows_NT on XP, 2000, 7, Vista, 10... @@ -54,9 +54,9 @@ endif CGO_CFLAGS = -I/$(JAVA_HOME)/include -I/$(JAVA_HOME)/include/darwin export GOPATH ?= $(HOME)/go -GIT_ROOT := $(dir $(realpath $(lastword $(MAKEFILE_LIST)))) -GIT_COMMIT := $(shell git rev-parse --short HEAD) -GIT_AUTHOR := $(shell git config user.email || echo $$USER) +GIT_ROOT ?= $(dir $(realpath $(lastword $(MAKEFILE_LIST)))) +GIT_COMMIT ?= $(shell git rev-parse --short HEAD) +GIT_AUTHOR ?= $(shell git config user.email || echo $$USER) ENABLE_METRICS ?= true BUILD_TAGS ?= gowaku_no_rln