status-im
/
status-go
mirror of https://github.com/status-im/status-go.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

test_: re-organized test code

This commit is contained in:
frank 2024-06-04 10:06:06 +08:00
parent 763ed552ed
commit a908a41eff
3 changed files with 187 additions and 164 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

159
api/backend_test.go
View File

@ -17,9 +17,6 @@ import (
"testing" "testing"
"time" "time"
"github.com/status-im/status-go/multiaccounts/common"
"github.com/status-im/status-go/protocol/tt"
"github.com/stretchr/testify/assert" "github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require" "github.com/stretchr/testify/require"
@ -66,11 +63,6 @@ var (
WalletRootAddress: types.HexToAddress("0xeB591fd819F86D0A6a2EF2Bcb94f77807a7De1a6")} WalletRootAddress: types.HexToAddress("0xeB591fd819F86D0A6a2EF2Bcb94f77807a7De1a6")}
) )
const (
oldMobileUserKeyUID = "0x855ab0a932e5325daab7a550b9fcd78d2a17de5e2b7a52241f82505ea9d87629"
oldMobileUserPasswd = "0x20756cad9b728c8225fd8cedb6badaf8731e174506950219ea657cd54f35f46c" // #nosec G101
)
func setupTestDB() (*sql.DB, func() error, error) { func setupTestDB() (*sql.DB, func() error, error) {
return helpers.SetupTestSQLDB(appdatabase.DbInitializer{}, "tests") return helpers.SetupTestSQLDB(appdatabase.DbInitializer{}, "tests")
} }
@ -1329,157 +1321,6 @@ func TestLoginAndMigrationsStillWorkWithExistingDesktopUser(t *testing.T) {
loginDesktopUser(t, conf) // Login twice to catch weird errors that only appear after logout loginDesktopUser(t, conf) // Login twice to catch weird errors that only appear after logout
} }
func loginMobileUser(t *testing.T, rootDataDir string) {
// what we have in table `accounts` before test run:
// 1. Address: 0x23A5CEF34B18920785F4B895849936F65CBDEF73
// Wallet: 1, Chat: 0, Type: '', Path: m/44'/60'/0'/0/0, Name: 'Main account', Derived_from: '', Pubkey: 0x047B67AD2...
// 2. Address: 0x4851276E2B7DC3B8BEF1749127031BCB3578492D
// Wallet: 0, Chat: 1, Type: '', Path: m/43'/60'/1581'/0'/0, Name: 'Cadetblue Fuzzy Flickertailsquirrel', Derived_from: '', Pubkey: 0x04F96F6F5...
// 3. Address: 0x4D26E5C2F85BA5D10BDA6B031E1C1579F8ECFA1F
// Wallet: 0, Chat: 0, Type: 'generated', Path: m/44'/60'/0'/1, Name: 'generated', Derived_from: '', Pubkey: 0x04488EDA7...
// 4. Address: 0x516312D69737C5E6EF16F22E0097FF5D9F0C4196
// Wallet: 0, Chat: 0, Type: 'key', Path: m/44'/60'/0'/0/0, Name: 'key', Derived_from: '', Pubkey: 0x040D5E4E3...
// 5. Address: 0x95222290DD7278AA3DDD389CC1E1D165CC4BAFE5
// Wallet: 0, Chat: 0, Type: 'watch', Path: '', Name: 'watch-only', Derived_from: '', Pubkey: <null>
// 6. Address: 0xB7A1233D1309CE665A3A4DB088E4A046EB333545
// Wallet: 0, Chat: 0, Type: 'seed', Path: m/44'/60'/0'/0/0, Name: 'seed', Derived_from: '', Pubkey: 0x04FDE3E5...
// seed phrase for 0xB7A1233D1309CE665A3A4DB088E4A046EB333545: vocal blouse script census island armor seek catch wool narrow peasant attract
// private key for 0x516312D69737C5E6EF16F22E0097FF5D9F0C4196: c3ad0b50652318f845565c13761e5369ce75dcbc2a94616e15b829d4b07410fe
b := NewGethStatusBackend()
b.UpdateRootDataDir(rootDataDir)
require.NoError(t, b.OpenAccounts())
require.NoError(t, b.Login(oldMobileUserKeyUID, oldMobileUserPasswd))
db, err := accounts.NewDB(b.appDB)
require.NoError(t, err)
accs, err := db.GetAllAccounts()
require.NoError(t, err)
require.True(t, len(accs) == 6)
kps, err := db.GetAllKeypairs()
require.NoError(t, err)
require.True(t, len(kps) == 3)
// Create a map to categorize keypairs by their type
keypairMap := make(map[accounts.KeypairType][]*accounts.Keypair)
for _, kp := range kps {
keypairMap[kp.Type] = append(keypairMap[kp.Type], kp)
}
// Check profile keypair
profileKps, ok := keypairMap[accounts.KeypairTypeProfile]
require.True(t, ok, "Profile keypair not found")
require.True(t, len(profileKps) == 1, "Unexpected number of profile keypairs")
require.True(t, len(profileKps[0].Accounts) == 3)
for _, a := range profileKps[0].Accounts {
require.Equal(t, a.KeyUID, oldMobileUserKeyUID)
}
generator := b.AccountManager().AccountsGenerator()
// Check seed keypair
seedKps, ok := keypairMap[accounts.KeypairTypeSeed]
require.True(t, ok, "Seed keypair not found")
require.True(t, len(seedKps) == 1, "Unexpected number of seed keypairs")
require.True(t, len(seedKps[0].Accounts) == 1)
info, err := generator.LoadAccount(seedKps[0].Accounts[0].Address.Hex(), oldMobileUserPasswd)
require.NoError(t, err)
require.Equal(t, seedKps[0].KeyUID, info.KeyUID)
require.Equal(t, seedKps[0].Accounts[0].KeyUID, info.KeyUID)
mnemonicNoExtraSpaces := strings.Join(strings.Fields("vocal blouse script census island armor seek catch wool narrow peasant attract"), " ")
importedSeedAccountInfo, err := generator.ImportMnemonic(mnemonicNoExtraSpaces, "")
require.NoError(t, err)
derivedAddresses, err := generator.DeriveAddresses(importedSeedAccountInfo.ID, paths)
require.NoError(t, err)
require.Equal(t, derivedAddresses[pathDefaultWallet].PublicKey, "0x04fde3e58a7379161da2adf033fbee076e2ba11fca8b07c4d06610b399911a60017e4c108eae243487d19e273f99c2d6af13ff5e330783f4389212092b01cc616c")
//TODO(frank) we need fix following line
//require.True(t, importedSeedAccountInfo.KeyUID == seedKps[0].KeyUID)
// Check key keypair
keyKps, ok := keypairMap[accounts.KeypairTypeKey]
require.True(t, ok, "Key keypair not found")
require.True(t, len(keyKps) == 1, "Unexpected number of key keypairs")
require.True(t, len(keyKps[0].Accounts) == 1)
info, err = generator.LoadAccount(keyKps[0].Accounts[0].Address.Hex(), oldMobileUserPasswd)
require.NoError(t, err)
require.Equal(t, keyKps[0].KeyUID, info.KeyUID)
require.Equal(t, keyKps[0].Accounts[0].KeyUID, info.KeyUID)
info, err = generator.ImportPrivateKey("c3ad0b50652318f845565c13761e5369ce75dcbc2a94616e15b829d4b07410fe")
require.NoError(t, err)
require.Equal(t, keyKps[0].KeyUID, info.KeyUID)
require.NoError(t, b.Logout())
}
func TestLoginAndMigrationsStillWorkWithExistingMobileUser(t *testing.T) {
utils.Init()
srcFolder := "../static/test-mobile-release-1.20.x-aa6e4b2-account/"
tmpdir := t.TempDir()
copyDir(srcFolder, tmpdir, t)
loginMobileUser(t, tmpdir)
loginMobileUser(t, tmpdir) // Login twice to catch weird errors that only appear after logout
}
// TestAddWalletAccount for test data description pls see comments within loginMobileUser
func TestAddWalletAccountAfterUpgradingFromMobileV1(t *testing.T) {
utils.Init()
srcFolder := "../static/test-mobile-release-1.20.x-aa6e4b2-account/"
tmpdir := t.TempDir()
copyDir(srcFolder, tmpdir, t)
b := NewGethStatusBackend()
b.UpdateRootDataDir(tmpdir)
require.NoError(t, b.OpenAccounts())
require.NoError(t, b.Login(oldMobileUserKeyUID, oldMobileUserPasswd))
db, _ := accounts.NewDB(b.appDB)
walletRootAddress, err := db.GetWalletRootAddress()
require.NoError(t, err)
masterAddress, err := db.GetMasterAddress()
require.NoError(t, err)
kps, _ := db.GetAllKeypairs()
// Create a map to categorize keypairs by their type
keypairMap := make(map[accounts.KeypairType][]*accounts.Keypair)
for _, kp := range kps {
keypairMap[kp.Type] = append(keypairMap[kp.Type], kp)
}
profileKps := keypairMap[accounts.KeypairTypeProfile]
profileKp := profileKps[0]
require.True(t, profileKp.DerivedFrom == walletRootAddress.Hex())
require.False(t, masterAddress.Hex() == walletRootAddress.Hex())
// simulate mobile frontend adding a wallet account
suggestedPath, err := db.ResolveSuggestedPathForKeypair(oldMobileUserKeyUID)
require.NoError(t, err)
generator := b.AccountManager().AccountsGenerator()
accountInfo, err := generator.LoadAccount(profileKp.DerivedFrom, oldMobileUserPasswd)
require.NoError(t, err)
infoMap, err := generator.DeriveAddresses(accountInfo.ID, []string{suggestedPath})
require.NoError(t, err)
require.Len(t, infoMap, 1)
deriveAccountInfo := infoMap[suggestedPath]
derivedAddress := types.HexToAddress(deriveAccountInfo.Address)
accountsAPI := b.StatusNode().AccountService().AccountsAPI()
err = accountsAPI.AddAccount(context.Background(), oldMobileUserPasswd, &accounts.Account{
Address: derivedAddress,
KeyUID: oldMobileUserKeyUID,
Wallet: false,
Chat: false,
Type: accounts.AccountTypeGenerated,
Path: suggestedPath,
PublicKey: types.Hex2Bytes(deriveAccountInfo.PublicKey),
Name: "GeneratedAccount2",
Emoji: "emoji",
ColorID: common.CustomizationColorBlue,
})
require.NoError(t, err)
// need retry since there's a possible of getting "no key for given address or file" error
err = tt.RetryWithBackOff(func() error {
return accountsAPI.DeleteAccount(context.Background(), derivedAddress)
})
require.NoError(t, err)
require.NoError(t, b.Logout())
}
func TestChangeDatabasePassword(t *testing.T) { func TestChangeDatabasePassword(t *testing.T) {
oldPassword := "password" oldPassword := "password"
newPassword := "newPassword" newPassword := "newPassword"

187
api/old_mobile_user_upgrading_from_v1_to_v2_test.go Normal file
View File

@ -0,0 +1,187 @@
package api
import (
"context"
"strings"
"testing"
"github.com/stretchr/testify/suite"
"github.com/status-im/status-go/appdatabase"
"github.com/status-im/status-go/common/dbsetup"
"github.com/status-im/status-go/eth-node/types"
"github.com/status-im/status-go/multiaccounts/accounts"
"github.com/status-im/status-go/multiaccounts/common"
"github.com/status-im/status-go/protocol/tt"
"github.com/status-im/status-go/sqlite"
"github.com/status-im/status-go/t/utils"
)
const (
oldMobileUserKeyUID = "0x855ab0a932e5325daab7a550b9fcd78d2a17de5e2b7a52241f82505ea9d87629"
oldMobileUserPasswd = "0x20756cad9b728c8225fd8cedb6badaf8731e174506950219ea657cd54f35f46c" // #nosec G101
// what we have in table `accounts` before test run:
// 1. Address: 0x23A5CEF34B18920785F4B895849936F65CBDEF73
// Wallet: 1, Chat: 0, Type: '', Path: m/44'/60'/0'/0/0, Name: 'Main account', Derived_from: '', Pubkey: 0x047B67AD2...
// 2. Address: 0x4851276E2B7DC3B8BEF1749127031BCB3578492D
// Wallet: 0, Chat: 1, Type: '', Path: m/43'/60'/1581'/0'/0, Name: 'Cadetblue Fuzzy Flickertailsquirrel', Derived_from: '', Pubkey: 0x04F96F6F5...
// 3. Address: 0x4D26E5C2F85BA5D10BDA6B031E1C1579F8ECFA1F
// Wallet: 0, Chat: 0, Type: 'generated', Path: m/44'/60'/0'/1, Name: 'generated', Derived_from: '', Pubkey: 0x04488EDA7...
// 4. Address: 0x516312D69737C5E6EF16F22E0097FF5D9F0C4196
// Wallet: 0, Chat: 0, Type: 'key', Path: m/44'/60'/0'/0/0, Name: 'key', Derived_from: '', Pubkey: 0x040D5E4E3...
// 5. Address: 0x95222290DD7278AA3DDD389CC1E1D165CC4BAFE5
// Wallet: 0, Chat: 0, Type: 'watch', Path: '', Name: 'watch-only', Derived_from: '', Pubkey: <null>
// 6. Address: 0xB7A1233D1309CE665A3A4DB088E4A046EB333545
// Wallet: 0, Chat: 0, Type: 'seed', Path: m/44'/60'/0'/0/0, Name: 'seed', Derived_from: '', Pubkey: 0x04FDE3E5...
// seed phrase for 0xB7A1233D1309CE665A3A4DB088E4A046EB333545: vocal blouse script census island armor seek catch wool narrow peasant attract
// private key for 0x516312D69737C5E6EF16F22E0097FF5D9F0C4196: c3ad0b50652318f845565c13761e5369ce75dcbc2a94616e15b829d4b07410fe
srcFolder = "../static/test-mobile-release-1.20.x-aa6e4b2-account/"
)
type OldMobileUserUpgradingFromV1ToV2Test struct {
suite.Suite
tmpdir string
}
func (s *OldMobileUserUpgradingFromV1ToV2Test) SetupTest() {
utils.Init()
s.tmpdir = s.T().TempDir()
copyDir(srcFolder, s.tmpdir, s.T())
}
func TestOldMobileUserUpgradingFromV1ToV2(t *testing.T) {
suite.Run(t, new(OldMobileUserUpgradingFromV1ToV2Test))
}
func (s *OldMobileUserUpgradingFromV1ToV2Test) loginMobileUser() {
b := NewGethStatusBackend()
b.UpdateRootDataDir(s.tmpdir)
s.Require().NoError(b.OpenAccounts())
s.Require().NoError(b.Login(oldMobileUserKeyUID, oldMobileUserPasswd))
db, err := accounts.NewDB(b.appDB)
s.Require().NoError(err)
accs, err := db.GetAllAccounts()
s.Require().NoError(err)
s.Require().True(len(accs) == 6)
kps, err := db.GetAllKeypairs()
s.Require().NoError(err)
s.Require().True(len(kps) == 3)
// Create a map to categorize keypairs by their type
keypairMap := make(map[accounts.KeypairType][]*accounts.Keypair)
for _, kp := range kps {
keypairMap[kp.Type] = append(keypairMap[kp.Type], kp)
}
// Check profile keypair
profileKps, ok := keypairMap[accounts.KeypairTypeProfile]
s.Require().True(ok, "Profile keypair not found")
s.Require().True(len(profileKps) == 1, "Unexpected number of profile keypairs")
s.Require().True(len(profileKps[0].Accounts) == 3)
for _, a := range profileKps[0].Accounts {
s.Require().Equal(a.KeyUID, oldMobileUserKeyUID)
}
generator := b.AccountManager().AccountsGenerator()
// Check seed keypair
seedKps, ok := keypairMap[accounts.KeypairTypeSeed]
s.Require().True(ok, "Seed keypair not found")
s.Require().True(len(seedKps) == 1, "Unexpected number of seed keypairs")
s.Require().True(len(seedKps[0].Accounts) == 1)
info, err := generator.LoadAccount(seedKps[0].Accounts[0].Address.Hex(), oldMobileUserPasswd)
s.Require().NoError(err)
s.Require().Equal(seedKps[0].KeyUID, info.KeyUID)
s.Require().Equal(seedKps[0].Accounts[0].KeyUID, info.KeyUID)
mnemonicNoExtraSpaces := strings.Join(strings.Fields("vocal blouse script census island armor seek catch wool narrow peasant attract"), " ")
importedSeedAccountInfo, err := generator.ImportMnemonic(mnemonicNoExtraSpaces, "")
s.Require().NoError(err)
derivedAddresses, err := generator.DeriveAddresses(importedSeedAccountInfo.ID, paths)
s.Require().NoError(err)
s.Require().Equal(derivedAddresses[pathDefaultWallet].PublicKey, "0x04fde3e58a7379161da2adf033fbee076e2ba11fca8b07c4d06610b399911a60017e4c108eae243487d19e273f99c2d6af13ff5e330783f4389212092b01cc616c")
//TODO(frank) we need fix following line
//require.True(t, importedSeedAccountInfo.KeyUID == seedKps[0].KeyUID)
// Check key keypair
keyKps, ok := keypairMap[accounts.KeypairTypeKey]
s.Require().True(ok, "Key keypair not found")
s.Require().True(len(keyKps) == 1, "Unexpected number of key keypairs")
s.Require().True(len(keyKps[0].Accounts) == 1)
info, err = generator.LoadAccount(keyKps[0].Accounts[0].Address.Hex(), oldMobileUserPasswd)
s.Require().NoError(err)
s.Require().Equal(keyKps[0].KeyUID, info.KeyUID)
s.Require().Equal(keyKps[0].Accounts[0].KeyUID, info.KeyUID)
info, err = generator.ImportPrivateKey("c3ad0b50652318f845565c13761e5369ce75dcbc2a94616e15b829d4b07410fe")
s.Require().NoError(err)
s.Require().Equal(info.KeyUID, keyKps[0].KeyUID)
s.Require().NoError(b.Logout())
}
func (s *OldMobileUserUpgradingFromV1ToV2Test) TestLoginAndMigrationsStillWorkWithExistingMobileUser() {
s.loginMobileUser()
s.loginMobileUser() // Login twice to catch weird errors that only appear after logout
}
// TestAddWalletAccount we should be able to add a wallet account after upgrading from mobile v1
func (s *OldMobileUserUpgradingFromV1ToV2Test) TestAddWalletAccountAfterUpgradingFromMobileV1() {
b := NewGethStatusBackend()
b.UpdateRootDataDir(s.tmpdir)
s.Require().NoError(b.OpenAccounts())
s.Require().NoError(b.Login(oldMobileUserKeyUID, oldMobileUserPasswd))
db, _ := accounts.NewDB(b.appDB)
walletRootAddress, err := db.GetWalletRootAddress()
s.Require().NoError(err)
masterAddress, err := db.GetMasterAddress()
s.Require().NoError(err)
kps, _ := db.GetAllKeypairs()
// Create a map to categorize keypairs by their type
keypairMap := make(map[accounts.KeypairType][]*accounts.Keypair)
for _, kp := range kps {
keypairMap[kp.Type] = append(keypairMap[kp.Type], kp)
}
profileKps := keypairMap[accounts.KeypairTypeProfile]
profileKp := profileKps[0]
s.Require().True(profileKp.DerivedFrom == walletRootAddress.Hex())
s.Require().False(masterAddress.Hex() == walletRootAddress.Hex())
// simulate mobile frontend adding a wallet account
suggestedPath, err := db.ResolveSuggestedPathForKeypair(oldMobileUserKeyUID)
s.Require().NoError(err)
generator := b.AccountManager().AccountsGenerator()
accountInfo, err := generator.LoadAccount(profileKp.DerivedFrom, oldMobileUserPasswd)
s.Require().NoError(err)
infoMap, err := generator.DeriveAddresses(accountInfo.ID, []string{suggestedPath})
s.Require().NoError(err)
s.Require().Len(infoMap, 1)
deriveAccountInfo := infoMap[suggestedPath]
derivedAddress := types.HexToAddress(deriveAccountInfo.Address)
accountsAPI := b.StatusNode().AccountService().AccountsAPI()
err = accountsAPI.AddAccount(context.Background(), oldMobileUserPasswd, &accounts.Account{
Address: derivedAddress,
KeyUID: oldMobileUserKeyUID,
Wallet: false,
Chat: false,
Type: accounts.AccountTypeGenerated,
Path: suggestedPath,
PublicKey: types.Hex2Bytes(deriveAccountInfo.PublicKey),
Name: "GeneratedAccount2",
Emoji: "emoji",
ColorID: common.CustomizationColorBlue,
})
s.Require().NoError(err)
// need retry since there's a possible of getting "no key for given address or file" error
err = tt.RetryWithBackOff(func() error {
return accountsAPI.DeleteAccount(context.Background(), derivedAddress)
})
s.Require().NoError(err)
s.Require().NoError(b.Logout())
}
func (s *OldMobileUserUpgradingFromV1ToV2Test) TestFixMissingKeyUIDForAccounts() {
// prepare an empty database
_, err := appdatabase.InitializeDB(sqlite.InMemoryPath, "1234567890", dbsetup.ReducedKDFIterationsNumber)
// sql.ErrNoRows is expected here when query with: `SELECT wallet_root_address FROM settings WHERE synthetic_id='id'`
// but fixMissingKeyUIDForAccounts should return nil
s.Require().NoError(err)
}

5
appdatabase/database.go
View File

@ -89,11 +89,6 @@ func InitializeDB(path, password string, kdfIterationsNumber int) (*sql.DB, erro
func fixMissingKeyUIDForAccounts(sqlTx *sql.Tx) error { func fixMissingKeyUIDForAccounts(sqlTx *sql.Tx) error {
rows, err := sqlTx.Query(`SELECT address,pubkey FROM accounts WHERE pubkey IS NOT NULL AND type != '' AND type != 'generated'`) rows, err := sqlTx.Query(`SELECT address,pubkey FROM accounts WHERE pubkey IS NOT NULL AND type != '' AND type != 'generated'`)
if err == sql.ErrNoRows {
// we shouldn't reach here, but if we do, it probably happened from the test
log.Warn("Migrating accounts: no accounts found")
return nil
}
if err != nil { if err != nil {
log.Error("Migrating accounts: failed to query accounts", "err", err.Error()) log.Error("Migrating accounts: failed to query accounts", "err", err.Error())
return err return err